From d2fdf92ebb987f46ddef046963f8715868327bb8 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 10 Apr 2026 17:41:41 +0000 Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=20Bolt:=20[performance=20improvement]?= =?UTF-8?q?=20Eliminate=20O(E)=20PathBuf=20allocations=20in=20Tarjan's=20S?= =?UTF-8?q?CC?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com> --- crates/flow/src/incremental/invalidation.rs | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/crates/flow/src/incremental/invalidation.rs b/crates/flow/src/incremental/invalidation.rs index da9ac9c..821d6f9 100644 --- a/crates/flow/src/incremental/invalidation.rs +++ b/crates/flow/src/incremental/invalidation.rs @@ -342,11 +342,12 @@ impl InvalidationDetector { fn tarjan_dfs(&self, v: &Path, state: &mut TarjanState, sccs: &mut Vec>) { // Initialize node let index = state.index_counter; - state.indices.insert(v.to_path_buf(), index); - state.lowlinks.insert(v.to_path_buf(), index); + let v_buf = v.to_path_buf(); + state.indices.insert(v_buf.clone(), index); + state.lowlinks.insert(v_buf.clone(), index); state.index_counter += 1; - state.stack.push(v.to_path_buf()); - state.on_stack.insert(v.to_path_buf()); + state.stack.push(v_buf.clone()); + state.on_stack.insert(v_buf); // Visit all successors (dependencies) let dependencies = self.graph.get_dependencies(v); @@ -358,19 +359,19 @@ impl InvalidationDetector { // Update lowlink let w_lowlink = *state.lowlinks.get(dep).unwrap(); - let v_lowlink = state.lowlinks.get_mut(&v.to_path_buf()).unwrap(); + let v_lowlink = state.lowlinks.get_mut(v).unwrap(); *v_lowlink = (*v_lowlink).min(w_lowlink); } else if state.on_stack.contains(dep) { // Successor is on stack (part of current SCC) let w_index = *state.indices.get(dep).unwrap(); - let v_lowlink = state.lowlinks.get_mut(&v.to_path_buf()).unwrap(); + let v_lowlink = state.lowlinks.get_mut(v).unwrap(); *v_lowlink = (*v_lowlink).min(w_index); } } // If v is a root node, pop the stack to create an SCC - let v_index = *state.indices.get(&v.to_path_buf()).unwrap(); - let v_lowlink = *state.lowlinks.get(&v.to_path_buf()).unwrap(); + let v_index = *state.indices.get(v).unwrap(); + let v_lowlink = *state.lowlinks.get(v).unwrap(); if v_lowlink == v_index { let mut scc = Vec::new();