From d33845a2880bb7824def061583032b7df4210c8d Mon Sep 17 00:00:00 2001 From: kkdev92 Date: Thu, 13 Aug 2026 10:03:34 +0900 Subject: [PATCH] chore: fail the lint run on a warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `eslint src` exits zero on warnings, so a rule set to `warn` reported into the log and nothing stopped it accumulating. `--max-warnings 0` makes the lane say no. Nothing to clean up first: the run currently reports zero errors and zero warnings, so this changes no output today. What it changes is tomorrow — a rule that is deliberately a warning rather than an error now has to be dealt with rather than scrolled past. `lint:fix` is left alone. Adding the flag there would fail the run after fixing what it could, which is the opposite of what that script is for. Prettier deliberately not added. Formatting is the other half of "maximally strict", but introducing it now would reformat files wholesale and bury the next few diffs; that is a decision worth taking on its own. `vscode-ext-kit` has carried this flag for a while, so this brings the three extensions in line with it. Verified: lint, type check and the test suite. Co-Authored-By: Claude Opus 5 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 2438d68..dc01608 100644 --- a/package.json +++ b/package.json @@ -548,7 +548,7 @@ "bundle:prod": "node scripts/build.mjs --production", "bundle:watch": "node scripts/build.mjs --watch", "typecheck": "tsc --noEmit && tsc -p src/webview --noEmit", - "lint": "eslint src", + "lint": "eslint src --max-warnings 0", "lint:fix": "eslint src --fix", "check:l10n": "node scripts/l10n.mjs", "l10n:write": "node scripts/l10n.mjs --write",