Implement Get-Error cmdlet as Experimental Feature (PowerShell#10727)

Author: SteveL-MSFT

src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs

@@ -735,15 +735,34 @@ public ConsoleColorProxy(ConsoleHostUserInterface ui)
                 _ui = ui;
             }
 
+            public ConsoleColor FormatAccentColor
+            {
+                [SuppressMessage("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
+                get
+                {
+                    return _ui.FormatAccentColor;
+                }
+
+                [SuppressMessage("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
+                set
+                {
+                    _ui.FormatAccentColor = value;
+                }
+            }
+
             public ConsoleColor ErrorAccentColor
             {
                 [SuppressMessage("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
                 get
-                { return _ui.ErrorAccentColor; }
+                {
+                    return _ui.ErrorAccentColor;
+                }
 
                 [SuppressMessage("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
                 set
-                { _ui.ErrorAccentColor = value; }
+                {
+                    _ui.ErrorAccentColor = value;
+                }
             }
 
             public ConsoleColor ErrorForegroundColor

src/Modules/Unix/Microsoft.PowerShell.Utility/Microsoft.PowerShell.Utility.psd1

@@ -25,7 +25,7 @@ CmdletsToExport = @(
   'Get-TraceSource', 'Set-TraceSource', 'Add-Type', 'Get-TypeData', 'Remove-TypeData', 'Update-TypeData',
   'Get-UICulture', 'Get-Unique', 'Get-Uptime', 'Clear-Variable', 'Get-Variable', 'New-Variable',
   'Remove-Variable', 'Set-Variable', 'Get-Verb', 'Write-Verbose', 'Write-Warning', 'Invoke-WebRequest',
-  'Format-Wide', 'ConvertTo-Xml', 'Select-Xml', 'Get-Error', 'Update-List'
+  'Format-Wide', 'ConvertTo-Xml', 'Select-Xml', 'Get-Error'
 )
 FunctionsToExport = @()
 AliasesToExport = @('fhx')

src/Modules/Windows/Microsoft.PowerShell.Utility/Microsoft.PowerShell.Utility.psd1

@@ -23,8 +23,7 @@ CmdletsToExport = @(
   'ConvertFrom-StringData', 'Format-Table', 'New-TemporaryFile', 'New-TimeSpan', 'Get-TraceSource', 'Set-TraceSource',
   'Add-Type', 'Get-TypeData', 'Remove-TypeData', 'Update-TypeData', 'Get-UICulture', 'Get-Unique', 'Get-Uptime',
   'Clear-Variable', 'Get-Variable', 'New-Variable', 'Remove-Variable', 'Set-Variable', 'Get-Verb', 'Write-Verbose',
-  'Write-Warning', 'Invoke-WebRequest', 'Format-Wide', 'ConvertTo-Xml', 'Select-Xml', 'Get-Error', 'Update-List',
-  'Out-GridView', 'Show-Command', 'Out-Printer'
+  'Write-Warning', 'Invoke-WebRequest', 'Format-Wide', 'ConvertTo-Xml', 'Select-Xml', 'Get-Error'
 )
 FunctionsToExport = @()
 AliasesToExport = @('fhx')

src/System.Management.Automation/FormatAndOutput/DefaultFormatters/PowerShellCore_format_ps1xml.cs

@@ -733,38 +733,48 @@ private static IEnumerable<FormatViewDefinition> ViewsOf_System_Management_Autom
         {
             yield return new FormatViewDefinition("GetErrorInstance",
                 CustomControl.Create()
-                    .GroupByProperty("PSErrorIndex", label: "ErrorIndex")
+                    .GroupByProperty("PSErrorIndex", label: "ErrorIdentifier")
                     .StartEntry()
                         .AddScriptBlockExpressionBinding(@"
-                            Set-StrictMode -Off
-
                             $maxDepth = 10
                             $ellipsis = ""`u{2026}""
                             $resetColor = ''
-                            if ($Host.UI.SupportsVirtualTerminal -and !(Test-Path env:__SuppressAnsiEscapeSequences)) {
-                                $resetColor = [System.Management.Automation.VTUtility]::GetEscapeSequence(
-                                    [System.Management.Automation.VTUtility+VT]::Reset
-                                )
+                            if ($Host.UI.SupportsVirtualTerminal) {
+                                $resetColor = ""`e[0m""
                             }
 
-                            function Get-VT100Color([ConsoleColor] $color) {
-                                if (!$Host.UI.SupportsVirtualTerminal -or (Test-Path env:__SuppressAnsiEscapeSequences)) {
+                            function Get-VT100Color([string] $color) {
+                                if (! $Host.UI.SupportsVirtualTerminal) {
                                     return ''
                                 }
 
-                                return [System.Management.Automation.VTUtility]::GetEscapeSequence($color)
+                                $colors = @{
+                                    'Black' = ""`e[2;30m""
+                                    'DarkRed' = ""`e[2;31m""
+                                    'DarkGreen' = ""`e[2;32m""
+                                    'DarkYellow' = ""`e[2;33m""
+                                    'DarkBlue' = ""`e[2;34m""
+                                    'DarkMagenta' = ""`e[2;35m""
+                                    'DarkCyan' = ""`e[2;36m""
+                                    'Gray' = ""`e[2;37m""
+                                    'DarkGray' = ""`e[1;30m""
+                                    'Red' = ""`e[1;31m""
+                                    'Green' = ""`e[1;32m""
+                                    'Yellow' = ""`e[1;33m""
+                                    'Blue' = ""`e[1;34m""
+                                    'Magenta' = ""`e[1;35m""
+                                    'Cyan' = ""`e[1;36m""
+                                    'White' = ""`e[1;37m""
+                                }
+
+                                return $colors[$color]
                             }
 
                             function Show-ErrorRecord($obj, [int]$indent = 0, [int]$depth = 1) {
                                 $newline = [Environment]::Newline
                                 $output = [System.Text.StringBuilder]::new()
                                 $prefix = ' ' * $indent
-                                $accentColor = ''
-
-                                if ($null -ne $Host.PrivateData) {
-                                    $accentColor = Get-VT100Color ($Host.PrivateData.FormatAccentColor ?? $Host.PrivateData.ErrorForegroundColor)
-                                }
-
+                                $accentColor = Get-VT100Color $Host.PrivateData.FormatAccentColor
                                 $expandTypes = @(
                                     'Microsoft.Rest.HttpRequestMessageWrapper'
                                     'Microsoft.Rest.HttpResponseMessageWrapper'
@@ -1022,18 +1032,6 @@ function Get-ConciseViewPositionMessage {
                                             }
 
                                             return ($string.Substring(0,$length) -split '\s',-2)[0]
-
-                                            #if (-not $string.Contains(' ')) {
-                                            #    return $string.Substring(0, $length)
-                                            #}
-
-                                            #$split = $string.Substring(0, $length).Split(' ')
-                                            #if ($split.Count -gt 1) {
-                                            #    return [string]::Join(' ', $split, 0, $split.Count - 1)
-                                            #}
-                                            #else {
-                                            #    return $split[0]
-                                            #}
                                         }
 
                                         $errorColor = ''