From 8191a1159309117cc100481f8679cca248395f54 Mon Sep 17 00:00:00 2001
From: CarlosGamero <carlos.gamero@lokalise.com>
Date: Mon, 16 Mar 2026 17:48:16 +0100
Subject: [PATCH 1/2] Solving constructor type issue

---
 .../message-error/PrometheusMessageErrorCounter.spec.ts  | 4 ----
 .../message-error/PrometheusMessageErrorCounter.ts       | 9 +++++++++
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.spec.ts b/packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.spec.ts
index 52ed7db3..3fa5dc1f 100644
--- a/packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.spec.ts
+++ b/packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.spec.ts
@@ -21,7 +21,6 @@ describe('PrometheusMessageErrorCounter', () => {
       {
         name: 'test_metric',
         helpDescription: 'test description',
-        labelNames: ['errorReason'],
         messageVersion: (metadata: ProcessedMessageMetadata<TestMessage>) => {
           registeredMessages.push(metadata) // Mocking it to check if value is registered properly
           return undefined
@@ -85,7 +84,6 @@ describe('PrometheusMessageErrorCounter', () => {
       {
         name: 'Test metric',
         helpDescription: 'test description',
-        labelNames: ['errorReason'],
       },
       promClient,
     )
@@ -120,7 +118,6 @@ describe('PrometheusMessageErrorCounter', () => {
       {
         name: 'Test metric',
         helpDescription: 'test description',
-        labelNames: ['errorReason'],
       },
       promClient,
     )
@@ -168,7 +165,6 @@ describe('PrometheusMessageErrorCounter', () => {
       {
         name: 'Test metric',
         helpDescription: 'test description',
-        labelNames: ['errorReason'],
         messageVersion: (metadata: ProcessedMessageMetadata<TestMessage>) =>
           metadata.message?.metadata?.schemaVersion,
       },
diff --git a/packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.ts b/packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.ts
index 4da29992..caeadb31 100644
--- a/packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.ts
+++ b/packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.ts
@@ -1,10 +1,19 @@
 import type { ProcessedMessageMetadata } from '@message-queue-toolkit/core'
+import type promClient from 'prom-client'
 import type { LabelValues } from 'prom-client'
+import type { PrometheusMetricParams } from '../../types.ts'
 import { PrometheusMessageCounter } from './PrometheusMessageCounter.ts'
 
 export class PrometheusMessageErrorCounter<
   MessagePayload extends object,
 > extends PrometheusMessageCounter<MessagePayload, 'errorReason'> {
+  constructor(
+    metricParams: Omit<PrometheusMetricParams<MessagePayload, 'errorReason'>, 'labelNames'>,
+    client: typeof promClient,
+  ) {
+    super({ ...metricParams, labelNames: ['errorReason'] }, client)
+  }
+
   protected override getLabelValuesForProcessedMessage(
     metadata: ProcessedMessageMetadata<MessagePayload>,
   ): LabelValues<'errorReason'> {

From 812bc0dde826258b4e852b7bf0414486f6e354cb Mon Sep 17 00:00:00 2001
From: CarlosGamero <carlos.gamero@lokalise.com>
Date: Mon, 16 Mar 2026 17:54:18 +0100
Subject: [PATCH 2/2] Solving incompatibility

---
 .../metrics/message-error/PrometheusMessageErrorCounter.ts      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.ts b/packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.ts
index caeadb31..d36a1ae3 100644
--- a/packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.ts
+++ b/packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.ts
@@ -9,7 +9,7 @@ export class PrometheusMessageErrorCounter<
 > extends PrometheusMessageCounter<MessagePayload, 'errorReason'> {
   constructor(
     metricParams: Omit<PrometheusMetricParams<MessagePayload, 'errorReason'>, 'labelNames'>,
-    client: typeof promClient,
+    client?: typeof promClient,
   ) {
     super({ ...metricParams, labelNames: ['errorReason'] }, client)
   }