scrutinizer ci

Author: Kendrick

DataCollector/GitDataCollector.php

@@ -54,7 +54,7 @@ public function collect(Request $request, Response $response, \Exception $except
 		// get latest commit information
 		exec("git log -1", $data);
 
-		if (isset($data) && $data) {
+		if (isset($data) && !empty($data)) {
 
 			// there is some information
 			$this->data['gitData'] = true;
@@ -73,14 +73,16 @@ public function collect(Request $request, Response $response, \Exception $except
 
 					preg_match('$Author: ([^<]+)<(.+)>$', $d, $author);
 
-					if (isset($author[1])) $this->data['author'] = trim($author[1]);
-					if (isset($author[2])) $this->data['email'] = $author[2];
+					if (isset($author[1])) {
+						$this->data['author'] = trim($author[1]);
+					}
+					if (isset($author[2])) {
+						$this->data['email'] = $author[2];
+					}
 
 				} elseif (strpos($d, 'Date') === 0) {
 
-					// date, ex : Fri Mar 6 16:56:25 2015 +0100
-
-					$date = trim(substr($d, 5));
+					$date = trim(substr($d, 5));    // Fri Mar 6 16:56:25 2015 +0100
 
 					// date of commit
 					$dateCommit = date_create($date);
@@ -90,7 +92,7 @@ public function collect(Request $request, Response $response, \Exception $except
 					$dateNow = date_create($dateRuntime->format('Y-m-d H:i:s'));
 
 					// difference
-					$time = date_diff($dateCommit,$dateNow);
+					$time = date_diff($dateCommit, $dateNow);
 
 					// static time difference : minutes and seconds
 					$this->data['timeCommitIntervalMinutes'] = $time->format('%y')*365*24*60+$time->format('%m')*30*24*60+$time->format('%d')*24*60+$time->format('%h')*60+$time->format('%i');
@@ -125,13 +127,12 @@ public function collect(Request $request, Response $response, \Exception $except
 
 					// branch name
 
-					$this->data['branch'] = trim(substr($data[0], strpos($data[0],'On branch')+9));
+					$this->data['branch'] = trim(substr($data[0], strpos($data[0], 'On branch')+9));
 
 				}
 			}
 
-		}
-		else {
+		} else {
 
 			// no git data
 
@@ -277,7 +278,7 @@ public function getCommitUrl()
 	/**
 	 * Checks and returns the data
 	 *
-	 * @param $data
+	 * @param string $data
 	 * @return string
 	 */
 	private function getData($data)

DependencyInjection/Configuration.php

@@ -11,20 +11,20 @@
  */
 class Configuration implements ConfigurationInterface
 {
-    /**
-     * {@inheritdoc}
-     */
-    public function getConfigTreeBuilder()
-    {
-        $treeBuilder = new TreeBuilder();
-        $rootNode = $treeBuilder->root('symfony_debug_toolbar_git');
+	    /**
+	     * {@inheritdoc}
+	     */
+	    public function getConfigTreeBuilder()
+	    {
+		        $treeBuilder = new TreeBuilder();
+		        $rootNode = $treeBuilder->root('symfony_debug_toolbar_git');
 
-	    $rootNode
-		    ->children()
-	            ->scalarNode('repository_commit_url')
-		    ->end()
-	    ;
+			    $rootNode
+				    ->children()
+			            ->scalarNode('repository_commit_url')
+				    ->end()
+			    ;
 
-        return $treeBuilder;
-    }
+		        return $treeBuilder;
+	    }
 }

DependencyInjection/SymfonyDebugToolbarGitExtension.php

@@ -13,17 +13,17 @@
  */
 class SymfonyDebugToolbarGitExtension extends Extension
 {
-    /**
-     * {@inheritdoc}
-     */
-    public function load(array $configs, ContainerBuilder $container)
-    {
-        $configuration = new Configuration();
-        $config = $this->processConfiguration($configuration, $configs);
+		/**
+		 * {@inheritdoc}
+		 */
+		public function load(array $configs, ContainerBuilder $container)
+		{
+		        $configuration = new Configuration();
+		        $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
-        $loader->load('container.yml');
+		        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+		        $loader->load('container.yml');
 
-	    $container->setParameter('symfony_debug_toolbar_git.repository_commit_url', $config['repository_commit_url']);
-    }
+			    $container->setParameter('symfony_debug_toolbar_git.repository_commit_url', $config['repository_commit_url']);
+		}
 }

README.md

@@ -7,7 +7,7 @@ Symfony Debug Toolbar Git
 
 [![Monthly Downloads](https://poser.pugx.org/kendrick/symfony-debug-toolbar-git/d/monthly.png)](https://packagist.org/packages/kendrick/symfony-debug-toolbar-git) [![Daily Downloads](https://poser.pugx.org/kendrick/symfony-debug-toolbar-git/d/daily.png)](https://packagist.org/packages/kendrick/symfony-debug-toolbar-git)
 
-[![travis CI](https://travis-ci.org/kendrick-k/symfony-debug-toolbar-git.svg?branch=develop)](https://travis-ci.org/kendrick-k/symfony-debug-toolbar-git)
+[![Travis CI](https://travis-ci.org/kendrick-k/symfony-debug-toolbar-git.svg?branch=develop)](https://travis-ci.org/kendrick-k/symfony-debug-toolbar-git) [![Scrutinizer CI](https://scrutinizer-ci.com/g/kendrick-k/symfony-debug-toolbar-git/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/kendrick-k/symfony-debug-toolbar-git/) [![Scrutinizer CI](https://scrutinizer-ci.com/g/kendrick-k/symfony-debug-toolbar-git/badges/build.png?b=master)](https://scrutinizer-ci.com/g/kendrick-k/symfony-debug-toolbar-git/)
 
 ## Symfony toolbar add-on