Improve method names

Author: Art4

src/Redmine/Client/ClientApiTrait.php

@@ -61,11 +61,10 @@ private function isUploadCall(string $path): bool
         return (false !== strpos($path, '/uploads.json')) || (false !== strpos($path, '/uploads.xml'));
     }
 
-    private function isUploadCallAndFilepath(string $path, string $body): bool
+    private function isValidFilePath(string $body): bool
     {
         return
-            $this->isUploadCall($path)
-            && '' !== $body
+            '' !== $body
             && strlen($body) <= \PHP_MAXPATHLEN
             && is_file(strval(str_replace("\0", '', $body)))
         ;

src/Redmine/Client/NativeCurlClient.php

@@ -271,7 +271,7 @@ private function createCurl(string $method, string $path, string $body = '')
         switch ($method) {
             case 'post':
                 $curlOptions[CURLOPT_POST] = 1;
-                if ($this->isUploadCallAndFilepath($path, $body)) {
+                if ($this->isUploadCall($path) && $this->isValidFilePath($body)) {
                     @trigger_error('Uploading an attachment by filepath is deprecated, use file_get_contents() to upload the file content instead.', E_USER_DEPRECATED);
 
                     $file = fopen($body, 'r');

src/Redmine/Client/Psr18Client.php

@@ -181,7 +181,7 @@ private function createRequest(string $method, string $path, string $body = ''):
 
         switch ($method) {
             case 'POST':
-                if ($this->isUploadCallAndFilepath($path, $body)) {
+                if ($this->isUploadCall($path) && $this->isValidFilePath($body)) {
                     @trigger_error('Uploading an attachment by filepath is deprecated, use file_get_contents() to upload the file content instead.', E_USER_DEPRECATED);
 
                     $request = $request->withBody(