Deprecate AbstractApi::delete()

Author: Art4

CHANGELOG.md

@@ -29,6 +29,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `Redmine\Api\AbstractApi::get()` is deprecated, use `\Redmine\Http\HttpClient::request()` instead.
 - `Redmine\Api\AbstractApi::post()` is deprecated, use `\Redmine\Http\HttpClient::request()` instead.
 - `Redmine\Api\AbstractApi::put()` is deprecated, use `\Redmine\Http\HttpClient::request()` instead.
+- `Redmine\Api\AbstractApi::delete()` is deprecated, use `\Redmine\Http\HttpClient::request()` instead.
 - The constant `Redmine\Api\Issue::PRIO_LOW` is deprecated.
 - The constant `Redmine\Api\Issue::PRIO_NORMAL` is deprecated.
 - The constant `Redmine\Api\Issue::PRIO_HIGH` is deprecated.

src/Redmine/Api/AbstractApi.php

@@ -208,12 +208,17 @@ protected function put($path, $data)
     /**
      * Perform the client delete() method.
      *
+     * @deprecated v2.6.0 Use `\Redmine\Http\HttpClient::request()` instead
+     * @see \Redmine\Http\HttpClient::request()
+     *
      * @param string $path
      *
      * @return string
      */
     protected function delete($path)
     {
+        @trigger_error('`' . __METHOD__ . '()` is deprecated since v2.6.0, use `\Redmine\Http\HttpClient::request()` instead.', E_USER_DEPRECATED);
+
         $this->lastResponse = $this->getHttpClient()->request(HttpFactory::makeRequest(
             'DELETE',
             strval($path),

tests/Unit/Api/AbstractApiTest.php

@@ -144,6 +144,34 @@ function ($errno, $errstr): bool {
         $api->runPut('/path.json', 'data');
     }
 
+    public function testDeleteTriggersDeprecationWarning()
+    {
+        $client = $this->createMock(HttpClient::class);
+
+        $api = new class ($client) extends AbstractApi {
+            public function runDelete($path)
+            {
+                return $this->delete($path);
+            }
+        };
+
+        // PHPUnit 10 compatible way to test trigger_error().
+        set_error_handler(
+            function ($errno, $errstr): bool {
+                $this->assertSame(
+                    '`Redmine\Api\AbstractApi::delete()` is deprecated since v2.6.0, use `\Redmine\Http\HttpClient::request()` instead.',
+                    $errstr
+                );
+
+                restore_error_handler();
+                return true;
+            },
+            E_USER_DEPRECATED
+        );
+
+        $api->runDelete('/path.json');
+    }
+
     /**
      * @dataProvider getIsNotNullReturnsCorrectBooleanData
      */