Skip to content
This repository was archived by the owner on Jul 9, 2023. It is now read-only.

Commit 3ebeb58

Browse files
committed
Update CertificateManager.cs
1 parent 9bceb8c commit 3ebeb58

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

src/Titanium.Web.Proxy/Certificates/CertificateManager.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -550,13 +550,6 @@ private static ConcurrentDictionary<string, object> saveCertificateLocks
550550
pendingCertificateCreationTaskLock.Release();
551551
}
552552

553-
// create certificate outside of lock to allow other threads a chance to see the pending task.
554-
// precludes the possiblility of multiple threads simultaneously generating the same certificate,
555-
// we tolerate the case of a duplicate sequential generation due to a race (should be rare)
556-
// t1: await createCertificateTask
557-
// t2: cachedCertificates.TryGetValue->false
558-
// t1: pendingCertificateCreationTasks.Remove
559-
// t2: pendingCertificateCreationTasks.TryGetValue->false
560553
var certificate = await createCertificateTask;
561554

562555
if (createdTask)

0 commit comments

Comments
 (0)