Skip to content

Commit ee656eb

Browse files
committed
Added support for JaCoCo
Added a profile for running JaCoCo to the parent POM and removed the plugin from the <build> of each module. This makes a lot more sense. It's only a dependency if the builder wants to run it.
1 parent c01e80d commit ee656eb

File tree

4 files changed

+33
-14
lines changed

4 files changed

+33
-14
lines changed

module/jsonurl-core/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,6 @@
4848
<groupId>org.apache.maven.plugins</groupId>
4949
<artifactId>maven-source-plugin</artifactId>
5050
</plugin>
51-
<plugin>
52-
<groupId>org.jacoco</groupId>
53-
<artifactId>jacoco-maven-plugin</artifactId>
54-
</plugin>
5551
</plugins>
5652
</build>
5753
</project>

module/jsonurl-jsonorg/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,6 @@
6666
<groupId>org.apache.maven.plugins</groupId>
6767
<artifactId>maven-source-plugin</artifactId>
6868
</plugin>
69-
<plugin>
70-
<groupId>org.jacoco</groupId>
71-
<artifactId>jacoco-maven-plugin</artifactId>
72-
</plugin>
7369
</plugins>
7470
</build>
7571
</project>

module/jsonurl-jsr374/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,6 @@
7171
<groupId>org.apache.maven.plugins</groupId>
7272
<artifactId>maven-source-plugin</artifactId>
7373
</plugin>
74-
<plugin>
75-
<groupId>org.jacoco</groupId>
76-
<artifactId>jacoco-maven-plugin</artifactId>
77-
</plugin>
7874
</plugins>
7975
</build>
8076
</project>

module/pom.xml

Lines changed: 33 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
<maven.site.plugin>3.8.2</maven.site.plugin>
5555
<maven.doxia.plugin>[1.9,)</maven.doxia.plugin>
5656
<maven.project.info.reports.plugin>2.9</maven.project.info.reports.plugin>
57+
<coveralls.plugin>4.3.0</coveralls.plugin>
5758
<nexus.staging.pluggin>1.6.8</nexus.staging.pluggin>
5859
<nexus.url>https://oss.sonatype.org</nexus.url>
5960

@@ -73,6 +74,7 @@
7374
<jsonurl.scm.url>https://github.com/${jsonurl.scm.path}</jsonurl.scm.url>
7475

7576
<checkstyle.config.location>../../config/checkstyle.xml</checkstyle.config.location>
77+
<pmd.config.location>../../config/pmd-ruleset.xml</pmd.config.location>
7678
<jacoco.minimum.coverage>0.40</jacoco.minimum.coverage>
7779
<jacoco.report.dir>target/jacoco</jacoco.report.dir>
7880
</properties>
@@ -217,7 +219,7 @@
217219
<sourceEncoding>${char.encoding}</sourceEncoding>
218220
<targetJdk>${jdk.version}</targetJdk>
219221
<rulesets>
220-
<ruleset>../../config/pmd-ruleset.xml</ruleset>
222+
<ruleset>${pmd.config.location}</ruleset>
221223
</rulesets>
222224
<printFailingErrors>true</printFailingErrors>
223225
<failOnViolation>true</failOnViolation>
@@ -294,6 +296,11 @@
294296
<autoReleaseAfterClose>false</autoReleaseAfterClose>
295297
</configuration>
296298
</plugin>
299+
<plugin>
300+
<groupId>org.eluder.coveralls</groupId>
301+
<artifactId>coveralls-maven-plugin</artifactId>
302+
<version>${coveralls.plugin}</version>
303+
</plugin>
297304
</plugins>
298305
</pluginManagement>
299306
</build>
@@ -337,7 +344,7 @@
337344
<id>pmd</id>
338345
<activation>
339346
<file>
340-
<exists>${basedir}/../../config/pmd-ruleset.xml</exists>
347+
<exists>${basedir}/${pmd.config.location}</exists>
341348
</file>
342349
</activation>
343350
<build>
@@ -378,5 +385,29 @@
378385
</plugins>
379386
</build>
380387
</profile>
388+
389+
<profile>
390+
<id>jacoco</id>
391+
<build>
392+
<plugins>
393+
<plugin>
394+
<groupId>org.jacoco</groupId>
395+
<artifactId>jacoco-maven-plugin</artifactId>
396+
</plugin>
397+
</plugins>
398+
</build>
399+
</profile>
400+
401+
<profile>
402+
<id>coveralls</id>
403+
<build>
404+
<plugins>
405+
<plugin>
406+
<groupId>org.eluder.coveralls</groupId>
407+
<artifactId>coveralls-maven-plugin</artifactId>
408+
</plugin>
409+
</plugins>
410+
</build>
411+
</profile>
381412
</profiles>
382413
</project>

0 commit comments

Comments
 (0)