Backports for 5.2.2 (#431)

* Remove PHPDocumentor & change travis platform for hhvm tests (#429)

* Remove dev-time dependency on phpdocumentor due to resolution headaches

* Switch distro for hhvm testing to trusty (precise now unsupported)

* Bugfix for #424 - add '?' for query string (#425)

Note that this bugfix will cause empty query strings to be dropped (e.g.
http://example.com?#blue becomes http://example.com#blue). This is
because the '?' character is deliberately not captured as part of the
query string, and the testsuite expects to be able to pass an empty
query string and *not* have the '?' added for that case.

Author: erayd

.travis.yml

@@ -18,6 +18,7 @@ matrix:
     - php: 7.1
     - php: 'nightly'
     - php: hhvm
+      dist: trusty
   allow_failures:
     - php: 'nightly'
 

composer.json

@@ -40,9 +40,8 @@
     },
     "require-dev": {
         "json-schema/JSON-Schema-Test-Suite": "1.2.0",
-        "phpunit/phpunit": "^4.8.22",
         "friendsofphp/php-cs-fixer": "^2.1",
-        "phpdocumentor/phpdocumentor": "^2.7"
+        "phpunit/phpunit": "^4.8.22"
     },
     "autoload": {
         "psr-4": { "JsonSchema\\": "src/JsonSchema/" }

src/JsonSchema/Uri/UriResolver.php

@@ -61,8 +61,8 @@ public function generate(array $components)
              . $components['authority']
              . $components['path'];
 
-        if (array_key_exists('query', $components)) {
-            $uri .= $components['query'];
+        if (array_key_exists('query', $components) && strlen($components['query'])) {
+            $uri .= '?' . $components['query'];
         }
         if (array_key_exists('fragment', $components)) {
             $uri .= '#' . $components['fragment'];

tests/Uri/UriResolverTest.php

@@ -172,4 +172,22 @@ public function testResolveEmpty()
             )
         );
     }
+
+    public function testReversable()
+    {
+        $uri = 'scheme://user:password@authority/path?query#fragment';
+        $split = $this->resolver->parse($uri);
+
+        // check that the URI was split as expected
+        $this->assertEquals(array(
+            'scheme' => 'scheme',
+            'authority' => 'user:password@authority',
+            'path' => '/path',
+            'query' => 'query',
+            'fragment' => 'fragment'
+        ), $split);
+
+        // check that the recombined URI matches the original input
+        $this->assertEquals($uri, $this->resolver->generate($split));
+    }
 }