Rewrite cat, simplify some things w/r/t the precision downgrade... I guess I don't need it

Author: TotalTechGeek

defaultMethods.js

@@ -520,11 +520,25 @@ const defaultMethods = {
   },
   '!': (value, _1, _2, engine) => Array.isArray(value) ? !engine.truthy(value[0]) : !engine.truthy(value),
   '!!': (value, _1, _2, engine) => Boolean(Array.isArray(value) ? engine.truthy(value[0]) : engine.truthy(value)),
-  cat: (arr) => {
-    if (typeof arr === 'string') return arr
-    let res = ''
-    for (let i = 0; i < arr.length; i++) res += arr[i]
-    return res
+  cat: {
+    method: (arr) => {
+      if (typeof arr === 'string') return arr
+      if (!Array.isArray(arr)) return arr.toString()
+      let res = ''
+      for (let i = 0; i < arr.length; i++) res += arr[i].toString()
+      return res
+    },
+    deterministic: true,
+    traverse: true,
+    optimizeUnary: true,
+    compile: (data, buildState) => {
+      if (typeof data === 'string') return JSON.stringify(data)
+      if (typeof data === 'number') return '"' + JSON.stringify(data) + '"'
+      if (!Array.isArray(data)) return false
+      let res = buildState.compile`''`
+      for (let i = 0; i < data.length; i++) res = buildState.compile`${res} + ${data[i]}`
+      return buildState.compile`(${res})`
+    }
   },
   keys: ([obj]) => typeof obj === 'object' ? Object.keys(obj) : [],
   pipe: {
@@ -843,14 +857,6 @@ defaultMethods['*'].compile = function (data, buildState) {
     return `(${buildString(data, buildState)}).reduce((a,b) => (+a)*(+b))`
   }
 }
-// @ts-ignore Allow custom attribute
-defaultMethods.cat.compile = function (data, buildState) {
-  if (typeof data === 'string') return JSON.stringify(data)
-  if (!Array.isArray(data)) return false
-  let res = buildState.compile`''`
-  for (let i = 0; i < data.length; i++) res = buildState.compile`${res} + ${data[i]}`
-  return buildState.compile`(${res})`
-}
 
 // @ts-ignore Allow custom attribute
 defaultMethods['!'].compile = function (

logic.js

@@ -154,10 +154,7 @@ class LogicEngine {
       return res
     }
 
-    if (logic && typeof logic === 'object') {
-      if (this.precision && !options.precise && logic.toNumber) return Number(logic)
-      if (Object.keys(logic).length > 0) return this._parse(logic, data, above)
-    }
+    if (logic && typeof logic === 'object' && Object.keys(logic).length > 0) return this._parse(logic, data, above)
 
     return logic
   }

precision/index.js

@@ -17,8 +17,7 @@ export function configurePrecision (engine, constructor) {
       return false
     },
     optimizeUnary: true,
-    deterministic: true,
-    precise: true
+    deterministic: true
   })
 
   engine.addMethod('-', {
@@ -38,8 +37,7 @@ export function configurePrecision (engine, constructor) {
       return false
     },
     optimizeUnary: true,
-    deterministic: true,
-    precise: true
+    deterministic: true
   })
 
   engine.addMethod('*', {
@@ -74,8 +72,7 @@ export function configurePrecision (engine, constructor) {
       }
       return false
     },
-    deterministic: true,
-    precise: true
+    deterministic: true
   })
 
   engine.addMethod('%', {
@@ -92,7 +89,6 @@ export function configurePrecision (engine, constructor) {
       }
       return false
     },
-    deterministic: true,
-    precise: true
+    deterministic: true
   })
 }

precision/scratch.js

@@ -2,6 +2,14 @@ import { LogicEngine } from '../index.js'
 import { Decimal } from 'decimal.js'
 import { configurePrecision } from './index.js'
 
+Decimal.prototype.toString = function () {
+  return this.toFixed()
+}
+
+Decimal.prototype.valueOf = function () {
+  return this.toFixed()
+}
+
 const ieee754Engine = new LogicEngine()
 const decimalEngine = new LogicEngine()
 configurePrecision(decimalEngine, Decimal.clone({ precision: 100 }))