v4.0.0-alpha4 (#619)

* Fix/deviating dbset name (#603)

* test: expose dbset name bug

* fix: deviating dbset name

* chore: add launchSettings.json to gitignore

* chore: delete launchSettings.json from git

* Fix/pagesize (#601)

* feat: new startup for test

* chore: rename startup class

* test: reproduce #599 in test

* fix: zero division error

* chore: remove redundant DefaultPageSize on IPageService

* chore: update .gitignore

* fix: typo LoaDatabaseValues (#608)

* fix: typo

* fix: typo in fix of typo

* chore: enable sql logging in JsonApiDotNetCoreExample

* Acceptance tests EF inheritance (#610)

* chore: create inheritance model + controller

* test: create and patch acceptance test

* chore: close issue

* Improve usability RequestSerializer (#613)

* feat: remove inability to use request serializer with unknown type at runtime

* fix: typo in test setup

* chore: spacing

* fix: add IResourceQueryService and IResourceCmdService to DI container in application builder

* chore: update comments IRequestSerializer

* Move EF core related building to extension methods (#616)

* feat: remove inability to use request serializer with unknown type at runtime

* fix: typo in test setup

* chore: spacing

* fix: add IResourceQueryService and IResourceCmdService to DI container in application builder

* chore: update comments IRequestSerializer

* chore: moved ef core related building to extension methods

* chore: spacing, rename file

* refactor: remove need for internal modifier

* refactor: minor refactor id type retrieval

* Hooks discovery detection of implemented hooks issue (#617)

* fix: discovery issue related to assemblies

* fix: LoaDatabaseValue typo

* fix: set EnableResourceHooks to true by default

* chore: add comment in code in hooksdiscovery

* fix: use IServiceProvider instead of IScopedServiceProvider

* fix: discovery unit test with ServiceProvider instead of ScopedServiceProvider

* refactor: TResource instead of TEntity

* chore: process PR review

* chore: move comment to separate line (stylecop)

* feat: use camelCase as default (#618)

* feat: use camelCase as default

* refactor: massive replace all to replace kebab-case with camelCase default

* chore: fix remaining unit tests

* fix: fix  remaining JsonApiDotNetCoreExampleTests

* feat: introduce proper usage of WebApplicationFactory in KebabCaseFormatterTests

* fix: remaining functional tests

* fix: minor changes PR review

* fix: camelCase revert in comments

* fix: camelCase revert in comments

* fix: camelCase revert in comments

* fix: camelCase revert in comments

Author: maurei

benchmarks/Serialization/JsonApiDeserializer_Benchmarks.cs

@@ -58,7 +58,7 @@ public JsonApideserializer_Benchmarks() {
         public object DeserializeSimpleObject() => _jsonApideserializer.Deserialize<SimpleType>(Content);
 
         private class SimpleType : Identifiable {
-            [Attr("name")]
+            [Attr]
             public string Name { get; set; }
         }
     }

src/Examples/JsonApiDotNetCoreExample/Controllers/CamelCasedModelsController.cs

@@ -6,11 +6,11 @@
 
 namespace JsonApiDotNetCoreExample.Controllers
 {
-    public class CamelCasedModelsController : JsonApiController<CamelCasedModel>
+    public class KebabCasedModelsController : JsonApiController<KebabCasedModel>
     {
-        public CamelCasedModelsController(
+        public KebabCasedModelsController(
             IJsonApiOptions jsonApiOptions,
-            IResourceService<CamelCasedModel> resourceService,
+            IResourceService<KebabCasedModel> resourceService,
             ILoggerFactory loggerFactory) 
             : base(jsonApiOptions, resourceService, loggerFactory)
         { }

src/Examples/JsonApiDotNetCoreExample/Controllers/TodoItemsCustomController.cs

@@ -10,7 +10,7 @@
 
 namespace JsonApiDotNetCoreExample.Controllers
 {
-    [DisableRoutingConvention, Route("custom/route/todo-items")]
+    [DisableRoutingConvention, Route("custom/route/todoItems")]
     public class TodoItemsCustomController : CustomJsonApiController<TodoItem>
     {
         public TodoItemsCustomController(

src/Examples/JsonApiDotNetCoreExample/Controllers/UsersController.cs

@@ -15,4 +15,14 @@ public UsersController(
             : base(jsonApiOptions, resourceService, loggerFactory)
         { }
     }
+
+    public class SuperUsersController : JsonApiController<SuperUser>
+    {
+        public SuperUsersController(
+            IJsonApiOptions jsonApiOptions,
+            IResourceService<SuperUser> resourceService,
+            ILoggerFactory loggerFactory)
+            : base(jsonApiOptions, resourceService, loggerFactory)
+        { }
+    }
 }

src/Examples/JsonApiDotNetCoreExample/Data/AppDbContext.cs

@@ -9,11 +9,12 @@ public class AppDbContext : DbContext
         public DbSet<Passport> Passports { get; set; }
         public DbSet<Person> People { get; set; }
         public DbSet<TodoItemCollection> TodoItemCollections { get; set; }
-        public DbSet<CamelCasedModel> CamelCasedModels { get; set; }
+        public DbSet<KebabCasedModel> KebabCasedModels { get; set; }
         public DbSet<Article> Articles { get; set; }
-        public DbSet<Author> Authors { get; set; }
+        public DbSet<Author> AuthorDifferentDbContextName { get; set; }
         public DbSet<NonJsonApiResource> NonJsonApiResources { get; set; }
         public DbSet<User> Users { get; set; }
+        public DbSet<SuperUser> SuperUsers { get; set; }
         public DbSet<PersonRole> PersonRoles { get; set; }
         public DbSet<ArticleTag> ArticleTags { get; set; }
         public DbSet<IdentifiableArticleTag> IdentifiableArticleTags { get; set; }
@@ -23,6 +24,8 @@ public AppDbContext(DbContextOptions<AppDbContext> options) : base(options) { }
 
         protected override void OnModelCreating(ModelBuilder modelBuilder)
         {
+            modelBuilder.Entity<SuperUser>().HasBaseType<User>();
+
             modelBuilder.Entity<TodoItem>()
                 .Property(t => t.CreatedDate).HasDefaultValueSql("CURRENT_TIMESTAMP").IsRequired();
 
@@ -43,18 +46,18 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
                 .HasKey(bc => new { bc.ArticleId, bc.TagId });
 
             modelBuilder.Entity<Person>()
-                .HasOne(t => t.StakeHolderTodo)
+                .HasOne(t => t.StakeHolderTodoItem)
                 .WithMany(t => t.StakeHolders)
-                .HasForeignKey(t => t.StakeHolderTodoId)
+                .HasForeignKey(t => t.StakeHolderTodoItemId)
                 .OnDelete(DeleteBehavior.Cascade);
 
             modelBuilder.Entity<TodoItem>()
-                .HasOne(t => t.DependentTodoItem);
+                .HasOne(t => t.DependentOnTodo);
 
             modelBuilder.Entity<TodoItem>()
-                .HasMany(t => t.ChildrenTodoItems)
-                .WithOne(t => t.ParentTodoItem)
-                .HasForeignKey(t => t.ParentTodoItemId);
+                .HasMany(t => t.ChildrenTodos)
+                .WithOne(t => t.ParentTodo)
+                .HasForeignKey(t => t.ParentTodoId);
 
             modelBuilder.Entity<Passport>()
                 .HasOne(p => p.Person)
@@ -63,14 +66,14 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
                 .OnDelete(DeleteBehavior.SetNull);
 
             modelBuilder.Entity<TodoItem>()
-                .HasOne(p => p.ToOnePerson)
-                .WithOne(p => p.ToOneTodoItem)
-                .HasForeignKey<TodoItem>(p => p.ToOnePersonId);
+                .HasOne(p => p.OneToOnePerson)
+                .WithOne(p => p.OneToOneTodoItem)
+                .HasForeignKey<TodoItem>(p => p.OneToOnePersonId);
 
             modelBuilder.Entity<Person>()
-                .HasOne(p => p.ToOneTodoItem)
-                .WithOne(p => p.ToOnePerson)
-                .HasForeignKey<TodoItem>(p => p.ToOnePersonId);
+                .HasOne(p => p.OneToOneTodoItem)
+                .WithOne(p => p.OneToOnePerson)
+                .HasForeignKey<TodoItem>(p => p.OneToOnePersonId);
         }
     }
 }

src/Examples/JsonApiDotNetCoreExample/Models/Article.cs

@@ -6,10 +6,10 @@ namespace JsonApiDotNetCoreExample.Models
 {
     public class Article : Identifiable
     {
-        [Attr("name")]
+        [Attr]
         public string Name { get; set; }
 
-        [HasOne("author")]
+        [HasOne]
         public Author Author { get; set; }
         public int AuthorId { get; set; }
 

src/Examples/JsonApiDotNetCoreExample/Models/ArticleTag.cs

@@ -15,11 +15,11 @@ public class ArticleTag
     public class IdentifiableArticleTag : Identifiable
     {
         public int ArticleId { get; set; }
-        [HasOne("article")]
+        [HasOne]
         public Article Article { get; set; }
 
         public int TagId { get; set; }
-        [HasOne("Tag")]
+        [HasOne]
         public Tag Tag { get; set; }
 
         public string SomeMetaData { get; set; }

src/Examples/JsonApiDotNetCoreExample/Models/Author.cs

@@ -5,10 +5,10 @@ namespace JsonApiDotNetCoreExample.Models
 {
     public class Author : Identifiable
     {
-        [Attr("name")]
+        [Attr]
         public string Name { get; set; }
 
-        [HasMany("articles")]
+        [HasMany]
         public List<Article> Articles { get; set; }
     }
 }

src/Examples/JsonApiDotNetCoreExample/Models/CamelCasedModel.cs renamed to src/Examples/JsonApiDotNetCoreExample/Models/KebabCasedModel.cs

@@ -2,10 +2,9 @@
 
 namespace JsonApiDotNetCoreExample.Models
 {
-    [Resource("camelCasedModels")]
-    public class CamelCasedModel : Identifiable
+    public class KebabCasedModel : Identifiable
     {
-        [Attr("compoundAttr")]
+        [Attr]
         public string CompoundAttr { get; set; }
     }
 }

src/Examples/JsonApiDotNetCoreExample/Models/Passport.cs

@@ -5,9 +5,9 @@ namespace JsonApiDotNetCoreExample.Models
     public class Passport : Identifiable
     {
         public virtual int? SocialSecurityNumber { get; set; }
-        public virtual bool IsLocked { get; set; } 
+        public virtual bool IsLocked { get; set; }
 
-        [HasOne("person")]
+        [HasOne]
         public virtual Person Person { get; set; }
     }
 }