Less else

Author: Michael Babker

administrator/components/com_patchtester/PatchTester/Model/PullsModel.php

@@ -425,13 +425,11 @@ protected function _getListCount($query)
 
 			return (int) $this->getDb()->loadResult();
 		}
+
 		// Otherwise fall back to inefficient way of counting all results.
-		else
-		{
-			$this->getDb()->setQuery($query)->execute();
+		$this->getDb()->setQuery($query)->execute();
 
-			return (int) $this->getDb()->getNumRows();
-		}
+		return (int) $this->getDb()->getNumRows();
 	}
 
 	/**

administrator/components/com_patchtester/PatchTester/View/DefaultHtmlView.php

@@ -31,32 +31,30 @@ public function loadTemplate($tpl = null)
 		$file = isset($tpl) ? $this->getLayout() . '_' . $tpl : $this->getLayout();
 		$path = $this->getPath($file);
 
-		if ($path)
+		if (!$path)
 		{
-			// Unset so as not to introduce into template scope
-			unset($tpl);
-			unset($file);
+			throw new \RuntimeException(\JText::sprintf('JLIB_APPLICATION_ERROR_LAYOUTFILE_NOT_FOUND', $file), 500);
+		}
 
-			// Never allow a 'this' property
-			if (isset($this->this))
-			{
-				unset($this->this);
-			}
+		// Unset so as not to introduce into template scope
+		unset($tpl);
+		unset($file);
 
-			// Start an output buffer.
-			ob_start();
+		// Never allow a 'this' property
+		if (isset($this->this))
+		{
+			unset($this->this);
+		}
 
-			// Load the template.
-			include $path;
+		// Start an output buffer.
+		ob_start();
 
-			// Get the layout contents.
-			$output = ob_get_clean();
+		// Load the template.
+		include $path;
 
-			return $output;
-		}
-		else
-		{
-			throw new \RuntimeException(\JText::sprintf('JLIB_APPLICATION_ERROR_LAYOUTFILE_NOT_FOUND', $file), 500);
-		}
+		// Get the layout contents.
+		$output = ob_get_clean();
+
+		return $output;
 	}
 }