Fix a crash bug when REST config can't be loaded

James Westby · James Westby · commit a92953f58969 · 2024-05-15T14:22:48.000+01:00
`discoveryClient` is uninitialized, so the pointer can't be deferenced,
so return an empty struct if there's an error.
diff --git a/pkg/datagatherer/k8s/client.go b/pkg/datagatherer/k8s/client.go
@@ -33,7 +33,7 @@ func NewDiscoveryClient(kubeconfigPath string) (discovery.DiscoveryClient, error
 
 	cfg, err := loadRESTConfig(kubeconfigPath)
 	if err != nil {
-		return *discoveryClient, errors.WithStack(err)
+		return discovery.DiscoveryClient{}, errors.WithStack(err)
 	}
 
 	discoveryClient, err = discovery.NewDiscoveryClientForConfig(cfg)

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ func NewDiscoveryClient(kubeconfigPath string) (discovery.DiscoveryClient, error`
`33`	`33`
`34`	`34`	`cfg, err := loadRESTConfig(kubeconfigPath)`
`35`	`35`	`if err != nil {`
`36`		`- return *discoveryClient, errors.WithStack(err)`
	`36`	`+ return discovery.DiscoveryClient{}, errors.WithStack(err)`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`discoveryClient, err = discovery.NewDiscoveryClientForConfig(cfg)`