OTA refactor #912

ym · 2025-10-29T09:32:01Z

Also implements #344

This PR will be backported to https://github.com/jetkvm/kvm/tree/release/049 as part of 0.4.10. Since we don’t plan to introduce i18n in the 0.4.x series, the translation files will be removed during the backport.

Copilot

Pull Request Overview

This PR introduces a downgrade/version-specific update capability for JetKVM, allowing users to install specific versions from GitHub releases through a new developer mode feature. The changes refactor the OTA (Over-The-Air) update system into a dedicated internal package with improved state management, and add UI components for version-specific updates with downgrade support.

Refactored OTA functionality into internal/ota package with better separation of concerns
Added support for targeting specific app and system versions for updates/downgrades
Introduced new UI components and flows for version-specific updates in developer settings
Enhanced deployment script with connectivity checks and improved error handling

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`internal/ota/*.go`	New OTA package with state management, update logic, and component-based update handling
`ota.go`	Refactored to use new internal OTA package and added RPC methods for component updates
`ui/src/routes/devices.$id.settings.advanced.tsx`	Added developer UI for specifying target versions and initiating version-specific updates
`ui/src/routes/devices.$id.settings.general.update.tsx`	Added downgrade flow and confirmation dialog
`ui/src/components/NestedSettingsGroup.tsx`	New component for visually grouping nested settings
`ui/src/hooks/useVersion.tsx`	Added detection for dev version and downgrade availability fields
`config.go`	Added configurable update API URL support
`scripts/dev_deploy.sh`	Added connectivity checks and SSH options for better deployment reliability
`jsonrpc.go`	Registered new RPC handlers for component-based updates

Comments suppressed due to low confidence (1)

ui/src/routes/devices.$id.settings.general.update.tsx:18

Unused variable setSearchParams.

  const [searchParams, setSearchParams] = useSearchParams();

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ui/src/routes/devices.$id.settings.advanced.tsx

ui/src/routes/devices.$id.settings.general.update.tsx

hw.go

.vscode/settings.json

ui/localization/messages/en.json

adamshiervani · 2025-11-06T10:55:59Z

@ym can you add proper handling of 404? Right now, if you specify a version that doesn't exist, you get redirected to the general/update with a notification that says [Object Object].

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…tings

ota.go

…to 10s

…y set in the componentUpdateError function

…twork connection

…ogging

…an 1 second

…multiple languages

…ate function

…tion

…th improved UI components

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Adam Shiervani <adam.shiervani@gmail.com>

IDisposable · 2025-11-18T19:23:54Z

internal/ota/ota.go

+	}
+
+	url, err, isCustomVersion := s.getUpdateURL(params)
+	traceLogger().Err(err).


Shouldn't this be inside the if err != nil { block?

IDisposable · 2025-11-18T19:25:29Z

internal/ota/ota.go

+
+	req, err := s.newHTTPRequestWithTrace(ctx, "GET", url, nil, traceLogger)
+	if err != nil {
+		return nil, fmt.Errorf("error creating request: %w", err)


Should we insert traceLogger().Err(err).Msg("creating request")

IDisposable · 2025-11-18T19:31:54Z

internal/ota/ota.go

+		scopedLogger.Info().Msg("System is up to date")
+	}
+
+	s.updating = false


Should we just wrap this in a defer up higher in the function to ensure we always clear the flag?

IDisposable · 2025-11-18T19:40:49Z

internal/ota/ota.go

+
+		if params.ResetConfig {
+			scopedLogger.Info().Msg("Resetting config")
+			if err := s.resetConfig(); err != nil {


Since this resetConfig() call will really run against the current app's code, this means that especially in a downgrade there is potential for us to create a "default" config file that is still not readable by the new app version.

Would it be better to create a sentinel flag that the (new version) app-startup could detect, do the reset config itself, then delete the sentinel? That way we know the default config matches the version loaded.

Of course, we don't already have that code in-place, so downgrading to any current release would not do that work, but it would be worthwhile pushing that out (nowish) as a micro-update just so this version's OTA work would be more robust.

IDisposable · 2025-11-18T19:43:40Z

internal/ota/ota.go

+
+	// We don't need set the updating flag to false here. Either it will;
+	// - set to false by the componentUpdateError function
+	// - device will reboot


This is not strictly true, when the if s.rebootNeeded { is not taken, then the flag is still set and we didn't error, nor reboot.

IDisposable · 2025-11-18T19:47:15Z

internal/ota/ota.go

+	// fetch the remote metadata
+	remoteMetadata, err := s.fetchUpdateMetadata(ctx, params)
+	if err != nil {
+		if err == ErrVersionNotFound || errors.Unwrap(err) == ErrVersionNotFound {


if errors.Is(err, ErrVersionNotFound) does the (if needed unwrap) test...

IDisposable · 2025-11-21T20:13:49Z

I apologize... I never clicked submit on these comments. This issue still concerns me as-merged #912 (comment)
@ym

ym · 2025-11-21T20:14:46Z

I apologize... I never clicked submit on these comments. This issue still concerns me as-merged #912 (comment) @ym

That's fine, I will open a new PR to resolve these issues.

ym force-pushed the r/ota branch 2 times, most recently from 9fc745e to 02cf605 Compare October 31, 2025 17:17

ym requested a review from Copilot October 31, 2025 17:17

Copilot AI reviewed Oct 31, 2025

View reviewed changes

ym force-pushed the r/ota branch 2 times, most recently from 797f705 to ae197c5 Compare October 31, 2025 17:39

IDisposable reviewed Oct 31, 2025

View reviewed changes

ui/localization/messages/en.json Outdated Show resolved Hide resolved

ym and others added 14 commits November 7, 2025 08:03

WIP: OTA refactor

85f7f60

refactor: mprove UI settings structure with NestedSettingsGroup

b0e659b

feat: add version update functionality to advanced settings

ab06e37

feat: downgrade

0a98a73

cleanup: ota state

2b3f392

fix: update components

f6b0b72

feat: allow configuration to be reset during update

1e9dcc1

feat: enhance version update settings with reset configuration option

aa7c6fe

feat: redirect to setup page after config reset

95e5e15

Apply suggestion from @Copilot

ef7e662

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

daeb9e3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

32c66a3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat: add acknowledgment checkbox for version changes in advanced set…

e0ff671

…tings

chore: update messages

7c5dfd9

ym force-pushed the r/ota branch from e186d3b to 7c5dfd9 Compare November 7, 2025 08:04

fix: rename redirectUrl to redirectTo

252dcba

ym requested a review from adamshiervani November 7, 2025 09:01

ym marked this pull request as ready for review November 7, 2025 09:01

fix: should return error if version is not available

329ad02

ym force-pushed the r/ota branch from 88b1c97 to 329ad02 Compare November 7, 2025 09:02

ym changed the title ~~WIP: OTA refactor~~ OTA refactor Nov 7, 2025

adamshiervani reviewed Nov 7, 2025

View reviewed changes

ota.go Outdated Show resolved Hide resolved

chore: add requestID to update status API calls and increase timeout …

d205df5

…to 10s

ym force-pushed the r/ota branch from f711eb5 to d205df5 Compare November 18, 2025 03:38

adamshiervani and others added 21 commits November 18, 2025 11:27

Send error the frontend and reset updating state

d8ee8b4

feat: mark updating state during app and system updates

aee9940

chore: remove redundant s.updating = false assignment, as it's alread…

7c79b3e

…y set in the componentUpdateError function

chore: increase update status RPC timeout and max attempts for bad ne…

95be473

…twork connection

chore: disable retry for checkUpdateComponents RPC

f1eb38f

chore: remove early return in doUpdate when custom update is set

6aa740d

feat: add trace logging to OTA download

e79f03d

chore(ota): rename component->downloadComponent in trace logging

88becfe

chore(ota): add trace logging to HTTP requests

fc8cfad

chore(ota): only show selected TLS connection state fields in trace l…

ad8acd0

…ogging

fix(hwReboot): only wait for extra settle time if delay is greater th…

ae3b2b7

…an 1 second

chore: remove unused function readOtpEntropy

5f76e30

feat(ota): set updating immediately

8113cd4

fix(localization): update auto-update description for clarity across …

013e73b

…multiple languages

fix: hwReboot delay should be delayMs

f580631

fix(ota): update redirect URL from /device/setup to /welcome in doUpd…

999c8c7

…ate function

fix: set updating flag to false when update is complete

b8af39c

chore: reduce reboot delay to 3 seconds

892e5f4

chore: increase reboot delay to 7 seconds

ac79724

fix(ota): trigger OTA state update on channel open in newSession func…

5e87d79

…tion

feat(settings): integrate feature flag for version update settings wi…

8142954

…th improved UI components

adamshiervani approved these changes Nov 19, 2025

View reviewed changes

ym merged commit 752fb55 into dev Nov 19, 2025
4 of 5 checks passed

ym deleted the r/ota branch November 19, 2025 14:21

ym added a commit that referenced this pull request Nov 19, 2025

refactor: OTA (#912)

87eb555

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Adam Shiervani <adam.shiervani@gmail.com>

IDisposable reviewed Nov 21, 2025

View reviewed changes

OTA refactor #912

OTA refactor #912

Uh oh!

Conversation

ym commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adamshiervani commented Nov 6, 2025

Uh oh!

Uh oh!

Uh oh!

IDisposable Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

IDisposable Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

IDisposable Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

IDisposable Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

IDisposable Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

IDisposable Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

IDisposable commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ym commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ym commented Oct 29, 2025 •

edited

Loading

IDisposable commented Nov 21, 2025 •

edited

Loading