@@ -312,8 +312,9 @@ void CommChannel::transfer_kv_blocks(
312312 const std::vector<BlockTransferInfo>& block_transfer_info,
313313 folly::Promise<uint32_t >& promise) {
314314 proto::BlockTransferInfos pb_block_transfer_info;
315- if (!block_transfer_info_to_proto (
316- 0x0 , block_transfer_info, &pb_block_transfer_info)) {
315+ if (!block_transfer_info_to_proto (block_transfer_info,
316+ &pb_block_transfer_info)) {
317+ LOG (ERROR) << " transfer_kv_blocks fail: create proto fail!" ;
317318 promise.setValue (0 );
318319 return ;
319320 }
@@ -330,6 +331,8 @@ void CommChannel::transfer_kv_blocks(
330331 proto::BlockTransferInfos pb_block_transfer_info;
331332 if (!block_transfer_info_to_proto (
332333 batch_id, block_transfer_info, &pb_block_transfer_info)) {
334+ LOG (ERROR) << " transfer_kv_blocks with batch id " << batch_id
335+ << " fail: create proto fail!" ;
333336 return ;
334337 }
335338 brpc::Controller cntl;
@@ -351,11 +354,7 @@ class ClientStreamReceiver : public brpc::StreamInputHandler {
351354
352355 ~ClientStreamReceiver () {
353356 if (!promise_set_.exchange (true )) {
354- try {
355- close_promise_.set_value ();
356- } catch (const std::exception& e) {
357- LOG (WARNING) << " Exception in destructor: " << e.what ();
358- }
357+ close_promise_.set_value ();
359358 }
360359 }
361360
@@ -400,8 +399,9 @@ void CommChannel::prefetch_from_storage(
400399 const std::vector<BlockTransferInfo>& block_transfer_info,
401400 std::shared_ptr<std::atomic<uint32_t >>& success_cnt) {
402401 proto::BlockTransferInfos pb_block_transfer_info;
403- if (!block_transfer_info_to_proto (
404- 0x0 , block_transfer_info, &pb_block_transfer_info)) {
402+ if (!block_transfer_info_to_proto (block_transfer_info,
403+ &pb_block_transfer_info)) {
404+ LOG (ERROR) << " prefetch_from_storage fail: create proto fail!" ;
405405 return ;
406406 }
407407 ClientStreamReceiver receiver (flag, success_cnt);
@@ -420,6 +420,7 @@ void CommChannel::prefetch_from_storage(
420420
421421 if (cntl.Failed ()) {
422422 LOG (ERROR) << " Fail to connect stream, " << cntl.ErrorText ();
423+ return ;
423424 }
424425
425426 receiver.get_close_future ().wait ();
0 commit comments