Skip to content

Commit b18b2cb

Browse files
committed
Fix checkstyle warnings.
1 parent 9df05a4 commit b18b2cb

File tree

5 files changed

+29
-13
lines changed

5 files changed

+29
-13
lines changed

checkstyle.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,11 @@
8585
<module name="UnusedImports"/>
8686
<module name="RedundantImport"/>
8787
<module name="LineLength">
88-
<property name="severity" value="warning"/>
88+
<property name="severity" value="error"/>
8989
<property name="max" value="120"/>
9090
</module>
9191
<module name="MethodLength">
92-
<property name="severity" value="warning"/>
92+
<property name="severity" value="error"/>
9393
<property name="max" value="120"/>
9494
</module>
9595
<module name="AnonInnerLength">

src/main/java/com/github/underscore/U.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1873,7 +1873,8 @@ public static <T> List<List<T>> chunkFill(final Iterable<T> iterable, final int
18731873
return chunkFill(iterable, size, size, fillValue);
18741874
}
18751875

1876-
public static <T> List<List<T>> chunkFill(final Iterable<T> iterable, final int size, final int step, final T fillValue) {
1876+
public static <T> List<List<T>> chunkFill(final Iterable<T> iterable, final int size,
1877+
final int step, final T fillValue) {
18771878
if (step <= 0 || size < 0) {
18781879
return newArrayList();
18791880
}

src/test/java/com/github/underscore/ArraysTest.java

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,8 @@ public void chunk() {
300300
assertEquals("[]", new U<Integer>(U.range(7)).chunk(3, 0).toString());
301301
assertEquals("[[a, b], [c, d]]", U.chain(asList("a", "b", "c", "d")).chunk(2).value().toString());
302302
assertEquals("[]", U.chain(asList("a", "b", "c", "d")).chunk(0).value().toString());
303-
assertEquals("[[a, b], [b, c], [c, d], [d]]", U.chain(asList("a", "b", "c", "d")).chunk(2, 1).value().toString());
303+
assertEquals("[[a, b], [b, c], [c, d], [d]]", U.chain(asList("a", "b", "c", "d"))
304+
.chunk(2, 1).value().toString());
304305
assertEquals("[]", U.chain(asList("a", "b", "c", "d")).chunk(4, 0).value().toString());
305306
}
306307

@@ -315,13 +316,16 @@ public void chunkFill() {
315316
assertEquals("[]", U.chunkFill(U.range(7), -2, 3, 500).toString());
316317
assertEquals("[]", U.chunkFill(U.range(7), 2, 0, 500).toString());
317318
assertEquals("[]", U.chunkFill(U.range(7), 2, -2, 500).toString());
318-
assertEquals("[[a, b, c], [d, fill, fill]]", new U<String>(asList("a", "b", "c", "d")).chunkFill(3, "fill").toString());
319+
assertEquals("[[a, b, c], [d, fill, fill]]", new U<String>(asList("a", "b", "c", "d"))
320+
.chunkFill(3, "fill").toString());
319321
assertEquals("[]", new U<String>(asList("a", "b", "c", "d")).chunkFill(0, "fill").toString());
320-
assertEquals("[[0, 1, 2], [2, 3, 4], [4, 5, 500]]", new U<Integer>(U.range(6)).chunkFill(3, 2, 500).toString());
322+
assertEquals("[[0, 1, 2], [2, 3, 4], [4, 5, 500]]", new U<Integer>(U.range(6))
323+
.chunkFill(3, 2, 500).toString());
321324
assertEquals("[]", new U<Integer>(U.range(7)).chunkFill(3, 0, 500).toString());
322325
assertEquals("[[a, b], [c, d]]", U.chain(asList("a", "b", "c", "d")).chunkFill(2, "fill").value().toString());
323326
assertEquals("[]", U.chain(asList("a", "b", "c", "d")).chunkFill(0, "fill").value().toString());
324-
assertEquals("[[a, b], [b, c], [c, d], [d, fill]]", U.chain(asList("a", "b", "c", "d")).chunkFill(2, 1, "fill").value().toString());
327+
assertEquals("[[a, b], [b, c], [c, d], [d, fill]]", U.chain(asList("a", "b", "c", "d"))
328+
.chunkFill(2, 1, "fill").value().toString());
325329
assertEquals("[]", U.chain(asList("a", "b", "c", "d")).chunkFill(4, 0, "fill").value().toString());
326330
}
327331

@@ -383,13 +387,15 @@ public void interpose() {
383387
assertEquals("[]", U.interpose(U.newArrayList(), null).toString());
384388
assertEquals("[0, 1, 2, 3]", U.interpose(U.newArrayList(U.range(4)), null).toString());
385389
assertEquals("[0]", U.interpose(U.range(1), 500).toString());
386-
assertEquals("[a, interpose, b, interpose, c]", new U<String>(asList("a", "b", "c")).interpose("interpose").toString());
390+
assertEquals("[a, interpose, b, interpose, c]", new U<String>(asList("a", "b", "c"))
391+
.interpose("interpose").toString());
387392
assertEquals("[a]", new U<String>(asList("a")).interpose("interpose").toString());
388393
assertEquals("[a, b]", new U<String>(asList("a, b")).interpose(null).toString());
389394
assertEquals("[a]", U.chain(asList("a")).interpose("interpose").toString());
390395
assertEquals("[]", U.chain(U.newArrayList()).interpose("interpose").toString());
391396
assertEquals("[a, b, c]", U.chain(asList("a", "b", "c")).interpose(null).toString());
392-
assertEquals("[?, interpose, !, interpose, -]", U.chain(asList("?", "!", "-")).interpose("interpose").toString());
397+
assertEquals("[?, interpose, !, interpose, -]", U.chain(asList("?", "!", "-"))
398+
.interpose("interpose").toString());
393399
}
394400

395401
/*
@@ -417,12 +423,14 @@ public void interposeByList() {
417423
assertEquals("[a, b, c]", new U<String>(asList("a", "b", "c")).interposeByList(null).toString());
418424
assertEquals("[a]", new U<String>(asList("a")).interposeByList(asList("zzz")).toString());
419425
assertEquals("[a, b, c]", new U<String>(asList("a", "b", "c")).interposeByList(list1).toString());
420-
assertEquals("[a, aaa, b, bbb, c]", new U<String>(asList("a", "b", "c")).interposeByList(asList("aaa", "bbb", "ccc")).toString());
426+
assertEquals("[a, aaa, b, bbb, c]", new U<String>(asList("a", "b", "c"))
427+
.interposeByList(asList("aaa", "bbb", "ccc")).toString());
421428
assertEquals("[a]", U.chain(asList("a")).interposeByList(asList("aaa", "bbb", "ccc")).toString());
422429
assertEquals("[aaa, bbb, ccc]", U.chain(asList("aaa", "bbb", "ccc")).interposeByList(null).toString());
423430
list2.clear();
424431
assertEquals("[]", U.chain(list2).interposeByList(U.range(6)).toString());
425-
assertEquals("[?, aaa, !, bbb, -]", U.chain(asList("?", "!", "-")).interposeByList(asList("aaa", "bbb", "ccc")).toString());
432+
assertEquals("[?, aaa, !, bbb, -]", U.chain(asList("?", "!", "-"))
433+
.interposeByList(asList("aaa", "bbb", "ccc")).toString());
426434
}
427435

428436
/*

src/test/java/com/github/underscore/UnderscoreTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,8 @@ public void splitAt() {
211211
assertEquals("[[0, 1], [2, 3, 4]]", new U<Integer>(U.range(5)).splitAt(2).toString());
212212
assertEquals("[[0, 1], [2, 3, 4]]", U.chain(U.range(5)).splitAt(2).value().toString());
213213
assertEquals("[[a, b], [c, d, e]]", U.splitAt(asList('a', 'b', 'c', 'd', 'e'), 2).toString());
214-
assertEquals("[[ant, bird], [camel, dog, elephant]]", U.splitAt(asList("ant", "bird", "camel", "dog", "elephant"), 2).toString());
214+
assertEquals("[[ant, bird], [camel, dog, elephant]]", U.splitAt(
215+
asList("ant", "bird", "camel", "dog", "elephant"), 2).toString());
215216
assertEquals("[[0.1, 0.2], [0.3, 0.4, 0.5]]", U.splitAt(asList(0.1, 0.2, 0.3, 0.4, 0.5), 2).toString());
216217
final Integer[] array = {0, 1, 2, 3, 4};
217218
assertEquals("[[0, 1], [2, 3, 4]]", U.splitAt(array, 2).toString());
@@ -234,7 +235,8 @@ public void takeSkipping() {
234235
assertEquals("[0, 2, 4]", new U<Integer>(U.range(5)).takeSkipping(2).toString());
235236
assertEquals("[0, 2, 4]", U.chain(U.range(5)).takeSkipping(2).value().toString());
236237
assertEquals("[a, c, e]", U.takeSkipping(asList('a', 'b', 'c', 'd', 'e'), 2).toString());
237-
assertEquals("[ant, camel, elephant]", U.takeSkipping(asList("ant", "bird", "camel", "dog", "elephant"), 2).toString());
238+
assertEquals("[ant, camel, elephant]", U.takeSkipping(
239+
asList("ant", "bird", "camel", "dog", "elephant"), 2).toString());
238240
assertEquals("[0.1, 0.3, 0.5]", U.takeSkipping(asList(0.1, 0.2, 0.3, 0.4, 0.5), 2).toString());
239241
final Integer[] array = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9};
240242
assertEquals("[0, 3, 6, 9]", U.takeSkipping(array, 3).toString());

src/test/java/com/github/underscore/lodash/LodashTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -755,6 +755,11 @@ public void accept(String str) {
755755
U.chain(new Integer[] {0}).distinct();
756756
U.chain(new Integer[] {0}).distinctBy(new Function<Integer, Integer>() {
757757
public Integer apply(Integer value) { return value; } });
758+
}
759+
760+
@SuppressWarnings("unchecked")
761+
@Test
762+
public void chain2() {
758763
U.chain(new String[] {""}).union();
759764
U.chain(new String[] {""}).intersection();
760765
U.chain(new String[] {""}).difference();

0 commit comments

Comments
 (0)