Add support for the concat()

Author: javadev

pom.xml

@@ -137,7 +137,7 @@
       <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-site-plugin</artifactId>
-          <version>3.0</version>
+          <version>3.3</version>
           <configuration>
             <reportPlugins>
       <plugin>
@@ -148,17 +148,17 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-report-plugin</artifactId>
-        <version>2.3</version>
+        <version>2.18</version>
       </plugin>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-jxr-plugin</artifactId>
-        <version>2.1</version>
+        <version>2.5</version>
       </plugin>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
-        <version>2.8</version>
+        <version>2.13</version>
         <configuration>
           <configLocation>${basedir}/checkstyle.xml</configLocation>
           <includeTestSourceDirectory>true</includeTestSourceDirectory>
@@ -185,10 +185,15 @@
                 </rulesets>
             </configuration>
       </plugin>
+      <plugin>
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>findbugs-maven-plugin</artifactId>
+        <version>3.0.0</version>
+      </plugin>
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>taglist-maven-plugin</artifactId>
-        <version>2.0</version>
+        <version>2.4</version>
       </plugin>
             </reportPlugins>
           </configuration>

src/main/java/com/github/underscore/Template.java

@@ -1,9 +1,7 @@
 package com.github.underscore;
 
 public abstract class Template<T> implements Function1<T, String> {
-    private final String template;
-    public Template(final String template) {
-        this.template = template;
+    public Template() {
     }
 
 }

src/main/java/com/github/underscore/_.java

@@ -913,6 +913,10 @@ public <F extends Comparable<? super F>> Chain<T> sortBy(final Function1<T, F> f
             return new Chain<T>(_.sortBy(list, func));
         }
 
+        public <T> Chain<T> concat(final List<T> second) {
+            return new Chain<T>((List<T>) Arrays.asList(_.concat(list.toArray(), second.toArray())));
+        }
+
         public String value() {
             return item == null ? list.toString() : item.toString();
         }
@@ -943,7 +947,7 @@ public static <E> Object result(final Iterable<E> iterable, final Predicate<E> p
     }
 
     public static <E> Template<Set<E>> template(final String template) {
-        return new Template<Set<E>>(template) {
+        return new Template<Set<E>>() {
             @Override
             public String apply(Set<E> value) {
                 String result = template;
@@ -1026,6 +1030,44 @@ public static <T> String join(final T[] array, final String separator) {
         return join(Arrays.asList(array), separator);
     }
 
+    public static <T> T[] concat(final T[] first, final T[] second) {
+        final T[] result = Arrays.copyOf(first, first.length + second.length);
+        System.arraycopy(second, 0, result, first.length, second.length);
+        return result;
+    }
+
+    public static <T> List<T> concat(final List<T> first, final List<T> second) {
+        return (List<T>) Arrays.asList(_.concat(first.toArray(), second.toArray()));
+    }
+
+    public static <T> T[] concat(final T[] first, final T[] ... other) {
+        int length = 0;
+        for (T[] otherItem : other) {
+            length += otherItem.length;
+        }
+        final T[] result = Arrays.copyOf(first, first.length + length);
+        int index = 0;
+        for (T[] otherItem : other) {
+            System.arraycopy(otherItem, 0, result, first.length + index, otherItem.length);
+            index += otherItem.length;
+        }
+        return result;
+    }
+
+    public static <T> List<T> concat(final List<T> first, final List<T> ... other) {
+        int length = 0;
+        for (List<T> otherItem : other) {
+            length += otherItem.size();
+        }
+        final T[] result = (T[]) Arrays.copyOf(first.toArray(), first.size() + length);
+        int index = 0;
+        for (List<T> otherItem : other) {
+            System.arraycopy(otherItem.toArray(), 0, result, first.size() + index, otherItem.size());
+            index += otherItem.size();
+        }
+        return (List<T>) Arrays.asList(result);
+    }
+
     public static void main(String[] args) {
         final String message = "Underscore-java is a java port of Underscore.js.\n\n"
             + "In addition to porting Underscore's functionality, Underscore-java includes matching unit tests.\n\n"

src/test/java/com/github/underscore/_Test.java

@@ -1365,7 +1365,7 @@ public Boolean apply(String item) {
 
     @Test
     public void debounce() throws Exception {
-	final Integer[] counter = new Integer[] {0};
+    final Integer[] counter = new Integer[] {0};
         Function<Void> incr = new Function<Void>() { public Void apply() { counter[0]++; return null; }};
         Function<Void> debouncedIncr = _.debounce(incr, 50);
         debouncedIncr.apply();
@@ -1391,7 +1391,7 @@ public void main() throws Exception {
 */
     @Test
     public void sort() throws Exception {
-        assertEquals("[example, some, words]", _.sort(Arrays.asList("some", "words", "example")).toString());
+        assertEquals("[example, some, words]", _.sort(asList("some", "words", "example")).toString());
         assertEquals("[example, some, words]", asList(_.sort(new String[] {"some", "words", "example"})).toString());
     }
 
@@ -1401,12 +1401,25 @@ public void sort() throws Exception {
 */
     @Test
     public void join() throws Exception {
-        assertEquals("some-words-example", _.join(Arrays.asList("some", "words", "example"), "-"));
+        assertEquals("some-words-example", _.join(asList("some", "words", "example"), "-"));
         assertEquals("some-words-example", _.join(new String[] {"some", "words", "example"}, "-"));
     }
 
     @Test
     public void compareStrings() throws Exception {
         assertEquals(_.sort("CAT".split("")), _.sort("CTA".split("")));
     }
+
+/*
+_.concat([1, 2], [3, 4]);
+=> [1, 2, 3, 4]
+*/
+    @Test
+    public void concat() throws Exception {
+        assertEquals(asList(1, 2, 3, 4), asList(_.concat(new Integer[] {1, 2}, new Integer[] {3, 4})));
+        assertEquals(asList(1, 2, 3, 4), _.concat(asList(1, 2), asList(3, 4)));
+        assertEquals("[1, 2, 3, 4]", _.chain(asList(1, 2)).concat(asList(3, 4)).value());
+        assertEquals(asList(1, 2, 3, 4), asList(_.concat(new Integer[] {1, 2}, new Integer[] {3}, new Integer[] {4})));
+        assertEquals(asList(1, 2, 3, 4), _.concat(asList(1, 2), asList(3), asList(4)));
+    }
 }