Skip to content

Commit ebfb393

Browse files
itsdevdomitsdevdom
committed
chore(gulp): Fixed coveralls, fixed wrong dependencies
1 parent 923488a commit ebfb393

File tree

5 files changed

+23
-25
lines changed

5 files changed

+23
-25
lines changed

‎.travis.yml‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,7 @@ before_script:
2929
- export DISPLAY=:99.0
3030
- sh -e /etc/init.d/xvfb start # Run xvfb to fake a display (muhaha ...)
3131
script:
32-
- npm run gulp test && npm run gulp build--publish # First test, then build for npm publish
33-
after_success:
34-
- npm run coveralls
32+
- npm run gulp test && npm run coveralls && npm run gulp build--publish # First test, then build for npm publish
3533

3634
before_deploy: # Automatic semantic release
3735
- git config --global user.name "dominique-mueller"; # Setup git

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
[![dev dependency status](https://img.shields.io/david/dev/dominique-mueller/angular-notifier.svg?maxAge=2592000&style=flat-square)](https://david-dm.org/dominique-mueller/angular-notifier?type=dev)
44
[![peer dependency status](https://img.shields.io/david/peer/dominique-mueller/angular-notifier.svg?maxAge=2592000&style=flat-square)](https://david-dm.org/dominique-mueller/angular-notifier?type=peer)
55
[![travis ci build status](https://img.shields.io/travis/dominique-mueller/angular-notifier/master.svg?maxAge=2592000&style=flat-square)](https://travis-ci.org/dominique-mueller/angular-notifier)
6-
[![Codecov](https://img.shields.io/codecov/c/github/dominique-mueller/angular-notifier/master.svg?maxAge=2592000&style=flat-square)]()
6+
[![Coveralls](https://img.shields.io/coveralls/dominique-mueller/angular-notifier/master.svg?style=flat-square)](https://coveralls.io/github/dominique-mueller/angular-notifier)
77
[![license](https://img.shields.io/npm/l/angular-notifier.svg?maxAge=2592000&style=flat-square)](https://github.com/dominique-mueller/angular-notifier/LICENSE)
88

99
# angular-notifier

‎package.json‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"peerDependencies": {
4242
"@angular/core": "2.x",
4343
"@angular/common": "2.x",
44-
"rxjs": "5.0.0-rc.4"
44+
"rxjs": "5.0.1"
4545
},
4646
"devDependencies": {
4747
"@angular/core": "2.x",
@@ -52,7 +52,7 @@
5252
"@angular/platform-browser-dynamic": "2.x",
5353
"@types/jasmine": "2.5.x",
5454
"browser-sync": "2.18.x",
55-
"codelyzer": "2.0.0-beta.3",
55+
"codelyzer": "2.0.0-beta.4",
5656
"conventional-github-releaser": "1.1.x",
5757
"conventional-recommended-bump": "0.3.x",
5858
"core-js": "2.4.x",
@@ -61,14 +61,14 @@
6161
"gulp": "github:gulpjs/gulp#4.0",
6262
"gulp-autoprefixer": "3.1.x",
6363
"gulp-bump": "2.5.x",
64-
"gulp-clean-css": "2.0.x",
64+
"gulp-clean-css": "2.3.x",
6565
"gulp-conventional-changelog": "1.1.x",
6666
"gulp-git": "1.12.x",
6767
"gulp-inline-ng2-template": "4.0.x",
6868
"gulp-insert": "0.5.x",
6969
"gulp-rename": "1.2.x",
7070
"gulp-sourcemaps": "2.2.x",
71-
"gulp-sass": "2.3.x",
71+
"gulp-sass": "3.0.x",
7272
"gulp-sass-lint": "1.3.x",
7373
"gulp-tslint": "7.0.x",
7474
"gulp-typescript": "3.1.x",
@@ -79,14 +79,14 @@
7979
"karma-chrome-launcher": "2.0.x",
8080
"karma-cli": "1.0.x",
8181
"karma-coverage": "1.1.x",
82-
"karma-jasmine": "1.0.x",
82+
"karma-jasmine": "1.1.x",
8383
"karma-mocha-reporter": "2.2.x",
8484
"merge2": "1.0.x",
8585
"progress-bar-webpack-plugin": "1.9.x",
8686
"reflect-metadata": "0.1.x",
8787
"remap-istanbul": "0.8.x",
8888
"require-dir": "0.3.x",
89-
"rxjs": "5.0.0-rc.4",
89+
"rxjs": "5.0.1",
9090
"source-map-loader": "0.1.x",
9191
"systemjs": "0.19.x",
9292
"tslint": "4.0.x",

‎src/components/notifier-notification.component.spec.ts‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ export function main(): void {
353353
tick();
354354

355355
expect( componentFixture.debugElement.styles[ 'transform' ] )
356-
.toBe( `translate3d( 0, ${ 0 + shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )` );
356+
.toBe( `translate3d( 0, ${ shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )` );
357357
expect( shiftCallback ).toHaveBeenCalled();
358358

359359
} ) );
@@ -389,7 +389,7 @@ export function main(): void {
389389
return {
390390
finished: new Promise<undefined>( ( resolve: () => void, reject: () => void ) => {
391391
componentFixture.debugElement.styles[ 'transform' ] =
392-
`translate3d( 0, ${ 0 + shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )`; // Fake animation result
392+
`translate3d( 0, ${ shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )`; // Fake animation result
393393
resolve();
394394
} )
395395
};
@@ -400,7 +400,7 @@ export function main(): void {
400400
tick();
401401

402402
expect( componentFixture.debugElement.styles[ 'transform' ] )
403-
.toBe( `translate3d( 0, ${ 0 + shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )` );
403+
.toBe( `translate3d( 0, ${ shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )` );
404404
expect( shiftCallback ).toHaveBeenCalled();
405405

406406
} ) );
@@ -438,7 +438,7 @@ export function main(): void {
438438
tick();
439439

440440
expect( componentFixture.debugElement.styles[ 'transform' ] )
441-
.toBe( `translate3d( 0, ${ 0 - shiftDistance - testNotifierConfig.position.vertical.gap }px, 0 )` );
441+
.toBe( `translate3d( 0, ${ -shiftDistance - testNotifierConfig.position.vertical.gap }px, 0 )` );
442442
expect( shiftCallback ).toHaveBeenCalled();
443443

444444
} ) );
@@ -473,7 +473,7 @@ export function main(): void {
473473
return {
474474
finished: new Promise<undefined>( ( resolve: () => void, reject: () => void ) => {
475475
componentFixture.debugElement.styles[ 'transform' ] =
476-
`translate3d( 0, ${ 0 - shiftDistance - testNotifierConfig.position.vertical.gap }px, 0 )`; // Fake animation result
476+
`translate3d( 0, ${ -shiftDistance - testNotifierConfig.position.vertical.gap }px, 0 )`; // Fake animation result
477477
resolve();
478478
} )
479479
};
@@ -484,7 +484,7 @@ export function main(): void {
484484
tick();
485485

486486
expect( componentFixture.debugElement.styles[ 'transform' ] )
487-
.toBe( `translate3d( 0, ${ 0 - shiftDistance - testNotifierConfig.position.vertical.gap }px, 0 )` );
487+
.toBe( `translate3d( 0, ${ -shiftDistance - testNotifierConfig.position.vertical.gap }px, 0 )` );
488488
expect( shiftCallback ).toHaveBeenCalled();
489489

490490
} ) );
@@ -522,7 +522,7 @@ export function main(): void {
522522
tick();
523523

524524
expect( componentFixture.debugElement.styles[ 'transform' ] )
525-
.toBe( `translate3d( 0, ${ 0 - shiftDistance - testNotifierConfig.position.vertical.gap }px, 0 )` );
525+
.toBe( `translate3d( 0, ${ -shiftDistance - testNotifierConfig.position.vertical.gap }px, 0 )` );
526526
expect( shiftCallback ).toHaveBeenCalled();
527527

528528
} ) );
@@ -557,7 +557,7 @@ export function main(): void {
557557
return {
558558
finished: new Promise<undefined>( ( resolve: () => void, reject: () => void ) => {
559559
componentFixture.debugElement.styles[ 'transform' ] =
560-
`translate3d( 0, ${ 0 - shiftDistance - testNotifierConfig.position.vertical.gap }px, 0 )`; // Fake animation result
560+
`translate3d( 0, ${ -shiftDistance - testNotifierConfig.position.vertical.gap }px, 0 )`; // Fake animation result
561561
resolve();
562562
} )
563563
};
@@ -606,7 +606,7 @@ export function main(): void {
606606
tick();
607607

608608
expect( componentFixture.debugElement.styles[ 'transform' ] )
609-
.toBe( `translate3d( 0, ${ 0 + shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )` );
609+
.toBe( `translate3d( 0, ${ shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )` );
610610
expect( shiftCallback ).toHaveBeenCalled();
611611

612612
} ) );
@@ -641,7 +641,7 @@ export function main(): void {
641641
return {
642642
finished: new Promise<undefined>( ( resolve: () => void, reject: () => void ) => {
643643
componentFixture.debugElement.styles[ 'transform' ] =
644-
`translate3d( 0, ${ 0 + shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )`; // Fake animation result
644+
`translate3d( 0, ${ shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )`; // Fake animation result
645645
resolve();
646646
} )
647647
};
@@ -652,7 +652,7 @@ export function main(): void {
652652
tick();
653653

654654
expect( componentFixture.debugElement.styles[ 'transform' ] )
655-
.toBe( `translate3d( 0, ${ 0 + shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )` );
655+
.toBe( `translate3d( 0, ${ shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )` );
656656
expect( shiftCallback ).toHaveBeenCalled();
657657

658658
} ) );
@@ -690,7 +690,7 @@ export function main(): void {
690690
tick();
691691

692692
expect( componentFixture.debugElement.styles[ 'transform' ] )
693-
.toBe( `translate3d( -50%, ${ 0 + shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )` );
693+
.toBe( `translate3d( -50%, ${ shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )` );
694694
expect( shiftCallback ).toHaveBeenCalled();
695695

696696
} ) );
@@ -728,7 +728,7 @@ export function main(): void {
728728
return {
729729
finished: new Promise<undefined>( ( resolve: () => void, reject: () => void ) => {
730730
componentFixture.debugElement.styles[ 'transform' ] =
731-
`translate3d( -50%, ${ 0 + shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )`; // Fake animation result
731+
`translate3d( -50%, ${ shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )`; // Fake animation result
732732
resolve();
733733
} )
734734
};
@@ -739,7 +739,7 @@ export function main(): void {
739739
tick();
740740

741741
expect( componentFixture.debugElement.styles[ 'transform' ] )
742-
.toBe( `translate3d( -50%, ${ 0 + shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )` );
742+
.toBe( `translate3d( -50%, ${ shiftDistance + testNotifierConfig.position.vertical.gap }px, 0 )` );
743743
expect( shiftCallback ).toHaveBeenCalled();
744744

745745
} ) );

‎tools/gulp/ts/ts-test.task.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
const gulp = require( 'gulp' );
44
const karma = require( 'karma' );
55
const path = require( 'path' );
6-
const remapIstanbul = require( 'remap-istanbul/lib/gulpRemapIstanbul' ).default;
6+
const remapIstanbul = require( 'remap-istanbul/lib/gulpRemapIstanbul' );
77

88
/**
99
* Gulp task: Run TypeScript unit tests

0 commit comments

Comments
 (0)