Fix logging setup to follow Python best practices (issue #27)

Remove logging.basicConfig() calls from library modules (ipdata.py,
geofeeds.py) that were hijacking the root logger at import time. Use
__name__-based loggers with NullHandler per Python docs. Preserve
debug=True backward compat by lazily attaching RichHandler to the
library logger only when needed.

https://claude.ai/code/session_01M3wRX9tnmc4qorVWRjmqTZ

Author: claude

src/ipdata/cli.py

@@ -76,7 +76,7 @@
 logging.basicConfig(
     level="ERROR", format=FORMAT, datefmt="[%X]", handlers=[RichHandler()]
 )
-log = logging.getLogger("rich")
+log = logging.getLogger(__name__)
 
 API_KEY_FILE = f"{Path.home()}/.ipdata"
 

src/ipdata/geofeeds.py

@@ -9,15 +9,11 @@
 from pathlib import Path
 
 import requests
-from rich.logging import RichHandler
 
 from .codes import COUNTRIES, REGION_CODES
 
-FORMAT = "%(message)s"
-logging.basicConfig(
-    level="ERROR", format=FORMAT, datefmt="[%X]", handlers=[RichHandler()]
-)
-log = logging.getLogger("rich")
+log = logging.getLogger(__name__)
+log.addHandler(logging.NullHandler())
 
 pwd = Path(__file__).parent.resolve()
 

src/ipdata/ipdata.py

@@ -26,12 +26,9 @@
 import functools
 
 from requests.adapters import HTTPAdapter, Retry
-from rich.logging import RichHandler
 
-FORMAT = "%(message)s"
-logging.basicConfig(
-    level="ERROR", format=FORMAT, datefmt="[%X]", handlers=[RichHandler()]
-)
+logger = logging.getLogger(__name__)
+logger.addHandler(logging.NullHandler())
 
 
 class IPDataException(Exception):
@@ -68,7 +65,7 @@ class IPData(object):
     :param debug: A boolean used to set the log level. Set to True when debugging.
     """
 
-    log = logging.getLogger("rich")
+    log = logging.getLogger(__name__)
 
     valid_fields = {
         "ip",
@@ -121,6 +118,13 @@ def __init__(
         # Enable debugging
         if debug:
             self.log.setLevel(logging.DEBUG)
+            if not any(
+                not isinstance(h, logging.NullHandler) for h in self.log.handlers
+            ):
+                from rich.logging import RichHandler
+                handler = RichHandler()
+                handler.setFormatter(logging.Formatter("%(message)s", datefmt="[%X]"))
+                self.log.addHandler(handler)
 
         # Work around renamed argument in urllib3.
         if hasattr(urllib3.util.Retry.DEFAULT, "allowed_methods"):