Support analyzer 8 (#356)

Author: rrousselGit

analysis_options.yaml

@@ -11,6 +11,8 @@ analyzer:
     included_file_warning: ignore
     # false positive when using Freezed
     invalid_annotation_target: ignore
+    ## Too painful to upgrade analyzer, and an official Google package is coming
+    deprecated_member_use: ignore
 
 linter:
   rules:

packages/custom_lint/example/example_lint/analysis_options.yaml

@@ -1,6 +1,6 @@
-# include: ../analysis_options.yaml
+include: ../analysis_options.yaml
 
-# linter:
-#   rules:
-#     public_member_api_docs: false
-#     avoid_print: false
+linter:
+  rules:
+    public_member_api_docs: false
+    avoid_print: false

packages/custom_lint/example/example_lint/lib/custom_lint_example_lint.dart

@@ -23,7 +23,7 @@ PluginBase createPlugin() => _RiverpodLint();
 class _RiverpodLint extends PluginBase {
   @override
   List<LintRule> getLintRules(CustomLintConfigs configs) => [
-        PreferFinalProviders(),
+        const PreferFinalProviders(),
       ];
 
   @override
@@ -36,7 +36,7 @@ class _RiverpodLint extends PluginBase {
 ///
 /// For emitting lints on non-Dart files, subclass [LintRule].
 class PreferFinalProviders extends DartLintRule {
-  PreferFinalProviders() : super(code: _code);
+  const PreferFinalProviders() : super(code: _code);
 
   /// Metadata about the lint define. This is the code which will show-up in the IDE,
   /// and its description..
@@ -47,7 +47,7 @@ class PreferFinalProviders extends DartLintRule {
 
   /// The core logic for our custom lint rule.
   /// In our case, it will search over all variables defined in a Dart file and
-  /// search for the ones that implement a specific type (see [__providerBaseChecker]).
+  /// search for the ones that implement a specific type (see [_providerBaseChecker]).
   @override
   void run(
     // This object contains metadata about the analyzed file

packages/custom_lint/example/example_lint/pubspec.yaml

@@ -5,7 +5,7 @@ environment:
   sdk: '>=3.0.0 <4.0.0'
 
 dependencies:
-  analyzer: ^7.5.0
+  analyzer: ^8.0.0
   analyzer_plugin: ^0.13.0
   custom_lint_builder:
     path: ../../../custom_lint_builder

packages/custom_lint/pubspec.yaml

@@ -8,7 +8,7 @@ environment:
   sdk: ">=3.0.0 <4.0.0"
 
 dependencies:
-  analyzer: ^7.5.0
+  analyzer: ^8.0.0
   analyzer_plugin: ^0.13.0
   args: ^2.3.1
   async: ^2.9.0
@@ -32,7 +32,7 @@ dev_dependencies:
   benchmark_harness: ^2.2.0
   build_runner: ^2.5.0
   file: ^7.0.0
-  freezed: ^3.0.0
+  freezed: ^3.2.1
   glob: ^2.1.2
   json_serializable: ^6.5.4
   test: ^1.20.2

packages/custom_lint/test/goldens.dart

@@ -86,7 +86,8 @@ String _encodePrioritizedSourceChanges(
         final output = SourceEdit.applySequence(
           source,
           prioritizedSourceChange.change.edits
-              .expand((element) => element.edits),
+              .expand((element) => element.edits)
+              .toList(),
         );
 
         final outputLineInfo = LineInfo.fromContent(output);

packages/custom_lint_builder/example/example_lint/analysis_options.yaml

@@ -1,6 +1,6 @@
-# include: ../analysis_options.yaml
+include: ../analysis_options.yaml
 
-# linter:
-#   rules:
-#     public_member_api_docs: false
-#     avoid_print: false
+linter:
+  rules:
+    public_member_api_docs: false
+    avoid_print: false

packages/custom_lint_builder/example/example_lint/lib/custom_lint_builder_example_lint.dart

@@ -23,7 +23,7 @@ PluginBase createPlugin() => _RiverpodLint();
 class _RiverpodLint extends PluginBase {
   @override
   List<LintRule> getLintRules(CustomLintConfigs configs) => [
-        PreferFinalProviders(),
+        const PreferFinalProviders(),
       ];
 
   @override
@@ -36,7 +36,7 @@ class _RiverpodLint extends PluginBase {
 ///
 /// For emitting lints on non-Dart files, subclass [LintRule].
 class PreferFinalProviders extends DartLintRule {
-  PreferFinalProviders() : super(code: _code);
+  const PreferFinalProviders() : super(code: _code);
 
   /// Metadata about the lint define. This is the code which will show-up in the IDE,
   /// and its description..

packages/custom_lint_builder/example/example_lint/pubspec.yaml

@@ -5,7 +5,7 @@ environment:
   sdk: '>=3.0.0 <4.0.0'
 
 dependencies:
-  analyzer: ^7.5.0
+  analyzer: ^8.0.0
   analyzer_plugin: ^0.13.0
   custom_lint_builder:
     path: ../../../custom_lint_builder

packages/custom_lint_builder/lib/src/client.dart

@@ -1033,7 +1033,8 @@ class _ClientAnalyzerPlugin extends analyzer_plugin.ServerPlugin {
         allFixes
             .expand((e) => e.fixes)
             .expand((e) => e.change.edits)
-            .expand((e) => e.edits),
+            .expand((e) => e.edits)
+            .toList(),
       );
 
       io.File(path).writeAsStringSync(editedSource);