Skip to content

Commit cfc1957

Browse files
committed
Check via pre-commit
1 parent df5f2a5 commit cfc1957

File tree

4 files changed

+29
-141
lines changed

4 files changed

+29
-141
lines changed

.github/workflows/hygiene.yaml

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111
jobs:
1212
hygiene:
1313
runs-on: ubuntu-latest
14-
name: Ruff
14+
name: Hygiene check
1515
steps:
1616
- uses: actions/checkout@v3
1717
- name: setup-python
@@ -21,10 +21,15 @@ jobs:
2121
architecture: "x64"
2222
- name: Install uv
2323
uses: astral-sh/setup-uv@v6
24-
- name: Ruff format
25-
run: uv run ruff format --check
26-
- name: Ruff check
27-
run: uv run ruff check
28-
- name: Basedpyright check
29-
run: uv run basedpyright
30-
24+
- name: Install project
25+
run: uv sync
26+
- name: Install pre-commit
27+
run: pip install pre-commit
28+
- name: Pre-commit checks on all files
29+
run: pre-commit run --all-files
30+
- name: Check for changes
31+
run: |
32+
if ! git diff --exit-code; then
33+
echo "Changed detected after enforcing code hygiene. Please run pre-commit on your changes. Check CONTRIBUTING.md for details."
34+
exit 1
35+
fi

pyproject.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,6 @@ dependencies = [
4444
dev = [
4545
"pytest",
4646
"pytest-cov",
47-
"black",
48-
"ruff>=0.12.8",
49-
"basedpyright>=1.31.1",
5047
]
5148

5249
[project.urls]

src/implicitdict/jsonschema.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,22 @@ def _schema_for(
206206
raise NotImplementedError(f"Automatic JSON schema generation for {value_type} type is not yet implemented")
207207

208208

209+
210+
211+
212+
213+
214+
215+
216+
217+
218+
219+
220+
221+
222+
223+
224+
209225
def _field_docs_for(t: type[ImplicitDict]) -> dict[str, str]:
210226
# Curse Guido for rejecting PEP224! Fine, we'll do it ourselves.
211227
result = {}

0 commit comments

Comments
 (0)