Enable abort on spill for linear Scan RA

Enable abort on spill for linear Scan RA
Adape the same abort on spill mechanism to linear Scan RA, for the case in which the regsiter pressure is too high and spill cannot make RA success, abort on spill

Author: bcheng0127

IGC/Compiler/CISACodeGen/CISABuilder.cpp

@@ -4050,6 +4050,15 @@ namespace IGC
             {
                 SaveOption(vISA_ScheduleEndBBID, Val);
             }
+            if (uint32_t Val = IGC_GET_FLAG_VALUE(VISAPostScheduleStartBBID))
+            {
+                SaveOption(vISA_LocalSchedulingStartBB, Val);
+            }
+
+            if (uint32_t Val = IGC_GET_FLAG_VALUE(VISAPostScheduleEndBBID))
+            {
+                SaveOption(vISA_LocalSchedulingEndBB, Val);
+            }
         }
         else
         {

IGC/common/igc_flags.h

@@ -22,6 +22,8 @@ DECLARE_IGC_REGKEY(bool, ForceVISAPreSched,             false, "Force enabling o
 DECLARE_IGC_REGKEY(DWORD, VISAPreSchedRPThreshold,      0,     "Configure how aggressive pre-RA Scheduler is, 0 for the default", false)
 DECLARE_IGC_REGKEY(DWORD, VISAScheduleStartBBID, 0,  "The ID of BB which will be first scheduled", false)
 DECLARE_IGC_REGKEY(DWORD, VISAScheduleEndBBID, 0,  "The ID of BB which will be last scheduled", false)
+DECLARE_IGC_REGKEY(DWORD, VISAPostScheduleStartBBID, 0,  "The ID of BB which will be first scheduled", false)
+DECLARE_IGC_REGKEY(DWORD, VISAPostScheduleEndBBID, 0,  "The ID of BB which will be last scheduled", false)
 DECLARE_IGC_REGKEY(DWORD, SIMD8_SpillThreshold,         2,     "Percentage of instructions allowed for spilling", false)
 DECLARE_IGC_REGKEY(DWORD, SIMD16_SpillThreshold,        1,     "Percentage of instructions allowed for spilling", false)
 DECLARE_IGC_REGKEY(bool, DisableCSEL,                   false, "disable csel peep-hole", false)

visa/LinearScanRA.cpp

@@ -979,7 +979,43 @@ int LinearScanRA::linearScanRA()
         globalLinearScan ra(gra, &l, globalLiveIntervals, &preAssignedLiveIntervals, inputIntervals, pregManager,
             mem, numRegLRA, numRowsEOT, latestLexID,
             doBCR, highInternalConflict);
-        if (!ra.runLinearScan(builder, globalLiveIntervals, spillLRs))
+
+        bool success = ra.runLinearScan(builder, globalLiveIntervals, spillLRs);
+
+        auto underSpillThreshold = [this](int numSpill, int asmCount)
+        {
+            int threshold = std::min(builder.getOptions()->getuInt32Option(vISA_AbortOnSpillThreshold), 200u);
+            return (numSpill * 200) < (threshold * asmCount);
+        };
+
+        for (auto lr : spillLRs)
+        {
+            GRFSpillFillCount += lr->getNumRefs();
+        }
+
+        int instNum = 0;
+        for (auto bb : kernel.fg)
+        {
+            instNum += (int)bb->size();
+        }
+        if (GRFSpillFillCount && builder.getOption(vISA_AbortOnSpill) && !underSpillThreshold(GRFSpillFillCount, instNum))
+        {
+            // update jit metadata information
+            if (auto jitInfo = builder.getJitInfo())
+            {
+                jitInfo->isSpill = true;
+                jitInfo->spillMemUsed = 0;
+                jitInfo->numAsmCount = instNum;
+                jitInfo->numGRFSpillFill = GRFSpillFillCount;
+            }
+
+            // Early exit when -abortonspill is passed, instead of
+            // spending time inserting spill code and then aborting.
+            return VISA_SPILL;
+        }
+
+        //Try other graphcoloring
+        if (!success)
         {
             undoLinearScanRAAssignments();
             return VISA_FAILURE;
@@ -1019,10 +1055,6 @@ int LinearScanRA::linearScanRA()
             COUT_ERROR << "===== printSpillLiveIntervals============" << std::endl;
             printSpillLiveIntervals(spillLRs);
 #endif
-            for (auto lr : spillLRs)
-            {
-                GRFSpillFillCount += lr->getNumRefs();
-            }
 
             // update jit metadata information for spill
             if (auto jitInfo = builder.getJitInfo())
@@ -1066,33 +1098,6 @@ int LinearScanRA::linearScanRA()
             std::cout << "\t\tGRFSpillFillCount: " << GRFSpillFillCount << "\n";
         }
 
-        auto underSpillThreshold = [this](int numSpill, int asmCount)
-        {
-            int threshold = std::min(builder.getOptions()->getuInt32Option(vISA_AbortOnSpillThreshold), 200u);
-            return (numSpill * 200) < (threshold * asmCount);
-        };
-
-        int instNum = 0;
-        for (auto bb : kernel.fg)
-        {
-            instNum += (int)bb->size();
-        }
-        if (GRFSpillFillCount && builder.getOption(vISA_AbortOnSpill) && !underSpillThreshold(GRFSpillFillCount, instNum))
-        {
-            // update jit metadata information
-            if (auto jitInfo = builder.getJitInfo())
-            {
-                jitInfo->isSpill = true;
-                jitInfo->spillMemUsed = 0;
-                jitInfo->numAsmCount = instNum;
-                jitInfo->numGRFSpillFill = GRFSpillFillCount;
-            }
-
-            // Early exit when -abortonspill is passed, instead of
-            // spending time inserting spill code and then aborting.
-            return VISA_SPILL;
-        }
-
         iterator++;
     } while (spillLRs.size() && iterator < MAXIMAL_ITERATIONS);
 
@@ -2279,7 +2284,7 @@ bool globalLinearScan::runLinearScan(IR_Builder& builder, std::vector<LSLiveRang
                 COUT_ERROR << "Failed to spill registers for " << lr->getTopDcl()->getName() << ", rows :" << lr->getTopDcl()->getNumRows() << std::endl;
                 printActives();
 #endif
-                spillLRs.push_back(lr);
+                return false;
             }
         }
     }