From 6f8f451c2ff2601d3bbd0b629cad078b115bc013 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Thu, 18 Dec 2025 10:29:15 -0800 Subject: [PATCH 01/17] Migrate to dependabot and use version tags --- .github/dependabot.yml | 15 +++++++++++++++ .github/renovate.json | 6 ------ .github/workflows/build-cpp-runtime-bindings.yml | 4 ++-- .github/workflows/pre-commit.yml | 4 ++-- .github/workflows/skywalking-eyes.yml | 2 +- 5 files changed, 20 insertions(+), 11 deletions(-) create mode 100644 .github/dependabot.yml delete mode 100644 .github/renovate.json diff --git a/.github/dependabot.yml b/.github/dependabot.yml new file mode 100644 index 000000000..47064f2dc --- /dev/null +++ b/.github/dependabot.yml @@ -0,0 +1,15 @@ +version: 2 +updates: + - package-ecosystem: "github-actions" + directory: "/" + schedule: + interval: "monthly" + commit-message: + prefix: "chore(actions)" + labels: + - dependencies + - actions + groups: + github-actions: + patterns: + - "*" diff --git a/.github/renovate.json b/.github/renovate.json deleted file mode 100644 index 5db72dd6a..000000000 --- a/.github/renovate.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "$schema": "https://docs.renovatebot.com/renovate-schema.json", - "extends": [ - "config:recommended" - ] -} diff --git a/.github/workflows/build-cpp-runtime-bindings.yml b/.github/workflows/build-cpp-runtime-bindings.yml index 81ba47ec0..645a9f465 100644 --- a/.github/workflows/build-cpp-runtime-bindings.yml +++ b/.github/workflows/build-cpp-runtime-bindings.yml @@ -61,7 +61,7 @@ jobs: /bin/bash -c "chmod +x docker/x86_64/build-cpp-runtime-bindings.sh && ./docker/x86_64/build-cpp-runtime-bindings.sh" - name: Upload cpp runtime bindings artifacts - uses: actions/upload-artifact@v6 + uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 with: name: svs-cpp-runtime-bindings${{ matrix.suffix }} path: svs-cpp-runtime-bindings${{ matrix.suffix }}.tar.gz @@ -98,7 +98,7 @@ jobs: # Need to download for a new job - name: Download shared libraries - uses: actions/download-artifact@v7 + uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0 with: name: svs-cpp-runtime-bindings${{ matrix.suffix }} path: runtime_lib diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index 5ee719ce8..5853a3376 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-24.04 steps: - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 - - uses: actions/setup-python@v6 + - uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0 with: python-version: '3.12' - - uses: pre-commit/action@v3.0.1 + - uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1 diff --git a/.github/workflows/skywalking-eyes.yml b/.github/workflows/skywalking-eyes.yml index d91409d6f..619c83433 100644 --- a/.github/workflows/skywalking-eyes.yml +++ b/.github/workflows/skywalking-eyes.yml @@ -34,7 +34,7 @@ jobs: runs-on: ubuntu-24.04 steps: - name: Checkout code - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 + uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 - name: Run check uses: apache/skywalking-eyes/header@61275cc80d0798a405cb070f7d3a8aaf7cf2c2c1 # v0.8.0 with: From de4a979ca1f400275ca2463ea5783f97181571a5 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Thu, 18 Dec 2025 11:15:09 -0800 Subject: [PATCH 02/17] Move CI scripts from docker/ to .github/scripts --- .../x86_64 => .github/scripts}/build-cpp-runtime-bindings.sh | 0 .../x86_64 => .github/scripts}/test-cpp-runtime-bindings.sh | 0 .github/workflows/build-cpp-runtime-bindings.yml | 4 ++-- 3 files changed, 2 insertions(+), 2 deletions(-) rename {docker/x86_64 => .github/scripts}/build-cpp-runtime-bindings.sh (100%) rename {docker/x86_64 => .github/scripts}/test-cpp-runtime-bindings.sh (100%) diff --git a/docker/x86_64/build-cpp-runtime-bindings.sh b/.github/scripts/build-cpp-runtime-bindings.sh similarity index 100% rename from docker/x86_64/build-cpp-runtime-bindings.sh rename to .github/scripts/build-cpp-runtime-bindings.sh diff --git a/docker/x86_64/test-cpp-runtime-bindings.sh b/.github/scripts/test-cpp-runtime-bindings.sh similarity index 100% rename from docker/x86_64/test-cpp-runtime-bindings.sh rename to .github/scripts/test-cpp-runtime-bindings.sh diff --git a/.github/workflows/build-cpp-runtime-bindings.yml b/.github/workflows/build-cpp-runtime-bindings.yml index 645a9f465..2ccc0363f 100644 --- a/.github/workflows/build-cpp-runtime-bindings.yml +++ b/.github/workflows/build-cpp-runtime-bindings.yml @@ -58,7 +58,7 @@ jobs: -e ENABLE_LVQ_LEANVEC=${{ matrix.enable_lvq_leanvec }} \ -e SUFFIX=${{ matrix.suffix }} \ svs-manylinux228:latest \ - /bin/bash -c "chmod +x docker/x86_64/build-cpp-runtime-bindings.sh && ./docker/x86_64/build-cpp-runtime-bindings.sh" + /bin/bash -c "chmod +x .github/scripts/build-cpp-runtime-bindings.sh && ./.github/scripts/build-cpp-runtime-bindings.sh" - name: Upload cpp runtime bindings artifacts uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 @@ -115,4 +115,4 @@ jobs: -w /workspace \ -e SUFFIX=${{ matrix.suffix }} \ svs-manylinux228:latest \ - /bin/bash -c "chmod +x docker/x86_64/test-cpp-runtime-bindings.sh && ./docker/x86_64/test-cpp-runtime-bindings.sh" + /bin/bash -c "chmod +x .github/scripts/test-cpp-runtime-bindings.sh && ./.github/scripts/test-cpp-runtime-bindings.sh" From 95fba0b6ec39b85e42386786080a637035157575 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Thu, 18 Dec 2025 11:19:57 -0800 Subject: [PATCH 03/17] Remove unnecessary chmods for .github scripts --- .github/workflows/build-cpp-runtime-bindings.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-cpp-runtime-bindings.yml b/.github/workflows/build-cpp-runtime-bindings.yml index 2ccc0363f..9613ac986 100644 --- a/.github/workflows/build-cpp-runtime-bindings.yml +++ b/.github/workflows/build-cpp-runtime-bindings.yml @@ -58,7 +58,7 @@ jobs: -e ENABLE_LVQ_LEANVEC=${{ matrix.enable_lvq_leanvec }} \ -e SUFFIX=${{ matrix.suffix }} \ svs-manylinux228:latest \ - /bin/bash -c "chmod +x .github/scripts/build-cpp-runtime-bindings.sh && ./.github/scripts/build-cpp-runtime-bindings.sh" + /bin/bash .github/scripts/build-cpp-runtime-bindings.sh - name: Upload cpp runtime bindings artifacts uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 @@ -115,4 +115,4 @@ jobs: -w /workspace \ -e SUFFIX=${{ matrix.suffix }} \ svs-manylinux228:latest \ - /bin/bash -c "chmod +x .github/scripts/test-cpp-runtime-bindings.sh && ./.github/scripts/test-cpp-runtime-bindings.sh" + /bin/bash .github/scripts/test-cpp-runtime-bindings.sh From 6d9cda422d777c2d19a9ce9acaf1b3ee3ac0ffd3 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Thu, 18 Dec 2025 15:25:58 -0800 Subject: [PATCH 04/17] Use latest release binaries in cpp bindings and example --- bindings/cpp/CMakeLists.txt | 4 ++-- examples/cpp/shared/CMakeLists.txt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bindings/cpp/CMakeLists.txt b/bindings/cpp/CMakeLists.txt index 122e5c8f7..00b5e51e1 100644 --- a/bindings/cpp/CMakeLists.txt +++ b/bindings/cpp/CMakeLists.txt @@ -98,14 +98,14 @@ if (SVS_RUNTIME_ENABLE_LVQ_LEANVEC) else() # Links to LTO-enabled static library, requires GCC/G++ 11.2 if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "11.2" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "11.3") - set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v1.0.0-dev/svs-shared-library-1.0.0-NIGHTLY-20251119-807-lto.tar.gz" + set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.1.0/svs-shared-library-0.1.0-lto.tar.gz" CACHE STRING "URL to download SVS shared library") else() message(WARNING "Pre-built LVQ/LeanVec SVS library requires GCC/G++ v.11.2 to apply LTO optimizations." "Current compiler: ${CMAKE_CXX_COMPILER_ID} ${CMAKE_CXX_COMPILER_VERSION}" ) - set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.0.11/svs-shared-library-0.0.11.tar.gz" + set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.1.0/svs-shared-library-0.1.0.tar.gz" CACHE STRING "URL to download SVS shared library") endif() include(FetchContent) diff --git a/examples/cpp/shared/CMakeLists.txt b/examples/cpp/shared/CMakeLists.txt index 84002c23f..8875ec95b 100644 --- a/examples/cpp/shared/CMakeLists.txt +++ b/examples/cpp/shared/CMakeLists.txt @@ -24,7 +24,7 @@ find_package(svs QUIET) if(NOT svs_FOUND) # If sourcing from pip/conda, the following steps are not necessary, simplifying workflow # If not found, download tarball from GitHub release and follow steps to fetch and find - set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.0.11/svs-shared-library-0.0.11.tar.gz" CACHE STRINGS "URL to download SVS shared library tarball if not found in system") + set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.1.0/svs-shared-library-0.1.0.tar.gz" CACHE STRINGS "URL to download SVS shared library tarball if not found in system") message(STATUS "SVS not found in system, downloading from: ${SVS_URL}") From 71d19a3f92cce96b839f103fb29002d968ca86d3 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Thu, 18 Dec 2025 15:44:22 -0800 Subject: [PATCH 05/17] Fail if ctests not found for runtime bindings --- .github/workflows/build-cpp-runtime-bindings.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-cpp-runtime-bindings.yml b/.github/workflows/build-cpp-runtime-bindings.yml index 9613ac986..73bd076eb 100644 --- a/.github/workflows/build-cpp-runtime-bindings.yml +++ b/.github/workflows/build-cpp-runtime-bindings.yml @@ -74,7 +74,7 @@ jobs: -v ${{ github.workspace }}:/workspace \ -w /workspace \ svs-manylinux228:latest \ - /bin/bash -c "source /etc/bashrc || true && ctest --test-dir bindings/cpp/build_cpp_bindings/tests --output-on-failure --verbose" + /bin/bash -c "source /etc/bashrc || true && ctest --test-dir bindings/cpp/build_cpp_bindings/tests --output-on-failure --no-tests=error --verbose" # Run full test script using the built artifacts test: From f4f48184e1b806aa5174febd06e67f652fae19cc Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Thu, 18 Dec 2025 16:05:05 -0800 Subject: [PATCH 06/17] Add license to dependabot --- .github/dependabot.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 47064f2dc..f60e31d3f 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -1,3 +1,17 @@ +# Copyright 2025 Intel Corporation +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + version: 2 updates: - package-ecosystem: "github-actions" From ceee4526a189ef2b3c2aaecace980eb427960cb2 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Fri, 19 Dec 2025 10:22:25 -0800 Subject: [PATCH 07/17] Add Faiss-SVS examples to pipeline --- .github/scripts/test-cpp-runtime-bindings.sh | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/scripts/test-cpp-runtime-bindings.sh b/.github/scripts/test-cpp-runtime-bindings.sh index f0251294c..d47c4c724 100644 --- a/.github/scripts/test-cpp-runtime-bindings.sh +++ b/.github/scripts/test-cpp-runtime-bindings.sh @@ -43,6 +43,11 @@ echo "-----------------------------------------------" echo " FAISS C++ tests: " ./tests/faiss_test --gtest_filter=SVS.* echo "-----------------------------------------------" +echo " FAISS-SVS C++ examples: " +make 10-SVS-Vamana-LVQ 11-SVS-Vamana-LeanVec +./tutorial/cpp/10-SVS-Vamana-LVQ +./tutorial/cpp/11-SVS-Vamana-LeanVec +echo "-----------------------------------------------" echo " FAISS python bindings: " cd faiss/python/ python setup.py build @@ -50,3 +55,7 @@ echo "-----------------------------------------------" echo " FAISS python tests: " cd ../../../tests/ PYTHONPATH=../build/faiss/python/build/lib/ OMP_NUM_THREADS=8 python -m unittest test_svs.py +echo "-----------------------------------------------" +echo " FAISS-SVS python examples: " +cd ../tutorial/python/ +PYTHONPATH=../../build/faiss/python/build/lib/ OMP_NUM_THREADS=8 python 11-SVS.py From 255dd9a1bad1d84f0e975cdc95f417b04e9f50da Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Tue, 6 Jan 2026 11:50:23 -0800 Subject: [PATCH 08/17] Add examples XFAIL for non-intel hardware --- .github/scripts/test-cpp-runtime-bindings.sh | 22 ++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/.github/scripts/test-cpp-runtime-bindings.sh b/.github/scripts/test-cpp-runtime-bindings.sh index d47c4c724..8256d455c 100644 --- a/.github/scripts/test-cpp-runtime-bindings.sh +++ b/.github/scripts/test-cpp-runtime-bindings.sh @@ -45,8 +45,26 @@ echo " FAISS C++ tests: " echo "-----------------------------------------------" echo " FAISS-SVS C++ examples: " make 10-SVS-Vamana-LVQ 11-SVS-Vamana-LeanVec -./tutorial/cpp/10-SVS-Vamana-LVQ -./tutorial/cpp/11-SVS-Vamana-LeanVec +# Check if running on Intel hardware (LVQ/LeanVec require Intel-specific instructions) +if grep -q "GenuineIntel" /proc/cpuinfo; then + ./tutorial/cpp/10-SVS-Vamana-LVQ + ./tutorial/cpp/11-SVS-Vamana-LeanVec +else + echo "Non-Intel CPU detected - LVQ/LeanVec examples expected to fail" + set +e + ./tutorial/cpp/10-SVS-Vamana-LVQ + exit_code_10=$? + ./tutorial/cpp/11-SVS-Vamana-LeanVec + exit_code_11=$? + set -e + + if [ $exit_code_10 -ne 0 ] && [ $exit_code_11 -ne 0 ]; then + echo "XFAIL: Examples failed as expected on non-Intel hardware" + else + echo "UNEXPECTED: One or more tests passed on non-Intel hardware (exit codes: $exit_code_10, $exit_code_11)" + exit 1 + fi +fi echo "-----------------------------------------------" echo " FAISS python bindings: " cd faiss/python/ From 287d5f3cbb8a44f600edc8e488a2fe06642c2c24 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Tue, 6 Jan 2026 13:48:13 -0800 Subject: [PATCH 09/17] Add xfail for python example as well --- .github/scripts/test-cpp-runtime-bindings.sh | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/.github/scripts/test-cpp-runtime-bindings.sh b/.github/scripts/test-cpp-runtime-bindings.sh index 8256d455c..2838515bc 100644 --- a/.github/scripts/test-cpp-runtime-bindings.sh +++ b/.github/scripts/test-cpp-runtime-bindings.sh @@ -76,4 +76,19 @@ PYTHONPATH=../build/faiss/python/build/lib/ OMP_NUM_THREADS=8 python -m unittest echo "-----------------------------------------------" echo " FAISS-SVS python examples: " cd ../tutorial/python/ -PYTHONPATH=../../build/faiss/python/build/lib/ OMP_NUM_THREADS=8 python 11-SVS.py +if grep -q "GenuineIntel" /proc/cpuinfo; then + PYTHONPATH=../../build/faiss/python/build/lib/ OMP_NUM_THREADS=8 python 11-SVS.py +else + echo "Non-Intel CPU detected - SVS python example expected to fail" + set +e + PYTHONPATH=../../build/faiss/python/build/lib/ OMP_NUM_THREADS=8 python 11-SVS.py + exit_code=$? + set -e + + if [ $exit_code -ne 0 ]; then + echo "XFAIL: Python example failed as expected on non-Intel hardware" + else + echo "UNEXPECTED: Python example passed on non-Intel hardware" + exit 1 + fi +fi From d0952911bae83fca02decbfb598110efb8cc1bae Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Tue, 6 Jan 2026 13:52:00 -0800 Subject: [PATCH 10/17] whitespace cleanup --- .github/scripts/test-cpp-runtime-bindings.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/scripts/test-cpp-runtime-bindings.sh b/.github/scripts/test-cpp-runtime-bindings.sh index 2838515bc..7619a3c98 100644 --- a/.github/scripts/test-cpp-runtime-bindings.sh +++ b/.github/scripts/test-cpp-runtime-bindings.sh @@ -57,7 +57,7 @@ else ./tutorial/cpp/11-SVS-Vamana-LeanVec exit_code_11=$? set -e - + if [ $exit_code_10 -ne 0 ] && [ $exit_code_11 -ne 0 ]; then echo "XFAIL: Examples failed as expected on non-Intel hardware" else @@ -84,7 +84,7 @@ else PYTHONPATH=../../build/faiss/python/build/lib/ OMP_NUM_THREADS=8 python 11-SVS.py exit_code=$? set -e - + if [ $exit_code -ne 0 ]; then echo "XFAIL: Python example failed as expected on non-Intel hardware" else From 52d3b229f99378e8ed13c50312ecf0ccda82d247 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Wed, 7 Jan 2026 21:32:32 -0800 Subject: [PATCH 11/17] Revert upload-artifact version --- .github/workflows/build-cpp-runtime-bindings.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-cpp-runtime-bindings.yml b/.github/workflows/build-cpp-runtime-bindings.yml index 73bd076eb..5cf892843 100644 --- a/.github/workflows/build-cpp-runtime-bindings.yml +++ b/.github/workflows/build-cpp-runtime-bindings.yml @@ -61,7 +61,7 @@ jobs: /bin/bash .github/scripts/build-cpp-runtime-bindings.sh - name: Upload cpp runtime bindings artifacts - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 + uses: actions/upload-artifact@v4 with: name: svs-cpp-runtime-bindings${{ matrix.suffix }} path: svs-cpp-runtime-bindings${{ matrix.suffix }}.tar.gz From 1e1a8d5f4711521499a83c21bc5eb93b402e110a Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Wed, 14 Jan 2026 15:22:59 -0800 Subject: [PATCH 12/17] temporarily test against faiss PR --- .github/scripts/test-cpp-runtime-bindings.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/test-cpp-runtime-bindings.sh b/.github/scripts/test-cpp-runtime-bindings.sh index 1e296b1e2..19d7aaa34 100644 --- a/.github/scripts/test-cpp-runtime-bindings.sh +++ b/.github/scripts/test-cpp-runtime-bindings.sh @@ -32,7 +32,7 @@ conda install -y mkl=2022.2.1 mkl-devel=2022.2.1 conda install -y /runtime_conda/libsvs-runtime-*.conda # Validate python and C++ tests against FAISS CI -git clone https://github.com/facebookresearch/faiss.git +git clone -b eglaser/svs-runtime-conda-enabling https://github.com/ethanglaser/faiss.git cd faiss echo "===============================================" From fe8130804ab5fa3140be2168f5c38a24b0b42351 Mon Sep 17 00:00:00 2001 From: y Date: Mon, 19 Jan 2026 16:02:16 -0800 Subject: [PATCH 13/17] Use latest major version for actions --- .github/workflows/build-cpp-runtime-bindings.yml | 8 ++++---- .github/workflows/build-linux-arm.yml | 2 +- .github/workflows/build-linux.yml | 2 +- .github/workflows/build-macos.yaml | 2 +- .github/workflows/cibuildwheel.yml | 2 +- .github/workflows/pre-commit.yml | 4 ++-- .github/workflows/skywalking-eyes.yml | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build-cpp-runtime-bindings.yml b/.github/workflows/build-cpp-runtime-bindings.yml index 456d91911..ec3ccf725 100644 --- a/.github/workflows/build-cpp-runtime-bindings.yml +++ b/.github/workflows/build-cpp-runtime-bindings.yml @@ -44,7 +44,7 @@ jobs: fail-fast: false steps: - - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 + - uses: actions/checkout@v6 - name: Build Docker image run: | @@ -61,7 +61,7 @@ jobs: /bin/bash .github/scripts/build-cpp-runtime-bindings.sh - name: Upload cpp runtime bindings artifacts - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v6 with: name: svs-cpp-runtime-bindings${{ matrix.suffix }} path: svs-cpp-runtime-bindings${{ matrix.suffix }}.tar.gz @@ -97,7 +97,7 @@ jobs: suffix: "-public-only" steps: - - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 + - uses: actions/checkout@v6 - name: Build Docker image run: | @@ -105,7 +105,7 @@ jobs: # Need to download for a new job - name: Download conda package - uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0 + uses: actions/download-artifact@v7 with: name: libsvs-runtime-conda${{ matrix.suffix }} path: runtime_conda diff --git a/.github/workflows/build-linux-arm.yml b/.github/workflows/build-linux-arm.yml index 146a4d9bc..111dff250 100644 --- a/.github/workflows/build-linux-arm.yml +++ b/.github/workflows/build-linux-arm.yml @@ -45,7 +45,7 @@ jobs: cc: clang-15 steps: - - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 + - uses: actions/checkout@v6 - name: Configure build working-directory: ${{ runner.temp }} diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index 8ca642acc..6a583ab14 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -67,7 +67,7 @@ jobs: ivf: ON steps: - - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 + - uses: actions/checkout@v6 - name: Install MKL timeout-minutes: 5 run: | diff --git a/.github/workflows/build-macos.yaml b/.github/workflows/build-macos.yaml index 6b2e3641f..55cbc3c44 100644 --- a/.github/workflows/build-macos.yaml +++ b/.github/workflows/build-macos.yaml @@ -44,7 +44,7 @@ jobs: needs_prefix: true steps: - - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 + - uses: actions/checkout@v6 - name: Install Compiler run: | diff --git a/.github/workflows/cibuildwheel.yml b/.github/workflows/cibuildwheel.yml index b3833d5ca..c7edce0d8 100644 --- a/.github/workflows/cibuildwheel.yml +++ b/.github/workflows/cibuildwheel.yml @@ -33,7 +33,7 @@ jobs: runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 + - uses: actions/checkout@v6 - name: Build Container run: | diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index 5853a3376..8a27fed7a 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -21,8 +21,8 @@ jobs: pre-commit: runs-on: ubuntu-24.04 steps: - - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 - - uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0 + - uses: actions/checkout@v6 + - uses: actions/setup-python@v6 with: python-version: '3.12' - uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1 diff --git a/.github/workflows/skywalking-eyes.yml b/.github/workflows/skywalking-eyes.yml index 619c83433..a67c83390 100644 --- a/.github/workflows/skywalking-eyes.yml +++ b/.github/workflows/skywalking-eyes.yml @@ -34,7 +34,7 @@ jobs: runs-on: ubuntu-24.04 steps: - name: Checkout code - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 + uses: actions/checkout@v6 - name: Run check uses: apache/skywalking-eyes/header@61275cc80d0798a405cb070f7d3a8aaf7cf2c2c1 # v0.8.0 with: From cd16479631058ba4050fde034a7a2b682f96720b Mon Sep 17 00:00:00 2001 From: y Date: Mon, 19 Jan 2026 16:54:11 -0800 Subject: [PATCH 14/17] downgrade upload-action to v4 --- .github/workflows/build-cpp-runtime-bindings.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-cpp-runtime-bindings.yml b/.github/workflows/build-cpp-runtime-bindings.yml index ec3ccf725..a8841579d 100644 --- a/.github/workflows/build-cpp-runtime-bindings.yml +++ b/.github/workflows/build-cpp-runtime-bindings.yml @@ -61,14 +61,14 @@ jobs: /bin/bash .github/scripts/build-cpp-runtime-bindings.sh - name: Upload cpp runtime bindings artifacts - uses: actions/upload-artifact@v6 + uses: actions/upload-artifact@v4 with: name: svs-cpp-runtime-bindings${{ matrix.suffix }} path: svs-cpp-runtime-bindings${{ matrix.suffix }}.tar.gz retention-days: 7 # Reduce retention due to size - name: Upload conda package artifacts - uses: actions/upload-artifact@v6 + uses: actions/upload-artifact@v4 with: name: libsvs-runtime-conda${{ matrix.suffix }} path: conda-bld/linux-64/libsvs-runtime-*.conda From 6a6dd4c505ca858e14416424221611847bac4913 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Mon, 26 Jan 2026 12:56:57 -0800 Subject: [PATCH 15/17] Clone main faiss branch --- .github/scripts/test-cpp-runtime-bindings.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/test-cpp-runtime-bindings.sh b/.github/scripts/test-cpp-runtime-bindings.sh index 19d7aaa34..1e296b1e2 100644 --- a/.github/scripts/test-cpp-runtime-bindings.sh +++ b/.github/scripts/test-cpp-runtime-bindings.sh @@ -32,7 +32,7 @@ conda install -y mkl=2022.2.1 mkl-devel=2022.2.1 conda install -y /runtime_conda/libsvs-runtime-*.conda # Validate python and C++ tests against FAISS CI -git clone -b eglaser/svs-runtime-conda-enabling https://github.com/ethanglaser/faiss.git +git clone https://github.com/facebookresearch/faiss.git cd faiss echo "===============================================" From 1bbb63401cd78ee88d7330120eff16b65d9cfb29 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Mon, 26 Jan 2026 13:20:00 -0800 Subject: [PATCH 16/17] One last attempt at upload v6 --- .github/workflows/build-cpp-runtime-bindings.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-cpp-runtime-bindings.yml b/.github/workflows/build-cpp-runtime-bindings.yml index a8841579d..ec3ccf725 100644 --- a/.github/workflows/build-cpp-runtime-bindings.yml +++ b/.github/workflows/build-cpp-runtime-bindings.yml @@ -61,14 +61,14 @@ jobs: /bin/bash .github/scripts/build-cpp-runtime-bindings.sh - name: Upload cpp runtime bindings artifacts - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v6 with: name: svs-cpp-runtime-bindings${{ matrix.suffix }} path: svs-cpp-runtime-bindings${{ matrix.suffix }}.tar.gz retention-days: 7 # Reduce retention due to size - name: Upload conda package artifacts - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v6 with: name: libsvs-runtime-conda${{ matrix.suffix }} path: conda-bld/linux-64/libsvs-runtime-*.conda From f37b29f87d417f66c7c67992ad6c6f01600a8bb6 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Mon, 26 Jan 2026 14:40:06 -0800 Subject: [PATCH 17/17] restore upload and download to v4 --- .github/workflows/build-cpp-runtime-bindings.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-cpp-runtime-bindings.yml b/.github/workflows/build-cpp-runtime-bindings.yml index ec3ccf725..e4e1f65d1 100644 --- a/.github/workflows/build-cpp-runtime-bindings.yml +++ b/.github/workflows/build-cpp-runtime-bindings.yml @@ -61,14 +61,14 @@ jobs: /bin/bash .github/scripts/build-cpp-runtime-bindings.sh - name: Upload cpp runtime bindings artifacts - uses: actions/upload-artifact@v6 + uses: actions/upload-artifact@v4 with: name: svs-cpp-runtime-bindings${{ matrix.suffix }} path: svs-cpp-runtime-bindings${{ matrix.suffix }}.tar.gz retention-days: 7 # Reduce retention due to size - name: Upload conda package artifacts - uses: actions/upload-artifact@v6 + uses: actions/upload-artifact@v4 with: name: libsvs-runtime-conda${{ matrix.suffix }} path: conda-bld/linux-64/libsvs-runtime-*.conda @@ -105,7 +105,7 @@ jobs: # Need to download for a new job - name: Download conda package - uses: actions/download-artifact@v7 + uses: actions/download-artifact@v4 with: name: libsvs-runtime-conda${{ matrix.suffix }} path: runtime_conda