Skip to content

Fix memory consumption spike #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix memory consumption spike #231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3e2d1d
initial
Nov 25, 2025
5ce6d0e
linting
Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions include/svs/core/data/simple.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "svs/lib/uuid.h"

// stdlib
#include <memory>
#include <span>
#include <type_traits>

Expand Down Expand Up @@ -672,10 +673,10 @@ class SimpleData<T, Extent, Blocked<Alloc>> {
/// Add a new data block to the end of the current collection of blocks.
///
void add_block() {
blocks_.emplace_back(
blocks_.emplace_back(std::make_unique<array_type>(
make_dims(blocksize().value(), lib::forward_extent<Extent>(dimensions())),
allocator_.get_allocator()
);
));
}

///
Expand Down Expand Up @@ -727,12 +728,12 @@ class SimpleData<T, Extent, Blocked<Alloc>> {

const_value_type get_datum(size_t i) const {
auto [block_id, data_id] = resolve(i);
return getindex(blocks_, block_id).slice(data_id);
return getindex(blocks_, block_id)->slice(data_id);
}

value_type get_datum(size_t i) {
auto [block_id, data_id] = resolve(i);
return getindex(blocks_, block_id).slice(data_id);
return getindex(blocks_, block_id)->slice(data_id);
}

void prefetch(size_t i) const { lib::prefetch(get_datum(i)); }
Expand Down Expand Up @@ -827,7 +828,7 @@ class SimpleData<T, Extent, Blocked<Alloc>> {
private:
// The blocksize in terms of number of vectors.
lib::PowerOfTwo blocksize_;
std::vector<array_type> blocks_;
std::vector<std::unique_ptr<array_type>> blocks_;
size_t dimensions_;
size_t size_;
Blocked<Alloc> allocator_;
Expand Down
Loading