ZC v1314 : Shared mem for HPD, handling S4 in KMD and hardening of DVInstaller

Author: sraman4

DVInstaller.ps1

@@ -6,29 +6,68 @@
 #--------------------------------------------------------------------------*/
 
 #check if file present
-$global:maxcount = 30
+$global:maxcount = 10
 function is_present($filepath)
 {
 	$isavailable = Test-Path $filepath
 	return $isavailable
 }
 
+function log_file()
+{
+	$originalLogFile = "DvServer_log.txt"
+	$incrementalLogFile = $originalLogFile
+	$counter = 1
+
+	while (Test-Path $incrementalLogFile) {
+		$incrementalLogFile = "{0}-{1}.txt" -f $originalLogFile.Replace('.txt',''), $counter
+		$counter++
+	}
+
+return $incrementalLogFile
+
+}
+
 #check if all the required binaries are present or not
 function check_executables()
 {
-	if ((is_present("DVServer\dvserver.cat") -eq $true) -and
-		(is_present("DVServer\DVServer.dll") -eq $true) -and
-		(is_present("DVServer\DVServer.inf") -eq $true) -and
-		(is_present("DVServer\dvserverkmd.cat") -eq $true) -and
-		(is_present("DVServer\DVServerKMD.inf") -eq $true) -and
-		(is_present("DVServer\DVServerKMD.sys") -eq $true) -and
-		(is_present("DVEnabler.dll") -eq $true) -and
-        (is_present("GraphicsDriver\Graphics\iigd_dch.inf") -eq $true)){
-            Write-Host "Setup files present"
-			return "SUCCESS"
+	$files = "DVServer\dvserver.cat", "DVServer\DVServer.dll", "DVServer\DVServer.inf", "DVServer\dvserverkmd.cat", "DVServer\DVServerKMD.inf", "DVServer\DVServerKMD.sys", "DVEnabler.dll"
+
+	# ArrayList to store the names of missing files
+	$missingFiles = New-Object System.Collections.ArrayList
+
+	foreach ($file in $files) {
+		if (-not (is_present $file)) {
+			[void]$missingFiles.Add($file)
+		}
 	}
-	Write-Host "Setup files don't exist.. Exiting.."
-	return "FAIL"
+
+	# Output the result
+	if ($missingFiles.Count -eq 0) {
+		Write-Host "Setup files present"
+	}
+	else {
+		Write-Host "The following files needed for installation are missing:"
+		Write-Host ($missingFiles -join "`n")
+		return "FAIL"
+	}
+}
+
+function dvserver_cleanup()
+{
+		if(pnputil.exe /enum-drivers | findstr /i dvserverkmd.inf) {
+			$driverPackage = Get-WmiObject -Class Win32_PnPSignedDriver | Where-Object { $_.DeviceName -eq "DVServerKMD Device" }
+			if ($driverPackage) {
+			$publishedName = $driverPackage.InfName
+			pnputil.exe /delete-driver "$publishedName" /force /uninstall
+			}
+		}
+
+		Write-Host "Driver Installation failed.. "
+		Write-Host "Please Reboot the system and Run the Installation Script Again."
+		Stop-Transcript
+
+		Exit
 }
 
 function start_dvenabler()
@@ -45,17 +84,18 @@ function start_dvenabler()
 	$count = 0
 
 	rundll32.exe DVEnabler.dll,dvenabler_init
+	Write-Host "Starting DVEnabler... Please wait..."
 	# Before Rebooting the system, we need to make sure that DVEnabler.dll has been kick started
-	# So adding a loop with a counter of maxcount = 30, To check if DVEnabler has started
-	# If DVEnabler doesnt get started before 30 iteration, we will exit the script.
+	# So adding a loop with a counter of maxcount = 10, To check if DVEnabler has started
+	# If DVEnabler doesn’t  get started before 10 iteration, we will exit the script.
 	while($count -lt $maxcount){
 		$dve = tasklist /m | findstr "DVEnabler.dll"
 		if ($dve) {
 			Write-Host "DVEnabler started as service ."
 			break
 		} else {
-			Write-Host "Starting DVEnabler... Please wait..."
 			$count ++
+			Write-Host -NoNewline " $($count)/$maxcount Done `r"; sleep 1
 			continue
 		}
 	}
@@ -69,63 +109,134 @@ function start_dvenabler()
 	#Copying DVEnabler.DLL to system32 is required as part of the installation
 	cp DVEnabler.dll C:\Windows\System32
 
-	#regiter a task to start the dvenabler.dll as a service during every user logon
+	#Resgister the DVEnabler task during workstation lock and unlock
+	Register_ScheduledTask
+
+	return "SUCCESS"
+}
+
+function Register_ScheduledTask()
+{
+	$TASK_SESSION_UNLOCK = 8 #TASK_SESSION_STATE_CHANGE_TYPE.TASK_SESSION_UNLOCK (taskschd.h)
+	$TASK_SESSION_LOCK = 7  #TASK_SESSION_STATE_CHANGE_TYPE.TASK_SESSION_LOCK (taskschd.h)
+
+	$stateChangeTrigger = Get-CimClass `
+		-Namespace ROOT\Microsoft\Windows\TaskScheduler `
+		-ClassName MSFT_TaskSessionStateChangeTrigger
+
+	$onUnlockTrigger = New-CimInstance ` -CimClass $stateChangeTrigger `
+		-Property @{ StateChange = $TASK_SESSION_UNLOCK } ` -ClientOnly
+
+	$onLockTrigger = New-CimInstance ` -CimClass $stateChangeTrigger `
+		-Property @{ StateChange = $TASK_SESSION_LOCK } ` -ClientOnly
+
 	unregister-scheduledtask -TaskName "DVEnabler" -confirm:$false -ErrorAction SilentlyContinue
+	unregister-scheduledtask -TaskName "StopDVEnabler" -confirm:$false -ErrorAction SilentlyContinue
+
+	#Register a task to start the dvenabler.dll as a service during every user logon or user unlock
 		$ac = New-ScheduledTaskAction -Execute "rundll32.exe"  -Argument "C:\Windows\System32\DVEnabler.dll,dvenabler_init"
 		$tr = New-ScheduledTaskTrigger -AtLogOn
-		$pr = New-ScheduledTaskPrincipal  -Groupid  "INTERACTIVE"
-	Register-ScheduledTask -TaskName "DVEnabler" -Trigger $tr -TaskPath "\Microsoft\Windows\DVEnabler" -Action $ac -Principal $pr
+		$pr = New-ScheduledTaskPrincipal  -Groupid  "INTERACTIVE" -RunLevel Highest
+		$settings = New-ScheduledTaskSettingsSet -AllowStartIfOnBatteries -ExecutionTimeLimit 0 -MultipleInstances Queue
+	Register-ScheduledTask -TaskName "DVEnabler" -Trigger @($tr, $onUnlockTrigger) -TaskPath "\Microsoft\Windows\DVEnabler" -Action $ac -Principal $pr -Settings $settings
+
+	#Register a task to Stop the dvenabler.dll during every user lock
+		$ac = New-ScheduledTaskAction -Execute "powershell.exe"  -Argument "-ExecutionPolicy Bypass -NoProfile -WindowStyle Hidden -Command `"Stop-ScheduledTask -TaskName '\Microsoft\Windows\DVEnabler\DvEnabler'`""
+		$pr = New-ScheduledTaskPrincipal  -Groupid  "INTERACTIVE" -RunLevel Highest
+		$settings = New-ScheduledTaskSettingsSet -AllowStartIfOnBatteries -ExecutionTimeLimit 0 -MultipleInstances Queue
+	Register-ScheduledTask -TaskName "StopDVEnabler" -Trigger $onLockTrigger -TaskPath "\Microsoft\Windows\DVEnabler" -Action $ac -Principal $pr -Settings $settings
 
 	return "SUCCESS"
+
 }
 
 ##Main##
+$logfile = log_file
+Start-Transcript -Path $logfile -Append
+
 $ret = check_executables
 if ($ret -eq "FAIL") {
+	Stop-Transcript
 	Exit
 }
 else {
+	# Do a refresh before starting the installation.
+	pnputil /scan-devices
+
 	if ((is_present("DVServer.cer") -eq $true) -and
 	(is_present("DVServerKMD.cer") -eq $true)){
 		Write-Host "Start DVServer Certificate installation..."
 		certutil -addstore root DVServer.cer
 		certutil -addstore root DVServerKMD.cer
 	}
-	
-	Write-Host "Start Windows GFX Driver installation..."
-	pnputil.exe /add-driver .\GraphicsDriver\Graphics\iigd_dch.inf /install
 
 	Write-Host "Start Zerocopy Driver installation..."
 	pnputil.exe /add-driver .\DVServer\DVServerKMD.inf /install
 	$count = 0
 	# Before starting DVEnabler.dll we should make sure that DVServer UMD has started or not
-	# So adding a loop with a counter of maxcount = 30, To check if DVServer UMD has started
-	# if DVserver UMD doesnt get started before 30 iteration, we will exit the script
+	# So adding a loop with a counter of maxcount = 10, To check if DVServer UMD has started
+	# if DVserver UMD doesn’t  get started before 10 iteration, we will exit the script
+	Write-Host "DVServer loading...Please wait..."
 	while($count -lt $maxcount){
 		$dvs= tasklist /m | findstr "dvserver.dll"
 		if ($dvs) {
 			Write-Host "DVServer loaded successfully..."
 			break
 		} else {
-			Write-Host "DVServer loading...Please wait..."
 			$count ++
+			 Write-Host -NoNewline " $($count)/$maxcount Done `r"; sleep 1
 			continue
 		}
 	}
+
+	# Reset the count
+	$count = 0
+
 	if (!$dvs) {
-		Write-Host "Failed to load DVServer UMD... Exiting"
-		Exit
+		Write-Host "Trying to install DVServer UMD..."
+		pnputil.exe /add-driver .\DVServer\DVServer.inf /install
+		while($count -lt $maxcount){
+			$dvs= tasklist /m | findstr "dvserver.dll"
+			if ($dvs) {
+				Write-Host "DVServer loaded successfully..."
+				break
+			} else {
+				$count ++
+				Write-Host -NoNewline " $($count)/$maxcount Done `r"; sleep 1
+				continue
+			}
+		}
+
+	}
+
+	if (!$dvs) {
+		Write-Host "Failed to load DVServer UMD..."
+		dvserver_cleanup
 	}
 
-	#call start_dvnabler to run the dvenabler.sll as a service
+	#call start_dvenabler to run the dvenabler.dll as a service
 	$dve = start_dvenabler
 	if ($dve -eq "SUCCESS") {
-		Write-Host "Dvnabler succusfully started...."
+		Write-Host "Dvenabler successfully  started...."
 		Write-Host "Rebooting Windows VM..."
+		Stop-Transcript
 		Restart-Computer
 	} else {
-		Write-Host "Fail to start Dvnabler.... Exiting!"
-		Exit
+		Write-Host "Failed to start DVEnabler...."
+
+		#Before cleanup, make IDD as primary monitor , so that the user can see the PowerShell window
+
+		# Get the second display device name
+		$secondDisplay = (Get-WmiObject -Namespace "root\CIMV2" -Class Win32_VideoController | Select-Object -Skip 1 -First 1).Name
+
+		# Set the second display as the primary display using DisplaySwitch.exe
+		DisplaySwitch.exe /internal
+		DisplaySwitch.exe /external:$secondDisplay
+
+		# Restart the Explorer process to apply the changes
+		Stop-Process -Name "explorer" -Force
+
+		dvserver_cleanup
 	}
 
 }

DVServerKMD/Device.cpp

@@ -335,7 +335,7 @@ NTSTATUS DVServerKMDEvtD0Exit(
 	NTSTATUS status = STATUS_SUCCESS;
 	PDEVICE_CONTEXT pDeviceContext;
 	VioGpuAdapterLite* pVioGpuAdapterLite;
-
+	TRACING();
 	UNREFERENCED_PARAMETER(PreviousState);
 
 	pDeviceContext = DeviceGetContext(Device);
@@ -383,7 +383,7 @@ BOOLEAN DVServerKMDEvtInterruptISR(
 {
 	PDEVICE_CONTEXT pDeviceContext;
 	VioGpuAdapterLite* pVioGpuAdapterLite;
-
+	TRACING();
 	pDeviceContext = DeviceGetContext(WdfInterruptGetDevice(Interrupt));
 
 	//
@@ -424,7 +424,7 @@ void DVServerKMDEvtInterruptDPC(
 {
 	PDEVICE_CONTEXT pDeviceContext;
 	VioGpuAdapterLite* pVioGpuAdapterLite;
-
+	TRACING();
 	UNREFERENCED_PARAMETER(AssociatedObject);
 
 	pDeviceContext = DeviceGetContext(WdfInterruptGetDevice(Interrupt));
@@ -440,6 +440,45 @@ void DVServerKMDEvtInterruptDPC(
 	pVioGpuAdapterLite->DpcRoutine();
 }
 
+NTSTATUS
+DVServerKMDEvtDeviceD0ExitPreInterruptsDisabled(
+	IN WDFDEVICE Device,
+	IN WDF_POWER_DEVICE_STATE TargetState
+)
+/*++
+
+Routine Description:
+
+	EvtDeviceD0ExitPreInterruptsDisabled is called by the framework before the
+	driver disables the device's hardware interrupts.
+
+Arguments:
+
+	Device - Handle to a framework device object.
+
+	TargetState - A WDF_POWER_DEVICE_STATE-typed enumerator that identifies the
+				  device power state that the device is about to enter.
+
+Return Value:
+
+	NTSTATUS - Failures will be logged, but not acted on.
+
+--*/
+{
+	UNREFERENCED_PARAMETER(TargetState);
+	TRACING();
+	PAGED_CODE();
+
+	PDEVICE_CONTEXT pDeviceContext;
+	pDeviceContext = DeviceGetContext(Device);
+	VioGpuAdapterLite* pVioGpuAdapterLite;
+	pVioGpuAdapterLite = (VioGpuAdapterLite*)pDeviceContext->pvDeviceExtension;
+
+	pVioGpuAdapterLite->DestroyFrameBufferCursorObjExt();
+
+	return STATUS_SUCCESS;
+}
+
 NTSTATUS DVServerKMDEvtInterruptEnable(
 	IN WDFINTERRUPT  Interrupt,
 	IN WDFDEVICE     AssociatedDevice
@@ -466,6 +505,7 @@ Return Value:
 
 --*/
 {
+	TRACING();
 	UNREFERENCED_PARAMETER(Interrupt);
 	UNREFERENCED_PARAMETER(AssociatedDevice);
 
@@ -498,9 +538,16 @@ Return Value:
 
 --*/
 {
-	UNREFERENCED_PARAMETER(Interrupt);
+	TRACING();
 	UNREFERENCED_PARAMETER(AssociatedDevice);
 
+	PDEVICE_CONTEXT pDeviceContext;
+	pDeviceContext = DeviceGetContext(WdfInterruptGetDevice(Interrupt));
+	VioGpuAdapterLite* pVioGpuAdapterLite;
+	pVioGpuAdapterLite = (VioGpuAdapterLite*)pDeviceContext->pvDeviceExtension;
+
+	pVioGpuAdapterLite->DisableInterruptExt();
+
 	return STATUS_SUCCESS;
 }
 

DVServerKMD/Device.h

@@ -54,6 +54,7 @@ EVT_WDF_DEVICE_D0_ENTRY DVServerKMDEvtD0Entry;
 EVT_WDF_DEVICE_D0_EXIT DVServerKMDEvtD0Exit;
 EVT_WDF_INTERRUPT_ISR DVServerKMDEvtInterruptISR;
 EVT_WDF_INTERRUPT_DPC DVServerKMDEvtInterruptDPC;
+EVT_WDF_DEVICE_D0_EXIT_PRE_INTERRUPTS_DISABLED DVServerKMDEvtDeviceD0ExitPreInterruptsDisabled;
 EVT_WDF_INTERRUPT_ENABLE DVServerKMDEvtInterruptEnable;
 EVT_WDF_INTERRUPT_DISABLE DVServerKMDEvtInterruptDisable;
 EXTERN_C_END

DVServerKMD/Driver.cpp

@@ -127,6 +127,7 @@ Return Value:
 
 --*/
 {
+	TRACING();
 	WPP_CLEANUP(WdfDriverWdmGetDriverObject(driver));
 
 	return;
@@ -187,6 +188,8 @@ Return Value:
 	pnpPowerCallbacks.EvtDeviceD0Entry = DVServerKMDEvtD0Entry;
 	pnpPowerCallbacks.EvtDeviceD0Exit = DVServerKMDEvtD0Exit;
 
+	pnpPowerCallbacks.EvtDeviceD0ExitPreInterruptsDisabled = DVServerKMDEvtDeviceD0ExitPreInterruptsDisabled;
+
 	//
 	// Register the PnP Callbacks..
 	//