Apply suggestions from code review

Co-authored-by: Jean-Philippe Raynaud <jp.raynaud@gmail.com>

Author: curiecrypt

mithril-common/src/crypto_helper/codec/binary.rs

@@ -61,7 +61,7 @@ mod binary_mithril_stm {
 
     impl TryFromBytes for SingleSignature {
         fn try_from_bytes(bytes: &[u8]) -> StdResult<Self> {
-            Self::from_bytes::<D>(bytes).map_err(|e| anyhow!(e))
+            Self::from_bytes::<D>(bytes)
         }
     }
 

mithril-stm/README.md

@@ -136,15 +136,21 @@ match msig {
         println!("Aggregate ok");
         assert!(aggr.verify(&msg, &clerk.compute_aggregate_verification_key(), &params).is_ok());
     }
-    Err(error) => assert!(
-        matches!(
-            error.downcast_ref::<AggregationError>(),
-            Some(AggregationError::NotEnoughSignatures { .. })
-                | Some(AggregationError::UsizeConversionInvalid)
-                | Some(AggregationError::UnsupportedProofSystem { .. })
-        ),
-        "Unexpected error: {error}"
-    ),
+    Err(error) => match error.downcast_ref::<AggregationError>() {
+        Some(AggregationError::NotEnoughSignatures(n, k)) => {
+            println!("Not enough signatures");
+            assert!(n < params.k && k == params.k)
+        },
+        Some(AggregationError::UsizeConversionInvalid) => {
+            println!("Invalid usize conversion");
+        },
+        Some(AggregationError::UnsupportedProofSystem(aggregate_signature_type)) => {
+            println!("Unsupported proof system: {:?}", aggregate_signature_type);
+        },
+        None => {
+            println!("Unexpected error during aggregation: {:?}", error);
+        }
+    },
 }
 ```
 

mithril-stm/src/aggregate_signature/basic_verifier.rs

@@ -247,7 +247,7 @@ impl BasicVerifier {
         let (sigs, vks) = Self::collect_signatures_verification_keys(&unique_sigs);
 
         BlsSignature::verify_aggregate(msg.to_vec().as_slice(), &vks, &sigs)
-            .with_context(|| "Basic verifier failed in multisignature verification.")?;
+            .with_context(|| "Basic verifier failed during BLS aggregate signature verification.")?;
 
         Ok(())
     }