Apply suggestions from code review

Co-authored-by: Jean-Philippe Raynaud <jp.raynaud@gmail.com>

Author: curiecrypt

mithril-stm/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-stm"
-version = "0.5.6"
+version = "0.6.0"
 edition = { workspace = true }
 authors = { workspace = true }
 homepage = { workspace = true }

mithril-stm/README.md

@@ -141,9 +141,7 @@ match msig {
             println!("Not enough signatures");
             assert!(n < &params.k && k == &params.k)
         },
-        // Some(AggregationError::UsizeConversionInvalid) => {
-        //     println!("Invalid usize conversion");
-        // },
+
         Some(AggregationError::UnsupportedProofSystem(aggregate_signature_type)) => {
             println!("Unsupported proof system: {:?}", aggregate_signature_type);
         },

mithril-stm/src/aggregate_signature/mod.rs

@@ -267,9 +267,7 @@ mod tests {
                         println!("Not enough signatures");
                         assert!(n < &params.k && k == &params.k)
                     },
-                    // Some(AggregationError::UsizeConversionInvalid) => {
-                    //     println!("Invalid usize conversion");
-                    // },
+
                     Some(AggregationError::UnsupportedProofSystem(aggregate_signature_type)) => {
                         println!("Unsupported proof system: {:?}", aggregate_signature_type);
                     },

mithril-stm/src/key_registration.rs

@@ -141,7 +141,7 @@ mod tests {
                             assert_eq!(fake_it, 0);
                             assert!(a.verify_proof_of_possession().is_err());
                         },
-                        _ => {println!("Unexpected error: {error}")}
+                        _ => {panic!("Unexpected error: {error}")}
                     }
                 }
             }

mithril-stm/tests/stm_basic.rs

@@ -69,7 +69,7 @@ fn test_core_verifier() {
                 assert!((nr_indices) < &params.k)
             }
             _ => {
-                println!("Unexpected error: {:?}", error);
+                panic!("Unexpected error: {:?}", error);
             }
         },
     }

mithril-stm/tests/stm_protocol.rs

@@ -39,14 +39,12 @@ fn test_full_protocol() {
                 println!("Not enough signatures");
                 assert!(n < &params.k && k == &params.k)
             }
-            // Some(AggregationError::UsizeConversionInvalid) => {
-            //     println!("Invalid usize conversion");
-            // }
+
             Some(AggregationError::UnsupportedProofSystem(aggregate_signature_type)) => {
-                println!("Unsupported proof system: {:?}", aggregate_signature_type);
+                panic!("Unsupported proof system: {:?}", aggregate_signature_type);
             }
             _ => {
-                println!("Unexpected error during aggregation: {:?}", error);
+                panic!("Unexpected error during aggregation: {:?}", error);
             }
         },
     }