Fix RiskyTruthyFalsyComparison (#94)

antonioeatgoat · web-flow · commit 3ca834411898 · 2024-07-03T18:06:42.000+02:00
diff --git a/Inpsyde/Helpers/FunctionDocBlock.php b/Inpsyde/Helpers/FunctionDocBlock.php
@@ -101,7 +101,7 @@ public static function tag(string $tag, File $file, int $position): array
     {
         $tagName = '@' . ltrim($tag, '@');
         $tags = static::allTags($file, $position);
-        if (empty($tags[$tagName])) {
+        if (!isset($tags[$tagName]) || $tags[$tagName] === []) {
             return [];
         }
 
diff --git a/psalm.xml b/psalm.xml
@@ -27,5 +27,8 @@
         <MixedAssignment errorLevel="suppress" />
         <RedundantCastGivenDocblockType errorLevel="suppress" />
         <RedundantConditionGivenDocblockType errorLevel="suppress" />
+
+        <!-- Suppressing that can be removed when minimum PHP version will become 8.3 -->
+        <MissingClassConstType errorLevel="suppress" />
     </issueHandlers>
 </psalm>

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ public static function tag(string $tag, File $file, int $position): array`
`101`	`101`	`{`
`102`	`102`	`$tagName = '@' . ltrim($tag, '@');`
`103`	`103`	`$tags = static::allTags($file, $position);`
`104`		`- if (empty($tags[$tagName])) {`
	`104`	`+ if (!isset($tags[$tagName]) \|\| $tags[$tagName] === []) {`
`105`	`105`	`return [];`
`106`	`106`	`}`
`107`	`107`