feat!: Updated pr title check and preview release type #28
+126
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-infra
changed the title
rahul-infra
changed the title
rahul-infra
force-pushed
the
fix/github-release-type
branch
from
bbe9fdf to
6a2736a
Compare
rahul-infra
changed the title
ashwinimanoj
reviewed
Dec 2, 2025
| run: | | ||
| # Get commits from this PR | ||
| COMMITS=$(git log origin/${{ github.base_ref }}..HEAD --pretty=format:"%s") | ||
| echo "Commits in this PR:" |
There was a problem hiding this comment.
if we are using semantic release to determine this, why are we adding our own script for version?
Why not use semantic release action itself?
ashwinimanoj
reviewed
Dec 2, 2025
|
|
||
| body = `## Release Preview\n\n**Release Type:** \`${releaseType}\`\n**Next Version:** \`v${version}\`\n\n### Release Notes\n${notes}\n\n---\n*This shows what release will be created when this PR is merged.*`; | ||
| } else { | ||
| body = '## Release Preview\n\nNo new release will be created from this PR.\n\nThis PR does not contain conventional commits that trigger a release.'; |
There was a problem hiding this comment.
would suggest using existing action instead of writing out own script. Please refer to how terraform output is commented on the PR.
Made changes in terraform workflow Updated github workflows. removed github token decleration in my new version preview feat!: breaking change to workflow BREAKING CHANGE: Updated release preview mechanism fix: use PR merge ref for version preview fix: changes versionpreview.yaml fix: Updated Preview.yaml file fix: updated versions-preview workflow making it edit the existing release preview refactor: simplify version preview using semantic-release action fix: configure semantic-release to analyze PR branches fix: use semantic-release with proper branch configuration fix: create branch instead of renaming in detached HEAD debug: add logging to see what semantic-release sees fix: pass PR number as input to version-preview workflow fix: made changes in version-preivew for using sematic release.
rahul-infra
force-pushed
the
fix/github-release-type
branch
from
4a21396 to
5816a0d
Compare
Contributor
Release PreviewNo new release will be created from this PR. This PR does not contain conventional commits that trigger a release. |
BREAKING CHANGES: Made changes for readme file in cross-account examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.