diff --git a/.basedpyright/baseline.json b/.basedpyright/baseline.json index 8ea4a39b..f240e967 100644 --- a/.basedpyright/baseline.json +++ b/.basedpyright/baseline.json @@ -276,8 +276,8 @@ { "code": "reportUnusedImport", "range": { - "startColumn": 48, - "endColumn": 88, + "startColumn": 12, + "endColumn": 52, "lineCount": 1 } }, @@ -6687,14 +6687,6 @@ } ], "./grudge/reductions.py": [ - { - "code": "reportUnknownVariableType", - "range": { - "startColumn": 4, - "endColumn": 22, - "lineCount": 1 - } - }, { "code": "reportUnknownParameterType", "range": { diff --git a/examples/wave/wave-op-var-velocity.py b/examples/wave/wave-op-var-velocity.py index 4229761d..47c763f2 100644 --- a/examples/wave/wave-op-var-velocity.py +++ b/examples/wave/wave-op-var-velocity.py @@ -27,11 +27,11 @@ import logging import numpy as np -import numpy.linalg as la # noqa +import numpy.linalg as la # noqa: F401 import pyopencl as cl import pyopencl.tools as cl_tools -from meshmode.mesh import BTAG_ALL, BTAG_NONE # noqa +from meshmode.mesh import BTAG_ALL, BTAG_NONE # noqa: F401 from pytools import obj_array import grudge.geometry as geo diff --git a/grudge/array_context.py b/grudge/array_context.py index 68b3374c..e2ad0087 100644 --- a/grudge/array_context.py +++ b/grudge/array_context.py @@ -62,7 +62,9 @@ try: # Crude check if we have the correct loopy branch # (https://github.com/kaushikcfd/loopy/tree/pytato-array-context-transforms) - from loopy.transform.loop_fusion import get_kennedy_unweighted_fusion_candidates # noqa + from loopy.transform.loop_fusion import ( + get_kennedy_unweighted_fusion_candidates, # noqa: F401 + ) except ImportError: warn("Your loopy and meshmode branches are mismatched. " "Please make sure that you have the " @@ -645,7 +647,7 @@ def get_reasonable_array_context_class( if not _HAVE_FUSION_ACTX: warn("No device-parallel actx available, execution will be slow. " "Please make sure you have the right branches for loopy " - "(https://github.com/kaushikcfd/loopy/tree/pytato-array-context-transforms) " # noqa + "(https://github.com/kaushikcfd/loopy/tree/pytato-array-context-transforms) " # noqa: E501 "and meshmode " "(https://github.com/kaushikcfd/meshmode/tree/pytato-array-context-transforms).", stacklevel=1) diff --git a/grudge/geometry/metrics.py b/grudge/geometry/metrics.py index 6691cc86..4d18bc95 100644 --- a/grudge/geometry/metrics.py +++ b/grudge/geometry/metrics.py @@ -410,7 +410,7 @@ def inverse_first_fundamental_form( obj_array.new_1d([-F, E])] ) else: - raise ValueError(f"{dim}D surfaces not supported" % dim) + raise ValueError(f"{dim}D surfaces not supported") return inv_form1 diff --git a/grudge/trace_pair.py b/grudge/trace_pair.py index d8fdf7cc..8247a0ad 100644 --- a/grudge/trace_pair.py +++ b/grudge/trace_pair.py @@ -426,7 +426,7 @@ def _sym_tag_to_num_tag(comm_tag: Hashable | None, base_tag: int) -> int: # FIXME: This isn't guaranteed to be correct. # See here for discussion: - # - https://github.com/illinois-ceesd/mirgecom/issues/617#issuecomment-1057082716 # noqa + # - https://github.com/illinois-ceesd/mirgecom/issues/617#issuecomment-1057082716 # - https://github.com/inducer/grudge/pull/222 # Since only 1 communication can be pending for a given tag at a time, # this does not matter currently. See https://github.com/inducer/grudge/issues/223 diff --git a/test/test_grudge.py b/test/test_grudge.py index fe7c5ee0..0993a6c3 100644 --- a/test/test_grudge.py +++ b/test/test_grudge.py @@ -873,7 +873,7 @@ def rhs(t, u, adv_operator=adv_operator): if visualize: vis.write_vtk_file( - f"fld-{mesh_par}-{step:04d}vtu" % (mesh_par, step), + f"fld-{mesh_par}-{step:04d}vtu", [("u", u)] )