[BUG] OnArriveGraffiti cannot cast GraffitiBehaviour on IL2CPP

[ifBars]

Summary

LocationBasedActionSpec.OnArriveGraffiti() fails when a custom NPC schedule activates location-based graffiti on IL2CPP. The NPC starts walking toward the graffiti action, then stops, and S1API logs that the resolved GraffitiBehaviour could not be cast to the concrete type.

Game Version

Other (specify in Additional Context)

S1API Version

3.0.5 / current stable local build

MelonLoader Version

0.7.2

Runtime Environment

IL2CPP (Regular)

Steps to Reproduce

1. Create a custom NPC with builder.EnsureGraffiti() in prefab configuration.
2. Add a location-based schedule action that calls .OnArriveGraffiti().
3. Load the NPC on the public IL2CPP game branch.
4. Let the NPC's schedule activate the graffiti action.
5. Observe that the NPC walks briefly/stops and graffiti never starts.

Expected vs Actual Behavior

Expected: The NPC resolves its GraffitiBehaviour, assigns a spray surface, activates the behavior, and starts spraying graffiti.

Actual: The graffiti behavior lookup returns something named/resolved as GraffitiBehaviour, but S1API fails the concrete cast and returns before assigning the surface or activating the behavior.

MelonLoader Log

[16:58:30.889] Melon Assembly loaded: '.\Mods\CustomNPCTest_Il2cpp.dll'
[16:58:30.899] Melon Assembly loaded: '.\Mods\S1API.dll'
[16:58:31.128] S1API (Forked by Bars) v3.0.5
[16:58:36.313] CustomNPCTest mod initialized
[16:59:50.001] [LocationBasedActionSpec] [LocationBasedActionSpec] Graffiti: GraffitiBehaviour could not be cast to the concrete type.

What Have You Tried?

• Verified the issue reproduces after the same location-based schedule path was fixed for smoke breaks.
• Confirmed CustomNPCTest and S1API load successfully before the warning.
• Inspected the failing S1API path: LocationBasedActionSpec.ToggleGraffiti() calls npcBehaviour.GetBehaviour("GraffitiBehaviour"), then uses behaviour as GraffitiBehaviour; the cast fails on IL2CPP.

Additional Context

This looks similar in shape to the smoke-break issue fixed for #85: the schedule event fires and reaches the action-specific code, but the custom NPC behavior/component path does not line up with the current IL2CPP runtime wrapper behavior.

Initial suspicion: NPCBehaviour.GetBehaviour(string) returns the base Behaviour wrapper, and the direct C# as GraffitiBehaviour cast is not reliable for the IL2CPP wrapper object returned from that lookup. S1API may need to resolve the live component directly (GetComponentInChildren<GraffitiBehaviour>(true) / behavior stack scan / generated wrapper cast helper) before calling SetSpraySurface_Client.

Pre-submission Checklist

• I have read the installation guide
• I am using the latest version of S1API
• I have verified this issue is related to S1API (not general modding support)
• I am using MelonLoader 0.7.0 or have noted compatibility issues with 0.7.1+
• I have included my MelonLoader log or relevant excerpts

[coderabbitai]

🔗 Related PRs

#49 - Project destinations to NavMesh height [merged]
#52 - Add Sit schedule action and duration support [merged]
#69 - Various fixed: PlaceableStorageEntity ID NRE, red eyes not applying, dealer inventory wipe [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

• Create Plan

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[ifBars]

Initial diagnosis from the local repro:

• The warning is hit after ToggleGraffiti() successfully finds a spray surface and gets NPCBehaviour from the NPC.
• The failing line is the normal C# as GraffitiBehaviour cast after npcBehaviour.GetBehaviour("GraffitiBehaviour").
• This matches the IL2CPP casting caveat from the MelonLoader IL2CPP differences docs: IL2CPP proxy objects should use the Il2CppInterop .Cast<T>() / .TryCast<T>() path instead of relying on regular C# casts.
• S1API already has CrossType.Is<T>(), which wraps that IL2CPP cast path, so the local candidate fix resolves GraffitiBehaviour through CrossType.Is<T>() and falls back to GetComponentInChildren<GraffitiBehaviour>(true).

A local IL2CPP build passes with that candidate fix and has been deployed to the public test install for the same CustomNPCTest repro. Next validation step is to rerun the schedule and see whether graffiti now starts or moves to a follow-up dependency issue in SprayPaint.Begin().