Refactor minor style formatting in places

okay, also sneaks in a missing global object for importing elsewhere,
but it's a minor feature nobody is using yet.

Author: mattsta

ib_async/__init__.py

@@ -93,6 +93,7 @@
     OrderComboLeg,
     OrderCondition,
     OrderState,
+    OrderStateNumeric,
     OrderStatus,
     PercentChangeCondition,
     PriceCondition,

ib_async/contract.py

@@ -180,10 +180,13 @@ def __hash__(self) -> int:
 
     def __repr__(self):
         attrs = util.dataclassNonDefaults(self)
+
         if self.__class__ is not Contract:
             attrs.pop("secType", "")
+
         clsName = self.__class__.__qualname__
         kwargs = ", ".join(f"{k}={v!r}" for k, v in attrs.items())
+
         return f"{clsName}({kwargs})"
 
     __str__ = __repr__

ib_async/ib.py

@@ -48,6 +48,7 @@
     LimitOrder,
     Order,
     OrderState,
+    OrderStateNumeric,
     OrderStatus,
     StopOrder,
     Trade,
@@ -1458,9 +1459,11 @@ def reqTickByTickData(
         """
         reqId = self.client.getReqId()
         ticker = self.wrapper.startTicker(reqId, contract, tickType)
+
         self.client.reqTickByTickData(
             reqId, contract, tickType, numberOfTicks, ignoreSize
         )
+
         return ticker
 
     def cancelTickByTickData(self, contract: Contract, tickType: str) -> bool:

ib_async/order.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 import dataclasses
+
 from dataclasses import dataclass, field
 from decimal import Decimal
 from typing import ClassVar, NamedTuple
@@ -418,6 +419,7 @@ class Trade:
     log: list[TradeLogEntry] = field(default_factory=list)
     advancedError: str = ""
 
+    # TODO: replace these with an enum?
     events: ClassVar = (
         "statusEvent",
         "modifyEvent",

ib_async/wrapper.py

@@ -327,6 +327,7 @@ def connectionClosed(self):
         for future in self._futures.values():
             if not future.done():
                 future.set_exception(error)
+
         globalErrorEvent.emit(error)
         self.reset()
 
@@ -338,8 +339,10 @@ def startReq(self, key, contract=None, container=None):
         future: asyncio.Future = asyncio.Future()
         self._futures[key] = future
         self._results[key] = container if container is not None else []
+
         if contract:
             self._reqId2Contract[key] = contract
+
         return future
 
     def _endReq(self, key, result=None, success=True):
@@ -352,6 +355,7 @@ def _endReq(self, key, result=None, success=True):
         if future:
             if result is None:
                 result = self._results.pop(key, [])
+
             if not future.done():
                 if success:
                     future.set_result(result)
@@ -517,9 +521,11 @@ def position(
         position = Position(account, contract, posSize, avgCost)
         positions = self.positions[account]
 
+        # if this updates position to 0 quantity, remove the position
         if posSize == 0:
             positions.pop(contract.conId, None)
         else:
+            # else, add or replace the position in-place
             positions[contract.conId] = position
 
         self._logger.info(f"position: {position}")
@@ -1093,6 +1099,7 @@ def tickByTickBidAsk(
         tick = TickByTickBidAsk(
             self.lastTime, bidPrice, askPrice, bidSize, askSize, tickAttribBidAsk
         )
+
         ticker.tickByTicks.append(tick)
         self.pendingTickers.add(ticker)