Default to zipkin exporter (#305)

* defaulting to zipkin exporter

* spotless apply

* making smoke tests use OTLP exporter

Author: shashank11p

javaagent-core/src/main/java/org/hypertrace/agent/core/config/HypertraceConfig.java

@@ -56,7 +56,7 @@ private HypertraceConfig() {}
   private static volatile AgentConfig agentConfig;
 
   static final String DEFAULT_SERVICE_NAME = "unknown";
-  static final String DEFAULT_REPORTING_ENDPOINT = "http://localhost:4317";
+  static final String DEFAULT_REPORTING_ENDPOINT = "http://localhost:9411/api/v2/spans";
   static final String DEFAULT_OPA_ENDPOINT = "http://opa.traceableai:8181/";
   static final int DEFAULT_OPA_POLL_PERIOD_SECONDS = 30;
   // 128 KiB
@@ -189,7 +189,7 @@ private static Reporting.Builder applyReportingDefaults(Reporting.Builder builde
       builder.setEndpoint(StringValue.newBuilder().setValue(DEFAULT_REPORTING_ENDPOINT).build());
     }
     if (builder.getTraceReporterType().equals(Config.TraceReporterType.UNSPECIFIED)) {
-      builder.setTraceReporterType(Config.TraceReporterType.OTLP);
+      builder.setTraceReporterType(Config.TraceReporterType.ZIPKIN);
     }
     Builder opaBuilder = applyOpaDefaults(builder.getOpa().toBuilder());
     builder.setOpa(opaBuilder);

javaagent-core/src/test/java/org/hypertrace/agent/core/config/HypertraceConfigTest.java

@@ -40,7 +40,7 @@ public void defaultValues() throws IOException {
     Assertions.assertTrue(agentConfig.getEnabled().getValue());
     Assertions.assertEquals("unknown", agentConfig.getServiceName().getValue());
     Assertions.assertEquals(
-        TraceReporterType.OTLP, agentConfig.getReporting().getTraceReporterType());
+        TraceReporterType.ZIPKIN, agentConfig.getReporting().getTraceReporterType());
     Assertions.assertEquals(
         HypertraceConfig.DEFAULT_REPORTING_ENDPOINT,
         agentConfig.getReporting().getEndpoint().getValue());
@@ -104,7 +104,7 @@ private void assertConfig(AgentConfig agentConfig) {
     Assertions.assertEquals(
         Arrays.asList(PropagationFormat.B3), agentConfig.getPropagationFormatsList());
     Assertions.assertEquals(
-        TraceReporterType.ZIPKIN, agentConfig.getReporting().getTraceReporterType());
+        TraceReporterType.OTLP, agentConfig.getReporting().getTraceReporterType());
     Assertions.assertEquals(
         "http://localhost:9411", agentConfig.getReporting().getEndpoint().getValue());
     Assertions.assertEquals(true, agentConfig.getReporting().getSecure().getValue());

javaagent-core/src/test/resources/config.yaml

@@ -6,7 +6,7 @@ propagationFormats:
 reporting:
   endpoint: http://localhost:9411
   secure: true
-  trace_reporter_type: ZIPKIN
+  trace_reporter_type: OTLP
   opa:
     endpoint: http://opa.localhost:8181/
     pollPeriodSeconds: 12

smoke-tests/src/test/resources/ht-config-all-disabled.yaml

@@ -1,6 +1,7 @@
 service_name: app_under_test
 reporting:
   endpoint: http://localhost:4317
+  trace_reporter_type: OTLP
   secure: true
 data_capture:
   http_headers:

smoke-tests/src/test/resources/ht-config.yaml

@@ -1,3 +1,4 @@
 serviceName: app_under_test
 reporting:
   endpoint: http://localhost:4317
+  trace_reporter_type: OTLP