From 924433bb11bda682bc274d68fa4a5975e7cbbaf1 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 14 Nov 2026 15:52:42 +0000 Subject: [PATCH 1/4] ci: repoint the standards callers to the current owner, relock, drop rust-ci Six workflows that call standards reusables (governance, hypatia-scan, mirror, rust-ci, scorecard, secret-scanner) fail at startup with zero jobs on main. actions.lock records hyperpolymath/standards under its former owner (owner_id 6759885); the repository now belongs to metadatastician (owner_id 297579217, same repo_id 1116521501). With the callers dead, the required check `scan / gitleaks` never reports, so a merge here needs the repository-role bypass. EpistemicTypes.jl had the same defect and the same fix (its PR #20), verified green on its main. Changes: - The five callers that apply now pin metadatastician/standards@8d1a2aa, the commit whose allowlist covers the new owner (cf8f912's does not, which is what failed the Allowlist Preflight in EpistemicTypes.jl). governance.yml passes hypatia-ref 51ab649 explicitly, as the sibling repos do; the default at 8d1a2aa is a different commit. - actions.lock relocked with the estate's scripts/relock-standards-pin.sh (standards main 3e4b57d) and pruned with scripts/prune-stale.sh. - rust-ci.yml is removed: this repository has no Rust (only the template's two repo-init helper scripts), and its reusable would fail on the missing Cargo.toml. Its lock entry is pruned with the file. One hand edit to the lock, stated plainly: the record hyperpolymath/cicd-suite@0da816c... and the nested edge to it are removed. It is a leaf whose ref repeats its own SHA, which the runner rejects (standards#1271) and the estate's sync gate calls malformed; it is on main's untouched lock too. It cannot be repaired here: the estate's tooling accepts only a tag, and hyperpolymath/cicd-suite has no tags at all (both pinned commits are reachable from its main, untagged). The same defect is the likely reason main-estate-audit (a callee using 26 cicd-suite composite actions at that SHA) has zero jobs in every repo with a lock. That needs a tag in cicd-suite, not a change here, so main-estate-audit stays red. Verified locally with the estate scripts: check-lock-sync passes (it fails on main's untouched lock); close-lock --check reports no dangling edges; the 8d1a2aa allowlist reports 0 gaps for the callers; YAML parses. Not verified here: `gh actions-lock --verify-local` and the runs themselves; CI decides. Not changed: tag-keyed lock records (20 pin-contract violations, which governance at 8d1a2aa does not enforce), the canon pin, rulesets and required checks. No .a2ml and no licence or SPDX edits. Co-Authored-By: Claude Sonnet 5.5 Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67 --- .github/workflows/actions.lock | 116 +++++++++++++-------------- .github/workflows/governance.yml | 4 +- .github/workflows/hypatia-scan.yml | 2 +- .github/workflows/mirror.yml | 2 +- .github/workflows/rust-ci.yml | 19 ----- .github/workflows/scorecard.yml | 2 +- .github/workflows/secret-scanner.yml | 2 +- 7 files changed, 64 insertions(+), 83 deletions(-) delete mode 100644 .github/workflows/rust-ci.yml diff --git a/.github/workflows/actions.lock b/.github/workflows/actions.lock index dfb8a14..fbcd5aa 100644 --- a/.github/workflows/actions.lock +++ b/.github/workflows/actions.lock @@ -31,13 +31,13 @@ workflows: '.github/workflows/estate-rules.yml': - 'actions/checkout@v7.0.1' '.github/workflows/governance.yml': - - 'hyperpolymath/standards@da2c748aad55c1a1dcba00b60fe4a35017bc6540' + - 'metadatastician/standards@8d1a2aab4211493cf42f147f2080f024605797dc' '.github/workflows/groove-check.yml': - 'actions/checkout@v7.0.1' '.github/workflows/guix-policy.yml': - 'actions/checkout@v7.0.1' '.github/workflows/hypatia-scan.yml': - - 'hyperpolymath/standards@da2c748aad55c1a1dcba00b60fe4a35017bc6540' + - 'metadatastician/standards@8d1a2aab4211493cf42f147f2080f024605797dc' '.github/workflows/julia-ci.yml': - 'actions/checkout@v7.0.1' - 'julia-actions/cache@v3' @@ -51,7 +51,7 @@ workflows: '.github/workflows/main-estate-audit.yml': - 'hyperpolymath/cicd-suite@55556cf5ba71ba744695861503c13148d3915a5d' '.github/workflows/mirror.yml': - - 'hyperpolymath/standards@da2c748aad55c1a1dcba00b60fe4a35017bc6540' + - 'metadatastician/standards@8d1a2aab4211493cf42f147f2080f024605797dc' '.github/workflows/ossf-best-practices.yml': - 'actions/checkout@v7.0.1' '.github/workflows/pages.yml': @@ -75,12 +75,10 @@ workflows: - 'actions/checkout@v7.0.1' '.github/workflows/runtime-policy.yml': - 'actions/checkout@v7.0.1' - '.github/workflows/rust-ci.yml': - - 'hyperpolymath/standards@da2c748aad55c1a1dcba00b60fe4a35017bc6540' '.github/workflows/scorecard.yml': - - 'hyperpolymath/standards@da2c748aad55c1a1dcba00b60fe4a35017bc6540' + - 'metadatastician/standards@8d1a2aab4211493cf42f147f2080f024605797dc' '.github/workflows/secret-scanner.yml': - - 'hyperpolymath/standards@da2c748aad55c1a1dcba00b60fe4a35017bc6540' + - 'metadatastician/standards@8d1a2aab4211493cf42f147f2080f024605797dc' '.github/workflows/security-policy.yml': - 'actions/checkout@v7.0.1' '.github/workflows/sonarqube.yml': @@ -108,7 +106,7 @@ dependencies: owner_id: 44036562 repo_id: 760701061 'actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9': - ref: '55cc8345863c7cc4c66a329aec7e433d2d1c52a9' + ref: 'v6.1.0' commit: 'sha1-55cc8345863c7cc4c66a329aec7e433d2d1c52a9' owner_id: 44036562 repo_id: 215566462 @@ -118,7 +116,7 @@ dependencies: owner_id: 44036562 repo_id: 215566462 'actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1': - ref: '3d3c42e5aac5ba805825da76410c181273ba90b1' + ref: 'v7.0.1' commit: 'sha1-3d3c42e5aac5ba805825da76410c181273ba90b1' owner_id: 44036562 repo_id: 197814629 @@ -137,21 +135,26 @@ dependencies: commit: 'sha1-368f82528645a54fb793d4d04e342629a3f51346' owner_id: 44036562 repo_id: 438112499 - 'actions/download-artifact@v8.0.2': + 'actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333': ref: 'v8.0.2' commit: 'sha1-9000827ccba6bdab643e8b6fd33ac0654aef8333' owner_id: 44036562 repo_id: 192626254 - 'actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a': - ref: '043fb46d1a93c77aae656e7c1c64a875d1fc6a0a' - commit: 'sha1-043fb46d1a93c77aae656e7c1c64a875d1fc6a0a' + 'actions/download-artifact@v8.0.2': + ref: 'v8.0.2' + commit: 'sha1-9000827ccba6bdab643e8b6fd33ac0654aef8333' owner_id: 44036562 - repo_id: 192625955 + repo_id: 192626254 'actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f': ref: 'v7.0.0' commit: 'sha1-bbbca2ddaa5d8feaa63e36b76fdaad77386f024f' owner_id: 44036562 repo_id: 192625955 + 'actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9': + ref: 'v7.0.2' + commit: 'sha1-cf430e030ddbb5b0abf93d22962f4752f3646cd9' + owner_id: 44036562 + repo_id: 192625955 'actions/upload-artifact@v7.0.2': ref: 'v7.0.2' commit: 'sha1-cf430e030ddbb5b0abf93d22962f4752f3646cd9' @@ -164,18 +167,23 @@ dependencies: repo_id: 496012378 uses: - 'actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f' + 'denoland/setup-deno@22d081ff2d3a40755e97629de92e3bcbfa7cf2ed': + ref: 'v2.0.5' + commit: 'sha1-22d081ff2d3a40755e97629de92e3bcbfa7cf2ed' + owner_id: 42048915 + repo_id: 356423100 'dependabot/fetch-metadata@v3.1.0': ref: 'v3.1.0' commit: 'sha1-25dd0e34f4fe68f24cc83900b1fe3fe149efef98' owner_id: 27347476 repo_id: 371068214 - 'dtolnay/rust-toolchain@6c977a6ca4077a0ceb28ffbe03f59d46e9ac8772': - ref: '6c977a6ca4077a0ceb28ffbe03f59d46e9ac8772' - commit: 'sha1-6c977a6ca4077a0ceb28ffbe03f59d46e9ac8772' + 'dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8': + ref: 'v1' + commit: 'sha1-683b588c487a69d01f6c6ddf40f036ff682cc2c8' owner_id: 1940490 repo_id: 260749683 'editorconfig-checker/action-editorconfig-checker@51f63319f592f97930c73d9c46184d20bd206393': - ref: '51f63319f592f97930c73d9c46184d20bd206393' + ref: 'v3.0.0' commit: 'sha1-51f63319f592f97930c73d9c46184d20bd206393' owner_id: 26415196 repo_id: 297874902 @@ -185,7 +193,7 @@ dependencies: owner_id: 26415196 repo_id: 297874902 'erlef/setup-beam@54075bcc5e249e4758d363f27d099f55d843f124': - ref: '54075bcc5e249e4758d363f27d099f55d843f124' + ref: 'v1.24.1' commit: 'sha1-54075bcc5e249e4758d363f27d099f55d843f124' owner_id: 47606891 repo_id: 331103973 @@ -199,26 +207,16 @@ dependencies: commit: 'sha1-33d7b85da1a04171e211befe2c739303b9a4c066' owner_id: 9919 repo_id: 259445878 - 'github/codeql-action@cdf488f595d80d6e07e03d4674febd5ab45fa938': - ref: 'cdf488f595d80d6e07e03d4674febd5ab45fa938' - commit: 'sha1-cdf488f595d80d6e07e03d4674febd5ab45fa938' + 'github/codeql-action@b96794f015dfd88f77b49b1c93e0fa7110f94c63': + ref: 'v4.38.0' + commit: 'sha1-b96794f015dfd88f77b49b1c93e0fa7110f94c63' owner_id: 9919 repo_id: 259445878 - 'goto-bus-stop/setup-zig@abea47f85e598557f500fa1fd2ab7464fcb39406': - ref: 'abea47f85e598557f500fa1fd2ab7464fcb39406' - commit: 'sha1-abea47f85e598557f500fa1fd2ab7464fcb39406' - owner_id: 1006268 - repo_id: 212984112 'haskell-actions/setup@v2.12.1': ref: 'v2.12.1' commit: 'sha1-0f8e8c99d88aeb3fbfd523f1ef2c6f762d10d64d' owner_id: 75048950 repo_id: 623796603 - 'hyperpolymath/cicd-suite@0da816c05ae7486671d863e07935f93981c0c2d5': - ref: '0da816c05ae7486671d863e07935f93981c0c2d5' - commit: 'sha1-0da816c05ae7486671d863e07935f93981c0c2d5' - owner_id: 6759885 - repo_id: 1326697643 'hyperpolymath/cicd-suite@55556cf5ba71ba744695861503c13148d3915a5d': ref: '55556cf5ba71ba744695861503c13148d3915a5d' commit: 'sha1-55556cf5ba71ba744695861503c13148d3915a5d' @@ -226,7 +224,6 @@ dependencies: repo_id: 1326697643 uses: - 'actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1' - - 'hyperpolymath/cicd-suite@0da816c05ae7486671d863e07935f93981c0c2d5' 'hyperpolymath/deed-ecosystem@main': ref: 'main' commit: 'sha1-44f9c9fc42901a55e0f489a40eabf4173e550d1d' @@ -242,23 +239,6 @@ dependencies: commit: 'sha1-e384daf6167a7a7567642d6a62060106244d2413' owner_id: 6759885 repo_id: 1352485172 - 'hyperpolymath/standards@da2c748aad55c1a1dcba00b60fe4a35017bc6540': - ref: 'da2c748aad55c1a1dcba00b60fe4a35017bc6540' - commit: 'sha1-da2c748aad55c1a1dcba00b60fe4a35017bc6540' - owner_id: 6759885 - repo_id: 1116521501 - uses: - - 'actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9' - - 'actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1' - - 'actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a' - - 'dtolnay/rust-toolchain@6c977a6ca4077a0ceb28ffbe03f59d46e9ac8772' - - 'editorconfig-checker/action-editorconfig-checker@51f63319f592f97930c73d9c46184d20bd206393' - - 'erlef/setup-beam@54075bcc5e249e4758d363f27d099f55d843f124' - - 'github/codeql-action@cdf488f595d80d6e07e03d4674febd5ab45fa938' - - 'goto-bus-stop/setup-zig@abea47f85e598557f500fa1fd2ab7464fcb39406' - - 'ossf/scorecard-action@2d1146689b8cda280b9bc96326124645441f03bc' - - 'swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6' - - 'webfactory/ssh-agent@e83874834305fe9a4a2997156cb26c5de65a8555' 'julia-actions/cache@v3': ref: 'v3' commit: 'sha1-9353db09a0f2bbbdec6f41791918c75d37391b36' @@ -269,11 +249,34 @@ dependencies: commit: 'sha1-da908477b5db94c10ffce8cfea9f2b3b9d5db687' owner_id: 53965732 repo_id: 202020219 - 'ossf/scorecard-action@2d1146689b8cda280b9bc96326124645441f03bc': - ref: '2d1146689b8cda280b9bc96326124645441f03bc' - commit: 'sha1-2d1146689b8cda280b9bc96326124645441f03bc' + 'metadatastician/standards@8d1a2aab4211493cf42f147f2080f024605797dc': + ref: '8d1a2aab4211493cf42f147f2080f024605797dc' + commit: 'sha1-8d1a2aab4211493cf42f147f2080f024605797dc' + owner_id: 297579217 + repo_id: 1116521501 + uses: + - 'actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9' + - 'actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1' + - 'actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333' + - 'actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9' + - 'denoland/setup-deno@22d081ff2d3a40755e97629de92e3bcbfa7cf2ed' + - 'dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8' + - 'editorconfig-checker/action-editorconfig-checker@51f63319f592f97930c73d9c46184d20bd206393' + - 'erlef/setup-beam@54075bcc5e249e4758d363f27d099f55d843f124' + - 'github/codeql-action@b96794f015dfd88f77b49b1c93e0fa7110f94c63' + - 'ossf/scorecard-action@fa7117db83c52d787ae5a89f350999701505d78e' + - 'oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6' + - 'webfactory/ssh-agent@e83874834305fe9a4a2997156cb26c5de65a8555' + 'ossf/scorecard-action@fa7117db83c52d787ae5a89f350999701505d78e': + ref: 'v2.5.0' + commit: 'sha1-fa7117db83c52d787ae5a89f350999701505d78e' owner_id: 67707773 repo_id: 421101922 + 'oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6': + ref: 'v2.2.0' + commit: 'sha1-0c5077e51419868618aeaa5fe8019c62421857d6' + owner_id: 108928776 + repo_id: 512644635 'oven-sh/setup-bun@v2.2.0': ref: 'v2.2.0' commit: 'sha1-0c5077e51419868618aeaa5fe8019c62421857d6' @@ -289,13 +292,8 @@ dependencies: commit: 'sha1-e805d875275f728fac1885b413934be6d7c63f65' owner_id: 545988 repo_id: 366408409 - 'swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6': - ref: '6323deb102c322ba6fcbdcafc7e3dddab59af2b6' - commit: 'sha1-6323deb102c322ba6fcbdcafc7e3dddab59af2b6' - owner_id: 580492 - repo_id: 298565987 'webfactory/ssh-agent@e83874834305fe9a4a2997156cb26c5de65a8555': - ref: 'e83874834305fe9a4a2997156cb26c5de65a8555' + ref: 'v0.10.0' commit: 'sha1-e83874834305fe9a4a2997156cb26c5de65a8555' owner_id: 135788 repo_id: 208510314 diff --git a/.github/workflows/governance.yml b/.github/workflows/governance.yml index 73366ea..f1ea864 100644 --- a/.github/workflows/governance.yml +++ b/.github/workflows/governance.yml @@ -18,4 +18,6 @@ permissions: jobs: governance: - uses: hyperpolymath/standards/.github/workflows/governance-reusable.yml@da2c748aad55c1a1dcba00b60fe4a35017bc6540 + uses: metadatastician/standards/.github/workflows/governance-reusable.yml@8d1a2aab4211493cf42f147f2080f024605797dc + with: + hypatia-ref: 51ab6496bf47e30a0576d503df31fec30f3cfe56 diff --git a/.github/workflows/hypatia-scan.yml b/.github/workflows/hypatia-scan.yml index 0677694..9b2de56 100644 --- a/.github/workflows/hypatia-scan.yml +++ b/.github/workflows/hypatia-scan.yml @@ -32,5 +32,5 @@ jobs: # failure: the reusable still clones hypatia@HEAD and runs mix escript.build. # That class of red is estate-wide (hypatia#863 broke HEAD on 2026-09-26) # and is not a consumer finding. See docs/status/HYPATIA-GATE.adoc. - uses: hyperpolymath/standards/.github/workflows/hypatia-scan-reusable.yml@da2c748aad55c1a1dcba00b60fe4a35017bc6540 + uses: metadatastician/standards/.github/workflows/hypatia-scan-reusable.yml@8d1a2aab4211493cf42f147f2080f024605797dc secrets: inherit diff --git a/.github/workflows/mirror.yml b/.github/workflows/mirror.yml index 35c5683..a40531c 100644 --- a/.github/workflows/mirror.yml +++ b/.github/workflows/mirror.yml @@ -13,7 +13,7 @@ permissions: contents: read jobs: mirror: - uses: hyperpolymath/standards/.github/workflows/mirror-reusable.yml@da2c748aad55c1a1dcba00b60fe4a35017bc6540 + uses: metadatastician/standards/.github/workflows/mirror-reusable.yml@8d1a2aab4211493cf42f147f2080f024605797dc # Explicit secrets map — no `secrets: inherit` (Hypatia WH008, alert #131). # All seven are the callee's complete optional contract (standards # mirror-reusable.yml@da2c748); behaviour is unchanged, future secrets diff --git a/.github/workflows/rust-ci.yml b/.github/workflows/rust-ci.yml deleted file mode 100644 index 05369dd..0000000 --- a/.github/workflows/rust-ci.yml +++ /dev/null @@ -1,19 +0,0 @@ -# This workflow is managed by gh actions-lock. -# SPDX-License-Identifier: MPL-2.0 -# Rust CI — thin wrapper calling the shared estate reusable in -# hyperpolymath/standards. Configure once, propagate everywhere. -# See: docs/CI-REUSABLE-WORKFLOWS.adoc in standards. -name: Rust CI -on: - push: - branches: [main, master] - pull_request: -concurrency: - group: ${{ github.workflow }}-${{ github.ref }} - cancel-in-progress: true -permissions: - actions: read - contents: read -jobs: - rust-ci: - uses: hyperpolymath/standards/.github/workflows/rust-ci-reusable.yml@da2c748aad55c1a1dcba00b60fe4a35017bc6540 diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index f2ce703..dd8e7c4 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -16,7 +16,7 @@ permissions: jobs: scorecard: - uses: hyperpolymath/standards/.github/workflows/scorecard-reusable.yml@da2c748aad55c1a1dcba00b60fe4a35017bc6540 + uses: metadatastician/standards/.github/workflows/scorecard-reusable.yml@8d1a2aab4211493cf42f147f2080f024605797dc # Reusable called-workflow permissions are CAPPED by the caller's grants; # without security-events: write here the scorecard SARIF upload fails with # startup_failure (hypatia WF018). id-token: write enables OIDC publish. diff --git a/.github/workflows/secret-scanner.yml b/.github/workflows/secret-scanner.yml index 9a7b136..32bf0fb 100644 --- a/.github/workflows/secret-scanner.yml +++ b/.github/workflows/secret-scanner.yml @@ -26,4 +26,4 @@ jobs: # is therefore the cap GitHub applies to the called workflow. permissions: contents: read - uses: hyperpolymath/standards/.github/workflows/secret-scanner-reusable.yml@da2c748aad55c1a1dcba00b60fe4a35017bc6540 + uses: metadatastician/standards/.github/workflows/secret-scanner-reusable.yml@8d1a2aab4211493cf42f147f2080f024605797dc From 3ffd0f274d83bdfaa49b29bf13db80df99c0512e Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 14 Nov 2026 16:02:18 +0000 Subject: [PATCH 2/4] ci: grant actions:read to scorecard job; pass R2 secrets to mirror reusable Both are callee contracts at the pinned standards revision: scorecard-reusable requires actions: read on the calling job (a job-level block replaces the workflow-level one), and mirror-reusable declares three R2 secrets that the explicit map did not forward. Co-Authored-By: Claude Sonnet 5.5 Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67 --- .github/workflows/mirror.yml | 7 +++++-- .github/workflows/scorecard.yml | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/mirror.yml b/.github/workflows/mirror.yml index a40531c..a2d92d3 100644 --- a/.github/workflows/mirror.yml +++ b/.github/workflows/mirror.yml @@ -15,8 +15,8 @@ jobs: mirror: uses: metadatastician/standards/.github/workflows/mirror-reusable.yml@8d1a2aab4211493cf42f147f2080f024605797dc # Explicit secrets map — no `secrets: inherit` (Hypatia WH008, alert #131). - # All seven are the callee's complete optional contract (standards - # mirror-reusable.yml@da2c748); behaviour is unchanged, future secrets + # All ten are the callee's complete optional contract (standards + # mirror-reusable.yml@8d1a2aa); behaviour is unchanged, future secrets # are no longer shared implicitly. secrets: GITLAB_SSH_KEY: ${{ secrets.GITLAB_SSH_KEY }} @@ -26,3 +26,6 @@ jobs: DISROOT_SSH_KEY: ${{ secrets.DISROOT_SSH_KEY }} GITEA_SSH_KEY: ${{ secrets.GITEA_SSH_KEY }} RADICLE_KEY: ${{ secrets.RADICLE_KEY }} + R2_ACCESS_KEY_ID: ${{ secrets.R2_ACCESS_KEY_ID }} + R2_SECRET_ACCESS_KEY: ${{ secrets.R2_SECRET_ACCESS_KEY }} + R2_AGE_RECIPIENT: ${{ secrets.R2_AGE_RECIPIENT }} diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index dd8e7c4..f4a54b1 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -21,6 +21,7 @@ jobs: # without security-events: write here the scorecard SARIF upload fails with # startup_failure (hypatia WF018). id-token: write enables OIDC publish. permissions: + actions: read contents: read security-events: write id-token: write From 59300676b9ea25c5c652513118b8f2cf64b5c74a Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 14 Nov 2026 16:03:13 +0000 Subject: [PATCH 3/4] ci: pass only HYPATIA_SCAN_PAT to the hypatia reusable (drop secrets: inherit) The reusable at the pinned standards revision declares HYPATIA_SCAN_PAT as its only secret. Sonar S7635 flagged the blanket inherit, which failed the quality gate (C security rating on new code). Co-Authored-By: Claude Sonnet 5.5 Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67 --- .github/workflows/hypatia-scan.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/hypatia-scan.yml b/.github/workflows/hypatia-scan.yml index 9b2de56..8eaee98 100644 --- a/.github/workflows/hypatia-scan.yml +++ b/.github/workflows/hypatia-scan.yml @@ -27,10 +27,12 @@ permissions: jobs: hypatia: - # secrets: inherit is required so HYPATIA_SCAN_PAT (org) reaches the - # reusable. It does not, and cannot, cure a Hypatia *scanner build* + # Only HYPATIA_SCAN_PAT (org) is passed: the reusable declares it as its + # sole secret (standards#1108 6b), and `secrets: inherit` forwarded every + # caller secret (Sonar S7635). Passing it does not, and cannot, cure a Hypatia *scanner build* # failure: the reusable still clones hypatia@HEAD and runs mix escript.build. # That class of red is estate-wide (hypatia#863 broke HEAD on 2026-09-26) # and is not a consumer finding. See docs/status/HYPATIA-GATE.adoc. uses: metadatastician/standards/.github/workflows/hypatia-scan-reusable.yml@8d1a2aab4211493cf42f147f2080f024605797dc - secrets: inherit + secrets: + HYPATIA_SCAN_PAT: ${{ secrets.HYPATIA_SCAN_PAT }} From 7a866650c328d1d3335cfb792ff7515adc0ec73d Mon Sep 17 00:00:00 2001 From: "Jonathan D.A. Jewell" <6759885+hyperpolymath@users.noreply.github.com> Date: Sat, 14 Nov 2026 17:52:14 +0000 Subject: [PATCH 4/4] ci: fix the Julia CI Format and JET steps, floor Julia at 1.10, format the code (#14) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary Stacked on #13 (base `ci/relock-standards-owner`), so its CI runs with the lock fix in place. Retarget to `main` when #13 merges. Julia CI has never exercised this package on `main`: the Format and JET steps crash before checking anything, and the 1.9 leg cannot start. Per the owner's rule, each red was classified and fixed at its root: **a correct check means the code is fixed, an incorrect check means the CI is fixed.** | Red check on `main` | Verdict | Fix | |---|---|---| | `Test (Test + Aqua) (1)` | **correct**: `UndefVarError: WarrantOnly` is a real hole (the enum instances were never exported) | export the four instances (cherry-picked from #12, same one-line change) | | `Format (JuliaFormatter)` | **both**: the step is broken (3 defects) *and*, once it runs, 7 files are genuinely unformatted | fix the step; format the 7 files | | `Static analysis (JET)` | **incorrect**: `test_package(path=, julia_version=)` matches no method | pass the package module | | `Test (…) (1.9)` | **incorrect**: `setup-julia` installs 1.9.4 and the runner cannot load its `libopenlibm.so`, before any test | owner chose a 1.10 LTS floor: matrix leg and `compat julia` both 1.10 | ## Changes - `julia-ci.yml` Format step: `filter` over an uncollected `Iterators.Flatten` (a `MethodError`) now collects; `format_string` (not in JuliaFormatter 2) is `format_text`; and it read every file in `src/`, including `src/README.adoc`, on which `format_text` throws a `ParseError`, so only `*.jl` files are checked. The third defect was found by running the step locally past the first two. - `julia-ci.yml` JET step: the package module is the argument. - Julia floor: matrix `["1.10", "1"]`, `compat julia = "1.10"`. **Breaking** for Julia 1.9 users; recorded in the changelog. - Seven files formatted (`src/Choreography.jl`, `src/CoprocessorRuntime.jl`, `src/Nullity.jl`, `src/Receipts.jl`, `src/Sessions.jl`, `test/cases/receipts.jl`, `test/cases/sessions.jl`). Formatting only, and checked: each file's old and new text were parsed, line numbers stripped, and the syntax trees compared. All seven are identical, so no behaviour changes. - `Knowledge`, `Belief`, `WarrantOnly`, `Unsound` exported (the hole fix). - Not changed: licences and SPDX headers, `.a2ml` files, rulesets and required checks. ## RSR Quality Checklist ### Required - [x] Tests pass: 46 of 46 locally on Julia 1.11.5 **and** on Julia 1.10.10 (the new floor); CI decides - [x] Code is formatted: the workflow's Format step, extracted and run as written, exits 0 - [x] No banned language patterns - [x] SPDX license headers unchanged - [x] No secrets, credentials, or `.env` files included ### As Applicable - [x] `CHANGELOG` updated, including the breaking floor change ## Testing - Format step (as written in the workflow): exit 0. - `JET.test_package(CoprocessorRuntime)` with JET 0.9.20 on Julia 1.11.5: no finding. **Not verified:** JET on the newest Julia, which is what CI runs. - `Pkg.test()`: 46 of 46 on Julia 1.11.5 and on 1.10.10 (clean manifests, isolated depot for 1.10). ## Known reds that this PR does not and cannot fix `Canon lockstep` (stale canon pin; the re-pin edits retired `.a2ml`), `estate-rules` (the template's root allowlist does not fit a Julia package), `openssf-compliance` (`{{PROJECT_NAME}}` unfilled in `CITATION.cff`) and `main-estate-audit` (needs a tag in `hyperpolymath/cicd-suite`; see #13). Each is its own topic. --- _Generated by [Claude Code](https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67)_ --------- Co-authored-by: Claude --- .github/workflows/julia-ci.yml | 11 ++--- .machine_readable/ai/PLACEHOLDERS.adoc | 2 +- CHANGELOG.adoc | 35 ++++++++++++++- Project.toml | 2 +- docs/onboarding/QUICKSTART-DEV.adoc | 4 +- src/Choreography.jl | 31 ++++++++------ src/CoprocessorRuntime.jl | 59 ++++++++++++++++++++------ src/Nullity.jl | 16 ++++++- src/Receipts.jl | 14 +++--- src/Sessions.jl | 4 +- test/cases/receipts.jl | 18 ++++---- test/cases/sessions.jl | 2 +- 12 files changed, 140 insertions(+), 58 deletions(-) diff --git a/.github/workflows/julia-ci.yml b/.github/workflows/julia-ci.yml index ae61014..2d46def 100644 --- a/.github/workflows/julia-ci.yml +++ b/.github/workflows/julia-ci.yml @@ -38,13 +38,13 @@ jobs: using Pkg Pkg.add("JuliaFormatter") using JuliaFormatter - for f in filter(isfile, Iterators.flatten(( + for f in filter(f -> isfile(f) && endswith(f, ".jl"), collect(Iterators.flatten(( [joinpath("src", x) for x in readdir("src")], [joinpath("test", x) for x in readdir("test") if x != "cases"], [joinpath("test", "cases", x) for x in readdir(joinpath("test", "cases"))], - ))) + )))) text = read(f, String) - formatted = JuliaFormatter.format_string(text) + formatted = JuliaFormatter.format_text(text) if text != formatted @error "not formatted" file=f exit(1) @@ -66,7 +66,8 @@ jobs: using Pkg Pkg.add("JET") using JET - JET.test_package(path=".", julia_version="1")' + using CoprocessorRuntime + JET.test_package(CoprocessorRuntime)' test: name: Test (Test + Aqua) @@ -74,7 +75,7 @@ jobs: strategy: fail-fast: false matrix: - julia: ["1.9", "1"] + julia: ["1.10", "1"] os: [ubuntu-latest] steps: - uses: actions/checkout@v7.0.1 diff --git a/.machine_readable/ai/PLACEHOLDERS.adoc b/.machine_readable/ai/PLACEHOLDERS.adoc index 4d3ad24..f629f73 100644 --- a/.machine_readable/ai/PLACEHOLDERS.adoc +++ b/.machine_readable/ai/PLACEHOLDERS.adoc @@ -104,7 +104,7 @@ surfaces any left unfilled. |---|---|---|---| | `CoprocessorRuntime` | Package / module name (slug) | `my-project` | docs/onboarding/QUICKSTART-MAINTAINER.adoc | | `{{DESCRIPTION}}` | Short repo description (forge metadata) | `A tool for X` | .github/settings.yml | -| `Julia (1.9+)` | Language / toolchain stack | `Idris2 + Zig` | docs/onboarding/QUICKSTART-DEV.adoc | +| `Julia (1.10+)` | Language / toolchain stack | `Idris2 + Zig` | docs/onboarding/QUICKSTART-DEV.adoc | | `julia --project=. -e 'using Pkg; Pkg.instantiate()'` | Build command | `just build` | docs/onboarding/QUICKSTART-DEV.adoc | | `julia --project=. -e 'using Pkg; Pkg.test()'` | Test command | `just test` | docs/onboarding/QUICKSTART-DEV.adoc | | `src/` | Build artefact output path | `build/` | docs/onboarding/QUICKSTART-MAINTAINER.adoc | diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc index f8cd86a..1731059 100644 --- a/CHANGELOG.adoc +++ b/CHANGELOG.adoc @@ -20,16 +20,41 @@ https://semver.org/spec/v2.0.0.html[Semantic Versioning]. (Hyperpolymath.jl cannot be pushed from this session). * `docs/status/HYPATIA-GATE.adoc` — why the CodeRabbit compare has no merge-base, and which CI reds this tree can actually fix. -* `.github/workflows/julia-ci.yml` (format / JET / Test+Aqua on 1.9 and 1). +* `.github/workflows/julia-ci.yml` (format / JET / Test+Aqua on 1.10 and 1). + +==== Changed + +* *Breaking:* the minimum Julia is now 1.10 (`julia = "1.10"` in `[compat]`), + and CI's oldest leg is 1.10. The 1.9 leg could not run: `setup-julia` + installed 1.9.4 and the runner could not load its `libopenlibm.so`, so the + leg failed before any test and the repository claimed a version CI never + tested. + +* `docs/onboarding/QUICKSTART-DEV.adoc` states Julia 1.10+, matching the floor. ==== Fixed +* `julia-ci.yml` Format step: it called `filter` over an uncollected + `Iterators.Flatten` (a `MethodError`), used `format_string` (not in + JuliaFormatter 2), and read every file in `src/`, including + `src/README.adoc`, which is not Julia. It now collects the list, uses + `format_text`, and checks only `*.jl` files. +* `ONDClaim` and `LaunchPlan` now have typed inner constructors. The default + ones accepted `Any` and converted to the field types, which JET 0.13 on Julia + 1.13 reported as five possible errors (`convert` into `Vector{Symbol}` and + `Vector{Endpoint}`), so the JET job was red on the "1" runner. Callers that + already pass the declared types (`observe_null`, `launch_plan`, the tests) + are unaffected; a direct call with a different vector type, such as + `Vector{Any}`, is now a `MethodError` at the call instead of a conversion. +* `julia-ci.yml` JET step: it passed `path=` and `julia_version=`, which + `JET.test_package` does not take; it now passes the package module. +* Seven files that JuliaFormatter flagged are formatted (the syntax tree of + each is identical before and after). * `.github/dependabot.yml` listed cargo, mix, npm and pip, none of which this repository has a manifest for, so every weekly Dependabot run for them failed (8 of the last 10 dynamic runs). Those four are removed and the `julia` ecosystem is added for `Project.toml`; the `github-actions` entry and its codeql-action hold are unchanged. - * Reverted Dependabot's `codeql-action` 4.38.1 pin to v4.38.0 (`b96794f`), which is what `actions.lock` already recorded. 4.38.1 is blocked estate-wide (nexia-list#100) and was the `startup_failure` on @@ -37,6 +62,12 @@ https://semver.org/spec/v2.0.0.html[Semantic Versioning]. * Reverted `haskell-actions/setup` v2.12.1 → v2.12.0 to match the lock. * Hypatia caller now passes `secrets: inherit`. This does not cure a hypatia@HEAD build failure (estate-wide after hypatia#863). +* `Knowledge`, `Belief`, `WarrantOnly` and `Unsound` are now exported. The + README, the wiring doc and the receipts tests all write + `warrant=WarrantOnly` unqualified, but only the enum type `WarrantKind` + was exported, so `Pkg.test()` failed with + `UndefVarError: WarrantOnly not defined` (42 passed, 1 errored; now 46 + of 46 pass). ==== Inherited from template diff --git a/Project.toml b/Project.toml index d480432..b6c2882 100644 --- a/Project.toml +++ b/Project.toml @@ -22,6 +22,6 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" test = ["Test", "Aqua"] [compat] -julia = "1.9" +julia = "1.10" Test = "1.9" Aqua = "0.8" diff --git a/docs/onboarding/QUICKSTART-DEV.adoc b/docs/onboarding/QUICKSTART-DEV.adoc index e7a75c1..33918d6 100644 --- a/docs/onboarding/QUICKSTART-DEV.adoc +++ b/docs/onboarding/QUICKSTART-DEV.adoc @@ -1,14 +1,14 @@ // SPDX-License-Identifier: CC-BY-SA-4.0 // Copyright (c) Jonathan D.A. Jewell // Template: QUICKSTART-DEV.adoc — clone → build → test → PR -// Replace rsr-template-repo, julia --project=. -e 'using Pkg; Pkg.instantiate()', julia --project=. -e 'using Pkg; Pkg.test()', Julia (1.9+) with actuals +// Replace rsr-template-repo, julia --project=. -e 'using Pkg; Pkg.instantiate()', julia --project=. -e 'using Pkg; Pkg.test()', Julia (1.10+) with actuals = rsr-template-repo — Quick Start for Developers :toc: :toclevels: 2 == Tech Stack -Julia (1.9+) +Julia (1.10+) == Set Up Development Environment diff --git a/src/Choreography.jl b/src/Choreography.jl index 0a171e3..11bb937 100644 --- a/src/Choreography.jl +++ b/src/Choreography.jl @@ -27,6 +27,17 @@ struct LaunchPlan endpoints::Vector{Endpoint} grade::ResourceGrade loss::EchoResidue + + # Typed inner constructor (see `ONDClaim`): ill-typed input is rejected + # at the boundary instead of deep inside `convert`. + function LaunchPlan( + global_name::Symbol, + endpoints::Vector{Endpoint}, + grade::ResourceGrade, + loss::EchoResidue, + ) + new(global_name, endpoints, grade, loss) + end end function launch_plan( @@ -51,13 +62,13 @@ function project(plan::LaunchPlan, role::Role) local_eps = Endpoint[e for e in plan.endpoints if typeof(e.role) === typeof(role)] injective = plan.loss.map.injective ( - role=role, - endpoints=local_eps, - grade=plan.grade, - loss=plan.loss, - grade_eq=injective, - warrant_bound=injective ? :degenerate_base : :open, - kcut=:open, + role = role, + endpoints = local_eps, + grade = plan.grade, + loss = plan.loss, + grade_eq = injective, + warrant_bound = injective ? :degenerate_base : :open, + kcut = :open, ) end @@ -89,9 +100,5 @@ protocol would be the Protocol Squisher claim that `hub_ceiling` refutes. Callers who need a backend use AcceleratorGate selection, not a hub. """ function universal_hub_allowed() - throw( - HubCeilingRefusal( - "hub_ceiling: no universal coprocessor adapter", - ), - ) + throw(HubCeilingRefusal("hub_ceiling: no universal coprocessor adapter")) end diff --git a/src/CoprocessorRuntime.jl b/src/CoprocessorRuntime.jl index 5dc609e..077b59c 100644 --- a/src/CoprocessorRuntime.jl +++ b/src/CoprocessorRuntime.jl @@ -37,18 +37,53 @@ close_session!(s) """ module CoprocessorRuntime -export Role, HostRole, DeviceRole, - CoprocessorKind, CPUKind, GPUKind, NPUKind, TPUKind, FPGAKind, QPUKind, - DSPKind, UnknownKind, - Session, open_session, close_session!, isopen, - ResourceGrade, tropical_alt, tropical_seq, dominates, - TransferMap, EchoResidue, injective_transfer, collapsing_transfer, - WarrantKind, LaunchReceipt, issue_receipt, host_may_claim, - CNOClaim, ONDClaim, reset_session!, observe_null, - InverseMeta, inversion_of, irreversible, - Endpoint, LaunchPlan, launch_plan, project, projected_grade, - universal_hub_allowed, HubCeilingRefusal, - kind_label +export Role, + HostRole, + DeviceRole, + CoprocessorKind, + CPUKind, + GPUKind, + NPUKind, + TPUKind, + FPGAKind, + QPUKind, + DSPKind, + UnknownKind, + Session, + open_session, + close_session!, + isopen, + ResourceGrade, + tropical_alt, + tropical_seq, + dominates, + TransferMap, + EchoResidue, + injective_transfer, + collapsing_transfer, + WarrantKind, + Knowledge, + Belief, + WarrantOnly, + Unsound, + LaunchReceipt, + issue_receipt, + host_may_claim, + CNOClaim, + ONDClaim, + reset_session!, + observe_null, + InverseMeta, + inversion_of, + irreversible, + Endpoint, + LaunchPlan, + launch_plan, + project, + projected_grade, + universal_hub_allowed, + HubCeilingRefusal, + kind_label include("Kinds.jl") include("Grades.jl") diff --git a/src/Nullity.jl b/src/Nullity.jl index ffe5f6e..10884d0 100644 --- a/src/Nullity.jl +++ b/src/Nullity.jl @@ -33,6 +33,18 @@ struct ONDClaim observer::Symbol residue::Vector{Symbol} status::Symbol + + # Typed inner constructor: the default one accepts `Any` and converts to + # the field types, which lets ill-typed input fail deep inside `Base` + # (and JET report five "possible errors" through `convert`). + function ONDClaim( + secret_region::Symbol, + observer::Symbol, + residue::Vector{Symbol}, + status::Symbol, + ) + new(secret_region, observer, residue, status) + end end """ @@ -74,8 +86,8 @@ Construct an OND claim. Callers must list out-of-scope observables in function observe_null( secret::Symbol, observer::Symbol; - residue::Vector{Symbol}=Symbol[], - status::Symbol=:unproved, + residue::Vector{Symbol} = Symbol[], + status::Symbol = :unproved, ) status in (:unproved, :model_checked) || throw(ArgumentError("OND status must be :unproved or :model_checked, got $status")) diff --git a/src/Receipts.jl b/src/Receipts.jl index 2a2b575..3045847 100644 --- a/src/Receipts.jl +++ b/src/Receipts.jl @@ -30,18 +30,14 @@ end function issue_receipt( session::Session; - standpoint::Symbol=:host, - warrant::WarrantKind=WarrantOnly, - claim::AbstractString="", - sound::Bool=false, + standpoint::Symbol = :host, + warrant::WarrantKind = WarrantOnly, + claim::AbstractString = "", + sound::Bool = false, ) isopen(session) || throw(ArgumentError("session $(session.id) is closed")) if standpoint === :device && warrant === Knowledge && !sound - throw( - ArgumentError( - "device Knowledge without a soundness check is smuggling", - ), - ) + throw(ArgumentError("device Knowledge without a soundness check is smuggling")) end LaunchReceipt(session.id, standpoint, warrant, String(claim), sound) end diff --git a/src/Sessions.jl b/src/Sessions.jl index 25e1f5f..342087d 100644 --- a/src/Sessions.jl +++ b/src/Sessions.jl @@ -9,7 +9,7 @@ const _session_counter = Ref{UInt64}(UInt64(0)) An opened coprocessor session. Opening a session does not allocate device memory and does not prove the device exists. It is a host-side handle. """ -mutable struct Session{K <: CoprocessorKind} +mutable struct Session{K<:CoprocessorKind} id::UInt64 kind::K role::Role @@ -24,7 +24,7 @@ Base.isopen(s::Session) = s.open Mint a host-side session handle. `role` is this endpoint's choreographic projection (almost always `HostRole` in Julia). """ -function open_session(kind::K; role::Role=HostRole()) where {K <: CoprocessorKind} +function open_session(kind::K; role::Role = HostRole()) where {K<:CoprocessorKind} _session_counter[] += UInt64(1) Session{K}(_session_counter[], kind, role, true) end diff --git a/test/cases/receipts.jl b/test/cases/receipts.jl index bbfd77e..133b5f2 100644 --- a/test/cases/receipts.jl +++ b/test/cases/receipts.jl @@ -3,22 +3,22 @@ @testset "epistemic receipts" begin s = open_session(NPUKind()) - r = issue_receipt(s; warrant=WarrantOnly, claim="kernel returned") + r = issue_receipt(s; warrant = WarrantOnly, claim = "kernel returned") @test !host_may_claim(r) fact = issue_receipt( s; - standpoint=:host, - warrant=Knowledge, - claim="host saw flag", - sound=true, + standpoint = :host, + warrant = Knowledge, + claim = "host saw flag", + sound = true, ) @test host_may_claim(fact) @test_throws ArgumentError issue_receipt( s; - standpoint=:device, - warrant=Knowledge, - claim="smuggled", - sound=false, + standpoint = :device, + warrant = Knowledge, + claim = "smuggled", + sound = false, ) close_session!(s) @test_throws ArgumentError issue_receipt(s) diff --git a/test/cases/sessions.jl b/test/cases/sessions.jl index f646e4e..ac44159 100644 --- a/test/cases/sessions.jl +++ b/test/cases/sessions.jl @@ -12,7 +12,7 @@ @test isopen(s) close_session!(s) @test_throws ArgumentError reset_session!(s) - ond = observe_null(:weights, :host; residue=[:thermal, :em_sidechannel]) + ond = observe_null(:weights, :host; residue = [:thermal, :em_sidechannel]) @test ond.status === :unproved @test ond.residue == [:thermal, :em_sidechannel] @test irreversible(:reduce).inverse === nothing