-
Notifications
You must be signed in to change notification settings - Fork 135
1875 remv miner cli options #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,6 +87,8 @@ To configure Prometheus and run with Besu: | |
| 2. Start Besu with the [`--metrics-enabled`](../../reference/cli/options.md#metrics-enabled) option. | ||
| To start a single node for testing with metrics enabled, run the following command: | ||
|
|
||
| <!-- can I remove the --miner-enabled --miner-coinbase flags --> | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes please |
||
| <Tabs> | ||
| <TabItem value="Syntax"> | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2605,11 +2605,10 @@ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_config","params":[],"id":1}' | |
|
|
||
| Returns the client coinbase address. The coinbase address is the account to pay mining rewards to. | ||
|
|
||
| To set a coinbase address, start Besu with the `--miner-coinbase` option set to a valid Ethereum account address. You can get the Ethereum account address from a client such as MetaMask or Etherscan. For example: | ||
| :::note | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. eth_coinbase RPC has also been removed so can we delete this whole section |
||
|
|
||
| ```bash title="Example" | ||
| besu --miner-coinbase="0xfe3b557e8fb62b89f4916b721be55ceb828dbd73" --rpc-http-enabled | ||
| ``` | ||
| With the deprecation of `--miner-coinbase`, you may no longer set a coinbase address. Systems that maintain `eth_coinbase` auto assign this address. | ||
| ::: | ||
|
|
||
| #### Parameters | ||
|
|
||
|
|
@@ -6849,7 +6848,11 @@ curl -X POST --data '{"jsonrpc":"2.0","method":"miner_setMinPriorityFee","params | |
| ### `miner_start` (Deprecated) | ||
|
|
||
| Starts the mining process. | ||
| To start mining, you must first specify a miner coinbase using the [`--miner-coinbase`](../cli/options.md#miner-coinbase) command line option or using [`miner_setCoinbase`](#miner_setcoinbase). | ||
|
|
||
| ::: | ||
| Mining required a recipient address which was set using the, now deprecated, `--miner-coinbase`. This is now non-configurable and systems which still maintain `miner_start` auto assign this address. | ||
|
|
||
| ::: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would be inclined to remove |
||
|
|
||
| #### Parameters | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI Clique mining (block production) is also deprecated, which means you'll be able to sync existing clique networks but not be a validator or start new Clique networks.
I don't think you need to add these lines about the non-configurable defaults but if you want to include it, I'd use words rather than the CLI option names since they have actually been removed.
Clique uses the local node's address for the coinbase, and mining is enabled by default.