Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ This happens when the IPv6 support in Docker is disabled while connecting to an

### Run a node for testing

<!-- does it make sense to support "run a node that mines blocks" for current Besu? -->

To run a node that mines blocks at a rate suitable for testing purposes with WebSocket enabled:

```bash
Expand Down
2 changes: 2 additions & 0 deletions docs/private-networks/get-started/start-node.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ If you started Besu with the [`--rpc-http-enabled`](../../public-networks/refere

## Run a node for testing

<!-- does it make sense to support "run a node that mines blocks" for current Besu? -->

To run a node that mines blocks at a rate suitable for testing purposes:

```bash
Expand Down
6 changes: 6 additions & 0 deletions docs/private-networks/how-to/configure/consensus/clique.md
Original file line number Diff line number Diff line change
Expand Up @@ -332,3 +332,9 @@ However, when the out-of-turn delay is shorter than the block propagation delay,
We recommend using a more updated consensus protocol such as [IBFT 2.0](ibft.md) or [QBFT](qbft.md).

:::

## Non-configurable defaults

- `miner-enabled` defaults to `true`.
- `miner-coinbase` defaults to the local node.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI Clique mining (block production) is also deprecated, which means you'll be able to sync existing clique networks but not be a validator or start new Clique networks.

I don't think you need to add these lines about the non-configurable defaults but if you want to include it, I'd use words rather than the CLI option names since they have actually been removed.

Clique uses the local node's address for the coinbase, and mining is enabled by default.


2 changes: 2 additions & 0 deletions docs/private-networks/how-to/monitor/opentelemetry.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ You can also install exporters that send system metrics to OpenTelemetry to moni

2. Start Besu with the [`--metrics-enabled`](../../../public-networks/reference/cli/options.md#metrics-enabled) and [`--metrics-protocol=opentelemetry`](../../../public-networks/reference/cli/options.md#metrics-protocol) options. For example, run the following command to start a single node:

<!-- do these docs need updating to remove deprecated --miner-enabled --miner-coinbase <COINBASE ADDRESS> -->

<Tabs>

<TabItem value="Syntax" label="Syntax" default>
Expand Down
2 changes: 2 additions & 0 deletions docs/private-networks/how-to/monitor/splunk.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ If running [Besu as a Docker container](../../get-started/install/run-docker-ima

3. Run Besu. To start a Besu node running in development mode, run the following command:

<!-- do these docs need updating to remove deprecated --miner-enabled --miner-coinbase <COINBASE ADDRESS> -->

```bash
LOGGER=Splunk \
SPLUNK_URL=https://localhost:8088 \
Expand Down
2 changes: 1 addition & 1 deletion docs/private-networks/reference/cli/options.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ You can specify Besu options:
- `_` replaces `-`.
- Has a `BESU_` prefix.

For example, set `--miner-coinbase` using the `BESU_MINER_COINBASE` environment variable.
For example, set `--rpc-http-enabled` using the `BESU_RPC_HTTP_ENABLED` environment variable.

- In a [configuration file](../../../public-networks/how-to/configure-besu/index.md).

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ This happens when the IPv6 support in Docker is disabled while connecting to an

### Run a node for testing

<!-- do these docs need updating to remove deprecated --miner-enabled --miner-coinbase <COINBASE ADDRESS> -->

To run a node that mines blocks at a rate suitable for testing purposes with WebSocket enabled:

```bash
Expand Down
1 change: 1 addition & 0 deletions docs/public-networks/get-started/start-node.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ By default, Besu stores data in the [Bonsai Tries format](../concepts/data-stora

## Run a node for testing

<!-- do these docs need updating to remove deprecated --miner-enabled --miner-coinbase <COINBASE ADDRESS> -->
To run a node that mines blocks at a rate suitable for testing purposes:

```bash
Expand Down
2 changes: 2 additions & 0 deletions docs/public-networks/how-to/monitor/metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ To configure Prometheus and run with Besu:
2. Start Besu with the [`--metrics-enabled`](../../reference/cli/options.md#metrics-enabled) option.
To start a single node for testing with metrics enabled, run the following command:

<!-- can I remove the --miner-enabled --miner-coinbase flags -->

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please

<Tabs>
<TabItem value="Syntax">

Expand Down
13 changes: 8 additions & 5 deletions docs/public-networks/reference/api/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -2605,11 +2605,10 @@ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_config","params":[],"id":1}'

Returns the client coinbase address. The coinbase address is the account to pay mining rewards to.

To set a coinbase address, start Besu with the `--miner-coinbase` option set to a valid Ethereum account address. You can get the Ethereum account address from a client such as MetaMask or Etherscan. For example:
:::note
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eth_coinbase RPC has also been removed so can we delete this whole section


```bash title="Example"
besu --miner-coinbase="0xfe3b557e8fb62b89f4916b721be55ceb828dbd73" --rpc-http-enabled
```
With the deprecation of `--miner-coinbase`, you may no longer set a coinbase address. Systems that maintain `eth_coinbase` auto assign this address.
:::

#### Parameters

Expand Down Expand Up @@ -6849,7 +6848,11 @@ curl -X POST --data '{"jsonrpc":"2.0","method":"miner_setMinPriorityFee","params
### `miner_start` (Deprecated)

Starts the mining process.
To start mining, you must first specify a miner coinbase using the [`--miner-coinbase`](../cli/options.md#miner-coinbase) command line option or using [`miner_setCoinbase`](#miner_setcoinbase).

:::
Mining required a recipient address which was set using the, now deprecated, `--miner-coinbase`. This is now non-configurable and systems which still maintain `miner_start` auto assign this address.

:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be inclined to remove miner_start and miner_stop RPCs as well since they are likely to be removed from the codebase shortly


#### Parameters

Expand Down
93 changes: 1 addition & 92 deletions docs/public-networks/reference/cli/options.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ You can specify Besu options:
- `_` replaces `-`.
- Has a `BESU_` prefix.

For example, set `--miner-coinbase` using the `BESU_MINER_COINBASE` environment variable.
For example, set `--rpc-http-enabled` using the `BESU_RPC_HTTP_ENABLED` environment variable.

- In a [configuration file](../../how-to/configure-besu/index.md).

Expand Down Expand Up @@ -2693,97 +2693,6 @@ For a running node, use:
* [`miner_getMinPriorityFee`](../api/index.md#miner_getminpriorityfee) to get the value.
* [`miner_setMinPriorityFee`](../api/index.md#miner_setminpriorityfee) to change the value.

### `miner-coinbase`

<Tabs>

<TabItem value="Syntax" label="Syntax" default>

```bash
--miner-coinbase=<Ethereum account address>
```

</TabItem>

<TabItem value="Example" label="Example">

```bash
--miner-coinbase=fe3b557e8fb62b89f4916b721be55ceb828dbd73
```

</TabItem>

<TabItem value="Environment variable" label="Environment variable">

```bash
BESU_MINER_COINBASE=fe3b557e8fb62b89f4916b721be55ceb828dbd73
```

</TabItem>

<TabItem value="Configuration file" label="Configuration file">

```bash
miner-coinbase="0xfe3b557e8fb62b89f4916b721be55ceb828dbd73"
```

</TabItem>

</Tabs>

The account you pay mining rewards to.
You must specify a valid coinbase when you enable mining using the
[`--miner-enabled`](#miner-enabled) option or the [`miner_start`](../api/index.md#miner_start-deprecated)
JSON-RPC API method.

:::note

Besu ignores this option in [proof-of-authority](../../../private-networks/concepts/poa.md) networks.
In proof-of-stake networks, such as Ethereum Mainnet, this option is used as a last resort for the
fee recipient, if the consensus layer client doesn't provide any.

:::

### `miner-enabled`

<Tabs>

<TabItem value="Syntax" label="Syntax" default>

```bash
--miner-enabled[=<true|false>]
```

</TabItem>

<TabItem value="Example" label="Example">

```bash
--miner-enabled=true
```

</TabItem>

<TabItem value="Environment variable" label="Environment variable">

```bash
BESU_MINER_ENABLED=true
```

</TabItem>

<TabItem value="Configuration file" label="Configuration file">

```bash
miner-enabled=true
```

</TabItem>

</Tabs>

Enables or disables mining when you start the node. The default is `false`.

### `miner-extra-data`

<Tabs>
Expand Down
Loading