don't cache ids

Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>

Author: Hayim.Shaul@ibm.com

token/services/identity/provider.go

@@ -12,11 +12,11 @@ import (
 	"slices"
 
 	"github.com/hyperledger-labs/fabric-smart-client/pkg/utils/errors"
-	"github.com/hyperledger-labs/fabric-smart-client/platform/common/utils/cache/secondcache"
 	"github.com/hyperledger-labs/fabric-smart-client/platform/common/utils/collections"
 	"github.com/hyperledger-labs/fabric-token-sdk/token/driver"
 	idriver "github.com/hyperledger-labs/fabric-token-sdk/token/services/identity/driver"
 	"github.com/hyperledger-labs/fabric-token-sdk/token/services/logging"
+	cache2 "github.com/hyperledger-labs/fabric-token-sdk/token/services/utils/cache"
 	"go.uber.org/zap/zapcore"
 )
 
@@ -73,7 +73,7 @@ type Provider struct {
 
 	isMeCache cache[bool]
 	signers   cache[*SignerEntry]
-	verifiers cache[*VerifierEntry]
+	// verifiers cache[*VerifierEntry]
 }
 
 // NewProvider creates a new identity provider implementing the driver.IdentityProvider interface.
@@ -91,9 +91,8 @@ func NewProvider(
 		enrollmentIDUnmarshaler: enrollmentIDUnmarshaler,
 		deserializer:            deserializer,
 		storage:                 storage,
-		isMeCache:               secondcache.NewTyped[bool](5000),
-		signers:                 secondcache.NewTyped[*SignerEntry](5000),
-		verifiers:               secondcache.NewTyped[*VerifierEntry](5000),
+		isMeCache:               cache2.NewNoCache[bool](),
+		signers:                 cache2.NewNoCache[*SignerEntry](),
 	}
 }
 
@@ -122,7 +121,6 @@ func (p *Provider) RegisterVerifier(ctx context.Context, identity driver.Identit
 	if p.Logger.IsEnabledFor(zapcore.DebugLevel) {
 		entry.DebugStack = debug.Stack()
 	}
-	p.verifiers.Add(idHash, entry)
 	p.Logger.DebugfContext(ctx, "register verifier to [%s]:[%s]", idHash, logging.Identifier(v))
 	return nil
 }
@@ -261,28 +259,39 @@ func (p *Provider) areMe(ctx context.Context, identities ...driver.Identity) []s
 }
 
 func (p *Provider) getSigner(ctx context.Context, identity driver.Identity, idHash string) (driver.Signer, error) {
-	// check again the cache
-	entry, ok := p.signers.Get(idHash)
-	if ok {
-		p.Logger.DebugfContext(ctx, "signer for [%s] found", idHash)
-		return entry.Signer, nil
+	oneShow := false
+
+	if !oneShow {
+		// check again the cache
+		entry, ok := p.signers.Get(idHash)
+		if ok {
+			p.Logger.DebugfContext(ctx, "signer for [%s] found", idHash)
+			return entry.Signer, nil
+		}
+
+		p.Logger.DebugfContext(ctx, "signer for [%s] not found, try to deserialize", idHash)
+	} else {
+		p.Logger.DebugfContext(ctx, "Skipping cache for one-show id [%s]", idHash)
 	}
 
-	p.Logger.DebugfContext(ctx, "signer for [%s] not found, try to deserialize", idHash)
 	// ask the deserializer
 	signer, err := p.deserializeSigner(ctx, identity)
 	if err != nil {
 		return nil, errors.Wrapf(err, "failed deserializing identity for signer [%s]", identity)
 	}
-	entry = &SignerEntry{Signer: signer}
-	if p.Logger.IsEnabledFor(zapcore.DebugLevel) {
-		entry.DebugStack = debug.Stack()
-	}
-	p.signers.Add(idHash, entry)
-	if err := p.storage.StoreSignerInfo(ctx, identity, nil); err != nil {
-		return nil, errors.Wrap(err, "failed to store entry in storage for the passed signer")
+
+	if !oneShow {
+		entry := &SignerEntry{Signer: signer}
+		if p.Logger.IsEnabledFor(zapcore.DebugLevel) {
+			entry.DebugStack = debug.Stack()
+		}
+		// cache the signer
+		p.signers.Add(idHash, entry)
+		if err := p.storage.StoreSignerInfo(ctx, identity, nil); err != nil {
+			return nil, errors.Wrap(err, "failed to store entry in storage for the passed signer")
+		}
 	}
-	return entry.Signer, nil
+	return signer, nil
 }
 
 func (p *Provider) deserializeSigner(ctx context.Context, identity driver.Identity) (driver.Signer, error) {
@@ -337,9 +346,5 @@ func (p *Provider) updateCaches(descriptor *idriver.IdentityDescriptor, alias dr
 		if p.Logger.IsEnabledFor(zapcore.DebugLevel) {
 			entry.DebugStack = debug.Stack()
 		}
-		p.verifiers.Add(id, entry)
-		if setAlias {
-			p.verifiers.Add(aliasID, entry)
-		}
 	}
 }