Skip to content

Commit 158789a

Browse files
outoftardisWRRicht3r
authored andcommitted
Apply suggestions from code review
Co-authored-by: William Richter <88400283+WRRicht3r@users.noreply.github.com> Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
1 parent e8d3bbf commit 158789a

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

src/guide/bash.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ Make sure you bring up the test network as well.
116116
Now let's look at how to properly configure Iroha 2, and especially its
117117
**C**ommand-**L**ine **I**nterface client.
118118

119-
Make sure that you have another terminal tab or window with a running
119+
Make sure that you have another terminal tab or window open with a running
120120
version, using the instructions above. You can use this screen to monitor
121121
the pipeline events as they are output.
122122

@@ -281,7 +281,7 @@ Another way to create a user (and the user's keys) is as follows:
281281
./target/debug/iroha_crypto_cli
282282
```
283283

284-
2. Copy the public key and repeat the instructions for registering a new
284+
2. Copy the public key and repeat the instructions to register a new
285285
account. Every time you run this command, you will generate a new
286286
key-pair.
287287

src/guide/javascript.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ The Iroha 2 JavaScript library consists of multiple packages:
2020
| <code class="whitespace-pre">crypto-target-bundler</code> | Provides compiled crypto WASM to use with bundlers such as Webpack |
2121

2222
All of these are published under the `@iroha2` scope into Iroha Nexus
23-
Registry. In future, they will be published in the main NPM Registry. To
24-
install these packages, firstly you need to setup a registry:
23+
Registry. In the future, they will be published in the main NPM Registry. To
24+
install these packages, you first need to set up a registry:
2525

2626
```ini
2727
# FILE: .npmrc
@@ -39,8 +39,8 @@ pnpm add @iroha2/crypto-target-web
3939
The set of packages that you need to install depends on your intention.
4040
Maybe you only need to play with the Data Model to perform
4141
(de-)serialisation, in which case the `data-model` package is enough. If
42-
you only need to check on a peer in terms of its status or health, you need
43-
only the client library, because this API doesn't require any interactions
42+
you only need to check on a peer in terms of its status or health, you just need
43+
the client library, because this API doesn't require any interactions
4444
with crypto or Data Model.
4545

4646
For the purposes of this tutorial, it's better to install everything.
@@ -77,7 +77,7 @@ any convenience features like a `TransactionBuilder` or a `ConfigBuilder`.
7777
::: info
7878

7979
The work on implementing those is underway, and these features will very
80-
likely be available with the second round of this tutorial's release.
80+
likely be available in the second round of this tutorial's release.
8181

8282
:::
8383

@@ -782,7 +782,7 @@ onBeforeUnmount(stopListening)
782782
</template>
783783
```
784784

785-
That's it! Finally, we should only wrap it up with the `App.vue` component
785+
That's it! Finally, we just need to wrap it up with the `App.vue` component
786786
and the `app` entrypoint:
787787

788788
```vue

src/guide/kotlin-java.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ that you know how to build and deploy your program on the target platforms.
1414
The Iroha 2 JVM-compatible SDKs are as much a work-in-progress as the rest
1515
of this guide, and significantly more so than the Rust library.
1616

17-
Without further ado, here's an example `build.gradle` file:
17+
Without further ado, here's the example `build.gradle` file:
1818

1919
```kotlin
2020
allprojects {

src/guide/rust.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,6 +428,6 @@ for event in iroha_client.listen_for_events(filter)? {
428428
};
429429
```
430430

431-
Needless to say that a synchronous infinite blocking loop is bad UX for
431+
Needless to say, an synchronous infinite blocking loop is bad UX for
432432
anything but a command-line program, but for illustration purposes, this
433433
would create a nice printout, just like in `iroha_client_cli`.

0 commit comments

Comments
 (0)