fix bug where reading value when server is offline could throw client error (#1154)

Author: brandon-pereira

.changeset/short-peas-sin.md

@@ -0,0 +1,5 @@
+---
+"@hyperdx/app": patch
+---
+
+fix bug where reading value when server is offline could throw client error

packages/app/src/components/DBTimeChart.tsx

@@ -75,22 +75,31 @@ function DBTimeChartComponent({
 
   const { graphResults, timestampColumn, groupKeys, lineNames, lineColors } =
     useMemo(() => {
-      return data != null && isSuccess
-        ? formatResponseForTimeChart({
-            res: data,
-            dateRange,
-            granularity,
-            generateEmptyBuckets: fillNulls !== false,
-            source,
-          })
-        : {
-            graphResults: [],
-            timestampColumn: undefined,
-            groupKeys: [],
-            lineNames: [],
-            lineColors: [],
-          };
-    }, [data, dateRange, granularity, isSuccess, fillNulls]);
+      const defaultResponse = {
+        graphResults: [],
+        timestampColumn: undefined,
+        groupKeys: [],
+        lineNames: [],
+        lineColors: [],
+      };
+
+      if (data == null || !isSuccess) {
+        return defaultResponse;
+      }
+
+      try {
+        return formatResponseForTimeChart({
+          res: data,
+          dateRange,
+          granularity,
+          generateEmptyBuckets: fillNulls !== false,
+          source,
+        });
+      } catch (e) {
+        console.error(e);
+        return defaultResponse;
+      }
+    }, [data, dateRange, granularity, isSuccess, fillNulls, source]);
 
   // To enable backward compatibility, allow non-controlled usage of displayType
   const [displayTypeLocal, setDisplayTypeLocal] = useState(displayTypeProp);