allow setting defaults for wait (#126)

Author: mafintosh

index.js

@@ -69,6 +69,7 @@ module.exports = class Hypercore extends EventEmitter {
     this.auth = opts.auth || null
     this.autoClose = !!opts.autoClose
     this.onwait = opts.onwait || null
+    this.wait = opts.wait !== false
 
     this.closing = null
     this.opening = this._openSession(key, storage, opts)
@@ -194,11 +195,13 @@ module.exports = class Hypercore extends EventEmitter {
     }
 
     const sparse = opts.sparse === false ? false : this.sparse
+    const wait = opts.wait === false ? false : this.wait
     const onwait = opts.onwait === undefined ? this.onwait : opts.onwait
     const Clz = opts.class || Hypercore
     const s = new Clz(this.storage, this.key, {
       ...opts,
       sparse,
+      wait,
       onwait,
       _opening: this.opening,
       _sessions: this.sessions
@@ -682,6 +685,7 @@ module.exports = class Hypercore extends EventEmitter {
       if (this.cache) this.cache.set(index, block)
     } else {
       if (opts && opts.wait === false) return null
+      if (this.wait === false && (!opts || !opts.wait)) return null
       if (opts && opts.onwait) opts.onwait(index, this)
       if (this.onwait) this.onwait(index, this)
 

test/basic.js

@@ -201,3 +201,34 @@ test('read ahead', async function (t) {
 
   t.alike(await blk, 'b')
 })
+
+test('defaults for wait', async function (t) {
+  t.plan(5)
+
+  const core = new Hypercore(RAM, Buffer.alloc(32), { valueEncoding: 'utf-8' })
+
+  const a = core.get(1)
+
+  a.catch(function (err) {
+    t.ok(err, 'a failed')
+  })
+
+  t.is(await core.get(1, { wait: false }), null)
+
+  const s = core.session({ wait: false })
+
+  const b = s.get(1, { wait: true })
+
+  b.catch(function (err) {
+    t.ok(err, 'b failed')
+  })
+
+  t.is(await s.get(1), null)
+
+  const s2 = s.session() // check if wait is inherited
+
+  t.is(await s2.get(1), null)
+
+  await s.close()
+  await core.close()
+})