Merge pull request #252 from mohamed-barakat/DirectProductToExponentialRightAdjunctMorphism

improved AddDirectProductToExponentialRightAdjunctMorphismWithGivenExponential

Author: mohamed-barakat

PackageInfo.g

@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "FinSetsForCAP",
 Subtitle := "The elementary topos of (skeletal) finite sets",
-Version := "2024.02-09",
+Version := "2024.03-01",
 
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",

gap/CompilerLogic.gi

@@ -502,7 +502,7 @@ CapJitAddLogicTemplate(
 CapJitAddLogicTemplate(
     rec(
         variable_names := [ "a", "q", "i" ],
-        src_template := "Sum( List( [ 0 .. a - 1 ], k -> (k + a * i) * q^k ) )",
+        src_template := "Sum( List( [ 0 .. a - 1 ], k -> (k + i * a) * q^k ) )",
         dst_template := "q * GeometricSumDiff1( q, a ) + a * i * GeometricSum( q, a )",
     )
 );

gap/SkeletalFinSets.gi

@@ -866,7 +866,7 @@ AddDirectProductToExponentialRightAdjunctMorphismWithGivenExponential( SkeletalF
                    A,
                    List( A, i ->
                          Sum( List( L, k ->
-                                 f_map[1 + k + l * i] * b^k ) ) ),
+                                 f_map[1 + k + i * l] * b^k ) ) ),
                    expLB );
 
 end );

gap/precompiled_categories/SkeletalCategoryOfFiniteSetsWithMorphismsGivenByListsPrecompiled.gi

@@ -331,7 +331,7 @@ function ( cat_1, a_1, b_1, f_1, i_1 )
     hoisted_2_1 := AsList( f_1 );
     return CreateCapCategoryMorphismWithAttributes( cat_1, b_1, i_1, AsList, List( [ 0 .. Length( b_1 ) - 1 ], function ( i_2 )
               local hoisted_1_2;
-              hoisted_1_2 := deduped_5_1 * i_2;
+              hoisted_1_2 := i_2 * deduped_5_1;
               return Sum( List( hoisted_4_1, function ( k_3 )
                         return hoisted_2_1[(1 + k_3 + hoisted_1_2)] * hoisted_3_1 ^ k_3;
                     end ) );