Skip to content

Commit cae2eee

Browse files
author
Tim Jacomb
committed
Pass a document rather than a fragment to new node
1 parent 1034346 commit cae2eee

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## Unreleased
44

5+
### Fixes
6+
7+
Deprecation warnings from Nokogiri addressed when rendering markdown tables
8+
59
## 3.2.0
610

711
### New features

lib/govuk_tech_docs/tech_docs_html_renderer.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def table_row(body)
6969
first_child.content = leading_text.sub(/# */, "")
7070
end
7171

72-
tr = Nokogiri::XML::Node.new "tr", fragment
72+
tr = Nokogiri::XML::Node.new "tr", fragment.document
7373
tr.children = fragment.children
7474

7575
tr.to_html
@@ -95,9 +95,9 @@ def block_code(text, lang)
9595
# be `defined?`, so we can jump straight to rendering HTML ourselves.
9696

9797
fragment = Nokogiri::HTML::DocumentFragment.parse("")
98-
pre = Nokogiri::XML::Node.new "pre", fragment
98+
pre = Nokogiri::XML::Node.new "pre", fragment.document
9999
pre["tabindex"] = "0"
100-
code = Nokogiri::XML::Node.new "code", fragment
100+
code = Nokogiri::XML::Node.new "code", fragment.document
101101
code["class"] = lang
102102
code.content = text
103103
pre.add_child code

0 commit comments

Comments
 (0)