fix(middlewares): allow other middlewares to modify errors response

Author: coderbyheart

src/aProblem.ts

@@ -1,11 +1,11 @@
-import type { APIGatewayProxyResultV2 } from 'aws-lambda'
+import type { APIGatewayProxyStructuredResultV2 } from 'aws-lambda'
 import type { Static } from '@sinclair/typebox'
 import { Context, type ProblemDetail } from '@hello.nrfcloud.com/proto/hello'
 
 export const aProblem = (
 	problem: Omit<Static<typeof ProblemDetail>, '@context'>,
 	cacheForSeconds: number = 60,
-): APIGatewayProxyResultV2 => ({
+): APIGatewayProxyStructuredResultV2 => ({
 	statusCode: problem.status,
 	headers: {
 		'content-type': 'application/problem+json',

src/aResponse.ts

@@ -1,7 +1,4 @@
-import type {
-	APIGatewayProxyResultV2,
-	APIGatewayProxyStructuredResultV2,
-} from 'aws-lambda'
+import type { APIGatewayProxyStructuredResultV2 } from 'aws-lambda'
 import type { HttpStatusCode } from '@hello.nrfcloud.com/proto/hello'
 
 export const aResponse = (
@@ -11,7 +8,7 @@ export const aResponse = (
 	} & Record<string, unknown>,
 	cacheForSeconds: number = 60,
 	headers?: APIGatewayProxyStructuredResultV2['headers'],
-): APIGatewayProxyResultV2 => {
+): APIGatewayProxyStructuredResultV2 => {
 	const body = result !== undefined ? JSON.stringify(result) : undefined
 	return {
 		statusCode: status,

src/corsResponse.ts

@@ -1,12 +1,12 @@
 import type {
 	APIGatewayProxyEventHeaders,
-	APIGatewayProxyResultV2,
+	APIGatewayProxyStructuredResultV2,
 } from 'aws-lambda'
 import { corsHeaders } from './corsHeaders.js'
 
 export const corsResponse = (event: {
 	headers: APIGatewayProxyEventHeaders
-}): APIGatewayProxyResultV2 => ({
+}): APIGatewayProxyStructuredResultV2 => ({
 	statusCode: 200,
 	headers: corsHeaders(event),
 })

src/problemResponse.ts

@@ -33,22 +33,23 @@ export const problemResponse = (): MiddlewareObj<
 	LambdaContext
 > => ({
 	onError: async (req) => {
+		if (req.response !== undefined) return
 		if (req.error instanceof ValidationFailedError) {
-			return aProblem({
+			req.response = aProblem({
 				title: 'Validation failed',
 				status: HttpStatusCode.BAD_REQUEST,
 				detail: formatTypeBoxErrors(req.error.errors),
 			})
+		} else if (req.error instanceof ProblemDetailError) {
+			req.response = aProblem(req.error.problem)
+		} else {
+			req.response = aProblem({
+				title:
+					req.error instanceof Error
+						? req.error.message
+						: 'Internal Server Error',
+				status: HttpStatusCode.INTERNAL_SERVER_ERROR,
+			})
 		}
-		if (req.error instanceof ProblemDetailError) {
-			return aProblem(req.error.problem)
-		}
-		return aProblem({
-			title:
-				req.error instanceof Error
-					? req.error.message
-					: 'Internal Server Error',
-			status: HttpStatusCode.INTERNAL_SERVER_ERROR,
-		})
 	},
 })