Skip to content

Try running end-to-end tests on actual Chrome #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: working-groups-on-events-page
Choose a base branch
from
Open

Try running end-to-end tests on actual Chrome #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52bdae9
Try running end-to-end tests on actual Chrome
hasparus Nov 19, 2025
819817a
Comment out action-sshd-cloudflared
hasparus Nov 19, 2025
71c39f4
Remove test.skip() call
hasparus Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,5 @@ jobs:
path: playwright-report/
retention-days: 30

- uses: valeriangalliat/action-sshd-cloudflared@v1
if: failure()
# - uses: valeriangalliat/action-sshd-cloudflared@v1
# if: failure()
21 changes: 14 additions & 7 deletions playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,23 @@ export default defineConfig({
timeout: 60 * 1000,

projects: [
// {
// name: "chromium",
// use: {
// ...devices["Desktop Chrome"],
// channel: "chromium",
// ...(process.env.CI
// ? {
// args: ["--enable-gpu"],
// }
// : {}),
// },
// },
{
name: "chromium",
name: "chrome",
use: {
...devices["Desktop Chrome"],
channel: "chromium",
...(process.env.CI
? {
args: ["--enable-gpu"],
}
: {}),
channel: "chrome",
},
},
],
Expand Down
3 changes: 0 additions & 3 deletions test/e2e/community-events.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { test, expect, type Locator } from "@playwright/test"

test.beforeEach(async ({ page }) => {
Expand Down Expand Up @@ -142,9 +142,6 @@
test("event type filters hide cards and lock the last active tag", async ({
page,
}) => {
// TODO: @hasparus figure out why this fails only on CI
if (process.env.CI) test.skip()

const pastEventsSection = page
.locator("section")
.filter({
Expand All @@ -161,7 +158,7 @@
name: "Event type",
})

await expect(filterGroup).toBeVisible()

Check failure on line 161 in test/e2e/community-events.spec.ts

View workflow job for this annotation

GitHub Actions / playwright

[chrome] › test/e2e/community-events.spec.ts:142:1 › event type filters hide cards and lock the last active tag 

  1) [chrome] › test/e2e/community-events.spec.ts:142:1 › event type filters hide cards and lock the last active tag 
    Error: expect(locator).toBeVisible() failed

    Locator:  locator('section').filter({ has: getByRole('heading', { name: /Past events & meetups/i, level: 2 }) }).first().getByRole('group', { name: 'Event type' })
    Expected: visible
    Received: undefined

    Call log:
      - Expect "toBeVisible" with timeout 5000ms
      - waiting for locator('section').filter({ has: getByRole('heading', { name: /Past events & meetups/i, level: 2 }) }).first().getByRole('group', { name: 'Event type' })


      159 |   })
      160 |
    > 161 |   await expect(filterGroup).toBeVisible()
          |                             ^
      162 |   const conferenceFilter = filterGroup.getByRole("checkbox", {
      163 |     name: /conference/i,
      164 |   })
        at /home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:161:29
const conferenceFilter = filterGroup.getByRole("checkbox", {
name: /conference/i,
})
Expand Down Expand Up @@ -217,10 +214,10 @@

for (const definition of filterDefinitions) {
const badgeLocator = tagBadge(definition.badgeText)
if ((await definition.filter.count()) === 0) continue

Check failure on line 217 in test/e2e/community-events.spec.ts

View workflow job for this annotation

GitHub Actions / playwright

[chrome] › test/e2e/community-events.spec.ts:142:1 › event type filters hide cards and lock the last active tag 

  1) [chrome] › test/e2e/community-events.spec.ts:142:1 › event type filters hide cards and lock the last active tag 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.count: Test timeout of 60000ms exceeded.

      215 |   for (const definition of filterDefinitions) {
      216 |     const badgeLocator = tagBadge(definition.badgeText)
    > 217 |     if ((await definition.filter.count()) === 0) continue
          |                                  ^
      218 |     const filterDefinition = { ...definition, badges: badgeLocator }
      219 |     activeFilters.push(filterDefinition)
      220 |     if (await definition.filter.isEnabled()) {
        at /home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:217:34
const filterDefinition = { ...definition, badges: badgeLocator }
activeFilters.push(filterDefinition)
if (await definition.filter.isEnabled()) {

Check failure on line 220 in test/e2e/community-events.spec.ts

View workflow job for this annotation

GitHub Actions / playwright

[chrome] › test/e2e/community-events.spec.ts:142:1 › event type filters hide cards and lock the last active tag 

  1) [chrome] › test/e2e/community-events.spec.ts:142:1 › event type filters hide cards and lock the last active tag 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.isEnabled: Test timeout of 60000ms exceeded.
    Call log:
      - waiting for locator('section').filter({ has: getByRole('heading', { name: /Past events & meetups/i, level: 2 }) }).first().getByRole('group', { name: 'Event type' }).getByRole('checkbox', { name: /conference/i })


      218 |     const filterDefinition = { ...definition, badges: badgeLocator }
      219 |     activeFilters.push(filterDefinition)
    > 220 |     if (await definition.filter.isEnabled()) {
          |                                 ^
      221 |       toggleableFilters.push(filterDefinition)
      222 |     }
      223 |   }
        at /home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:220:33
toggleableFilters.push(filterDefinition)
}
}
Expand Down
Loading