Follow hlint suggestion: Use section

Author: philderbeast

.hlint.yaml

@@ -56,10 +56,9 @@
 - ignore: {name: "Use record patterns"} # 16 hints
 - ignore: {name: "Use replicateM_"} # 2 hints
 - ignore: {name: "Use rights"} # 2 hints
-- ignore: {name: "Use section"} # 18 hints
 - ignore: {name: "Use tuple-section"} # 28 hints
 - ignore: {name: "Use typeRep"} # 2 hints
-- ignore: {name: "Use unless"} # 23 hints
+- ignore: {name: "Use unless"} # 23 hints+++++++++
 - ignore: {name: "Use unwords"} # 8 hints
 - ignore: {name: "Use void"} # 23 hints
 

Cabal/src/Distribution/PackageDescription/Check.hs

@@ -1060,7 +1060,7 @@ checkMissingDocs dgs esgs edgs efgs = do
       -> [FilePath] -- Actuals.
       -> [PackageCheck]
     checkDoc b ds as =
-      let fds = map ("." </>) $ filter (flip notElem as) ds
+      let fds = map ("." </>) $ filter (`notElem` as) ds
        in if null fds
             then []
             else
@@ -1075,7 +1075,7 @@ checkMissingDocs dgs esgs edgs efgs = do
       -> [FilePath] -- Actuals.
       -> [PackageCheck]
     checkDocMove b field ds as =
-      let fds = filter (flip elem as) ds
+      let fds = filter (`elem` as) ds
        in if null fds
             then []
             else

Cabal/src/Distribution/PackageDescription/Check/Target.hs

@@ -79,7 +79,7 @@ checkLibrary
     checkP
       ( not $
           all
-            (flip elem (explicitLibModules lib))
+            (`elem` (explicitLibModules lib))
             (libModulesAutogen lib)
       )
       (PackageBuildImpossible AutogenNotExposed)
@@ -172,7 +172,7 @@ checkExecutable
     -- Alas exeModules ad exeModulesAutogen (exported from
     -- Distribution.Types.Executable) take `Executable` as a parameter.
     checkP
-      (not $ all (flip elem (exeModules exe)) (exeModulesAutogen exe))
+      (not $ all (`elem` (exeModules exe)) (exeModulesAutogen exe))
       (PackageBuildImpossible $ AutogenNoOther cet)
     checkP
       ( not $
@@ -218,7 +218,7 @@ checkTestSuite
     checkP
       ( not $
           all
-            (flip elem (testModules ts))
+            (`elem` (testModules ts))
             (testModulesAutogen ts)
       )
       (PackageBuildImpossible $ AutogenNoOther cet)
@@ -280,7 +280,7 @@ checkBenchmark
     checkP
       ( not $
           all
-            (flip elem (benchmarkModules bm))
+            (`elem` (benchmarkModules bm))
             (benchmarkModulesAutogen bm)
       )
       (PackageBuildImpossible $ AutogenNoOther cet)

Cabal/src/Distribution/Simple/Build.hs

@@ -240,7 +240,7 @@ build_setupHooks
               , SetupHooks.targetInfo = target
               }
       for_ mbPostBuild ($ postBuildInputs)
-      return (maybe index (Index.insert `flip` index) mb_ipi)
+      return (maybe index (`Index.insert` index) mb_ipi)
 
     return ()
     where

Cabal/src/Distribution/Utils/Progress.hs

@@ -62,7 +62,7 @@ instance Monad (Progress step fail) where
 
 instance Applicative (Progress step fail) where
   pure a = Done a
-  p <*> x = foldProgress Step Fail (flip fmap x) p
+  p <*> x = foldProgress Step Fail (`fmap` x) p
 
 instance Monoid fail => Alternative (Progress step fail) where
   empty = Fail Mon.mempty

cabal-install-solver/src/Distribution/Solver/Modular/Preference.hs

@@ -135,7 +135,7 @@ preferPackagePreferences pcs =
     preferred pn opt =
       let PackagePreferences vrs _ _ = pcs pn
       in fromIntegral . negate . L.length $
-         L.filter (flip checkVR (version opt)) vrs
+         L.filter (`checkVR` (version opt)) vrs
 
     -- Prefer installed packages over non-installed packages.
     installed :: POption -> Weight

cabal-install-solver/src/Distribution/Solver/Types/Progress.hs

@@ -42,7 +42,7 @@ instance Monad (Progress step fail) where
 
 instance Applicative (Progress step fail) where
   pure a  = Done a
-  p <*> x = foldProgress Step Fail (flip fmap x) p
+  p <*> x = foldProgress Step Fail (`fmap` x) p
 
 instance Monoid fail => Alternative (Progress step fail) where
   empty   = Fail mempty

cabal-install/src/Distribution/Client/CmdLegacy.hs

@@ -163,7 +163,7 @@ legacyWrapperCmd ui commonFlags = toLegacyCmd (wrapperCmd ui commonFlags)
 newCmd :: CommandUI flags -> (flags -> [String] -> globals -> IO action) -> [CommandSpec (globals -> IO action)]
 newCmd origUi@CommandUI{..} action = [cmd defaultUi, cmd newUi, cmd origUi]
   where
-    cmd ui = CommandSpec ui (flip commandAddAction action) NormalCommand
+    cmd ui = CommandSpec ui (`commandAddAction` action) NormalCommand
 
     newMsg = T.unpack . T.replace "v2-" "new-" . T.pack
     newUi =

cabal-install/src/Distribution/Client/CmdOutdated.hs

@@ -395,7 +395,7 @@ type OutdatedDependency = OutdatedDependencyX Version
 -- | Convert a list of 'UserConstraint's to a 'Dependency' list.
 userConstraintsToDependencies :: [(UserConstraint, ConstraintSource)] -> [CandidateOutdatedDependency]
 userConstraintsToDependencies ucnstrs =
-  mapMaybe (\(uc, src) -> fmap (flip mkCandidateOutdatedDependency (ConfigSource src)) (packageConstraintToDependency . userToPackageConstraint $ uc)) ucnstrs
+  mapMaybe (\(uc, src) -> fmap (`mkCandidateOutdatedDependency` (ConfigSource src)) (packageConstraintToDependency . userToPackageConstraint $ uc)) ucnstrs
 
 -- | Read the list of dependencies from the freeze file.
 depsFromFreezeFile :: Verbosity -> IO [CandidateOutdatedDependency]

cabal-install/src/Distribution/Client/InstallPlan.hs

@@ -783,9 +783,9 @@ processingInvariant
   -> Bool
 processingInvariant plan (Processing processingSet completedSet failedSet) =
   -- All the packages in the three sets are actually in the graph
-  assert (Foldable.all (flip Graph.member (planGraph plan)) processingSet)
-    $ assert (Foldable.all (flip Graph.member (planGraph plan)) completedSet)
-    $ assert (Foldable.all (flip Graph.member (planGraph plan)) failedSet)
+  assert (Foldable.all (`Graph.member` (planGraph plan)) processingSet)
+    $ assert (Foldable.all (`Graph.member` (planGraph plan)) completedSet)
+    $ assert (Foldable.all (`Graph.member` (planGraph plan)) failedSet)
     $
     -- The processing, completed and failed sets are disjoint from each other
     assert (noIntersection processingSet completedSet)
@@ -1070,7 +1070,7 @@ problems graph =
        | pkg <- Foldable.toList graph
        , Just pkg' <-
           map
-            (flip Graph.lookup graph)
+            (`Graph.lookup` graph)
             (nodeNeighbors pkg)
        , not (stateDependencyRelation pkg pkg')
        ]