prefixed OnSetThemeCallback with Hds per review suggestion

Author: didoo

packages/components/src/components/hds/theme-switcher/index.ts

@@ -17,7 +17,7 @@ import type { HdsIconSignature } from '../icon/index.ts';
 import type HdsThemingService from '../../../services/hds-theming.ts';
 import type {
   HdsThemes,
-  OnSetThemeCallback,
+  HdsOnSetThemeCallback,
 } from '../../../services/hds-theming.ts';
 
 interface ThemeOption {
@@ -39,7 +39,7 @@ interface HdsThemeSwitcherSignature {
     toggleIsFullWidth?: HdsDropdownToggleButtonSignature['Args']['isFullWidth'];
     hasDefaultOption?: boolean;
     hasSystemOption?: boolean;
-    onSetTheme?: OnSetThemeCallback;
+    onSetTheme?: HdsOnSetThemeCallback;
   };
   Element: HdsDropdownSignature['Element'];
 }

packages/components/src/services/hds-theming.ts

@@ -42,15 +42,15 @@ type HdsThemingOptions = {
 type SetThemeArgs = {
   theme: HdsThemes | undefined;
   options?: HdsThemingOptions;
-  onSetTheme?: OnSetThemeCallback;
+  onSetTheme?: HdsOnSetThemeCallback;
 };
 
-export type OnSetThemeCallbackArgs = {
+export type HdsOnSetThemeCallbackArgs = {
   currentTheme: HdsThemes | undefined;
   currentMode: HdsModes | undefined;
 };
 
-export type OnSetThemeCallback = (args: OnSetThemeCallbackArgs) => void;
+export type HdsOnSetThemeCallback = (args: HdsOnSetThemeCallbackArgs) => void;
 
 export const THEMES: HdsThemes[] = Object.values(HdsThemeValues);
 export const MODES_LIGHT: HdsModesLight[] = Object.values(HdsModesLightValues);
@@ -72,7 +72,7 @@ export default class HdsThemingService extends Service {
   @tracked _currentLightTheme: HdsModesLight =
     DEFAULT_THEMING_OPTION_LIGHT_THEME;
   @tracked _currentDarkTheme: HdsModesDark = DEFAULT_THEMING_OPTION_DARK_THEME;
-  @tracked globalOnSetTheme: OnSetThemeCallback | undefined;
+  @tracked globalOnSetTheme: HdsOnSetThemeCallback | undefined;
 
   initializeTheme() {
     const rawStoredThemingData = localStorage.getItem(

showcase/app/components/page-foundations/theming/sub-sections/theme-switcher.gts

@@ -12,16 +12,16 @@ import { HdsThemeSwitcher } from '@hashicorp/design-system-components/components
 import ShwThemingService from 'showcase/services/shw-theming';
 
 import type {
-  OnSetThemeCallback,
-  OnSetThemeCallbackArgs,
+  HdsOnSetThemeCallback,
+  HdsOnSetThemeCallbackArgs,
 } from '@hashicorp/design-system-components/services/hds-theming';
 
 export default class SubSectionThemeSwitcher extends Component {
   @service declare readonly shwTheming: ShwThemingService;
 
-  onSetTheme: OnSetThemeCallback = ({
+  onSetTheme: HdsOnSetThemeCallback = ({
     currentTheme,
-  }: OnSetThemeCallbackArgs) => {
+  }: HdsOnSetThemeCallbackArgs) => {
     if (
       this.shwTheming.currentStylesheet === 'standard' ||
       (currentTheme === 'default' &&

showcase/app/services/shw-theming.ts

@@ -5,8 +5,8 @@ import { inject as service } from '@ember/service';
 import HdsThemingService from '@hashicorp/design-system-components/services/hds-theming';
 
 // import type {
-//   OnSetThemeCallback,
-//   OnSetThemeCallbackArgs,
+//   HdsOnSetThemeCallback,
+//   HdsOnSetThemeCallbackArgs,
 // } from '@hashicorp/design-system-components/services/hds-theming';
 
 export type ShwStylesheets =
@@ -84,10 +84,10 @@ export default class ShwThemingService extends HdsThemingService {
   // example of how a consumer could use the `globalOnSetTheme` callback by extending the `hdsTheming` service
   // note: for this to work, the `setTheme` must be invoked using the `shwTheming` service: `this.shwTheming.setTheme()`
   //
-  // globalOnSetTheme: OnSetThemeCallback = ({
+  // globalOnSetTheme: HdsOnSetThemeCallback = ({
   //   currentTheme,
   //   currentMode,
-  // }: OnSetThemeCallbackArgs) => {
+  // }: HdsOnSetThemeCallbackArgs) => {
   //   console.log(
   //     'ShwTheming Service -- globalOnSetTheme invoked',
   //     currentTheme,