BUG/MEDIUM: ensure no startup race possible when creating Configuration struct

Author: aiharos

configuration/configuration.go

@@ -166,9 +166,11 @@ type Configuration struct {
 	MapSync                *MapSync             `yaml:"-"`
 }
 
+var cfgInitOnce sync.Once
+
 // Get returns pointer to configuration
 func Get() *Configuration {
-	if cfg == nil {
+	cfgInitOnce.Do(func() {
 		cfg = &Configuration{}
 		cfg.initSignalHandler()
 		cfg.Notify.BootstrapKeyChanged = NewChanNotify()
@@ -188,7 +190,7 @@ func Get() *Configuration {
 		}
 
 		cfg.Cmdline.Store(sb.String())
-	}
+	})
 	return cfg
 }