BUILD/MINOR: go: upgrade go to 1.20

Author: mjuraga

.github/workflows/.goreleaser.yml

@@ -8,13 +8,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Set up Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v4
         with:
-          go-version: 1.19
+          go-version: 1.20
       - name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@v2
+        uses: goreleaser/goreleaser-action@v4
         with:
           distribution: goreleaser
           version: latest

.github/workflows/build.yml

@@ -10,14 +10,14 @@ jobs:
     runs-on: ubuntu-latest
     steps:
 
-    - name: Set up Go 1.19
-      uses: actions/setup-go@v1
+    - name: Set up Go 1.20
+      uses: actions/setup-go@v4
       with:
-        go-version: 1.19
+        go-version: 1.20
       id: go
 
     - name: Check out code into the Go module directory
-      uses: actions/checkout@v1
+      uses: actions/checkout@v3
 
     - name: Get dependencies
       run: |

.github/workflows/e2e.yml

@@ -12,13 +12,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out code into the Go module directory
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
     - name: Downloading required packages
       run: sudo apt-get install bats
-    - name: Set up Go 1.19
-      uses: actions/setup-go@v1
+    - name: Set up Go 1.20
+      uses: actions/setup-go@v4
       with:
-        go-version: 1.19
+        go-version: 1.20
     - run: make e2e
       env:
         HAPROXY_VERSION: ${{ matrix.haproxy_version }}

.github/workflows/lint.yml

@@ -9,12 +9,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Set up Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v4
         with:
-          go-version: 1.19
-      - uses: actions/cache@v2
+          go-version: 1.20
+      - uses: actions/cache@v3
         with:
           path: |
             ~/.cache/go-build
@@ -31,12 +31,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Set up Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v4
         with:
-          go-version: 1.19
-      - uses: actions/cache@v2
+          go-version: 1.20
+      - uses: actions/cache@v3
         with:
           path: |
             ~/.cache/go-build

.gitlab-ci.yml

@@ -10,7 +10,7 @@ variables:
 diff:
   stage: lint
   image:
-    name: $CI_REGISTRY_GO/docker:stable-go1.19
+    name: $CI_REGISTRY_GO/docker:stable-go1.20
     entrypoint: [ "" ]
   services:
     - name: $CI_REGISTRY_GO/docker:20.10.5-dind
@@ -33,7 +33,7 @@ golangci-lint:
     paths:
       - build
   image:
-    name: $CI_REGISTRY_GO/golang:1.19
+    name: $CI_REGISTRY_GO/golang:1.20
     entrypoint: [""]
   tags:
     - go
@@ -48,7 +48,7 @@ gofumpt:
     - if: $CI_PIPELINE_SOURCE == 'merge_request_event'
     - if: $CI_PIPELINE_SOURCE == 'push'
   image:
-    name: $CI_REGISTRY_GO/golang:1.19
+    name: $CI_REGISTRY_GO/golang:1.20
     entrypoint: [""]
   tags:
     - go
@@ -73,7 +73,7 @@ build:
     paths:
       - build
   image:
-    name: $CI_REGISTRY_GO/golang:1.19
+    name: $CI_REGISTRY_GO/golang:1.20
     entrypoint: [ "" ]
   tags:
     - go

Makefile

@@ -9,7 +9,7 @@ GIT_MODIFIED=${GIT_MODIFIED1}${GIT_MODIFIED2}
 SWAGGER_VERSION=${shell curl -s https://raw.githubusercontent.com/haproxytech/client-native/master/Makefile | grep SWAGGER_VERSION -m 1 | awk -F"=" '{print $$2}'}
 BUILD_DATE=$(shell date -u '+%Y-%m-%dT%H:%M:%SZ')
 CGO_ENABLED?=0
-GOLANGCI_LINT_VERSION=1.50.1
+GOLANGCI_LINT_VERSION=1.51.1
 
 all: update clean build
 

README.md

@@ -9,7 +9,7 @@
 
 ## Building the Data Plane API
 
-In order to build the Data Plane API you need go 1.19 installed on your system with go modules support enabled, and execute the following steps:
+In order to build the Data Plane API you need go 1.20 installed on your system with go modules support enabled, and execute the following steps:
 
 1\. Clone dataplaneapi repository
 

configuration/configuration.go

@@ -20,12 +20,10 @@ import (
 	"errors"
 	"fmt"
 	"io/fs"
-	"math/rand"
 	"os"
 	"path/filepath"
 	"strings"
 	"sync"
-	"time"
 
 	petname "github.com/dustinkirkland/golang-petname"
 	"github.com/haproxytech/client-native/v4/models"
@@ -242,7 +240,6 @@ func (c *Configuration) Load() error {
 		hostname, nameErr := os.Hostname()
 		if nameErr != nil {
 			log.Warningf("Error fetching hostname, using petname for dataplaneapi name: %s", nameErr.Error())
-			rand.Seed(time.Now().UnixNano())
 			c.Name.Store(petname.Generate(2, "_"))
 		}
 		c.Name.Store(hostname)

configuration/map_sync.go

@@ -145,7 +145,6 @@ func equalSomeEntries(fEntries, rEntries models.MapEntries, index ...int) bool {
 	}
 
 	for i := 0; i < maxRandom; i++ {
-		rand.Seed(time.Now().UTC().UnixNano())
 		// There's no need for strong number generation, here, just need for performance
 		r := rand.Intn(max)
 		if len(index) > 0 {

configure_data_plane.go

@@ -65,7 +65,7 @@ import (
 	_ "github.com/GehirnInc/crypt/sha512_crypt"
 )
 
-// go:generate swagger generate server --target ../../../../../../github.com/haproxytech --name controller --spec ../../../../../../../../haproxy-api/haproxy-open-api-spec/build/haproxy_spec.yaml --server-package controller --tags Stats --tags Information --tags Configuration --tags Discovery --tags Frontend --tags Backend --tags Bind --tags Server --tags TCPRequestRule --tags HTTPRequestRule --tags HTTPResponseRule --tags Acl --tags BackendSwitchingRule --tags ServerSwitchingRule --tags TCPResponseRule --skip-models --exclude-main
+//go:generate swagger generate server --target ../../../../../../github.com/haproxytech --name controller --spec ../../../../../../../../haproxy-api/haproxy-open-api-spec/build/haproxy_spec.yaml --server-package controller --tags Stats --tags Information --tags Configuration --tags Discovery --tags Frontend --tags Backend --tags Bind --tags Server --tags TCPRequestRule --tags HTTPRequestRule --tags HTTPResponseRule --tags Acl --tags BackendSwitchingRule --tags ServerSwitchingRule --tags TCPResponseRule --skip-models --exclude-main
 
 var (
 	Version               string