Skip to content

ER: Bug fix for "Schedule Monthly" workflow #8441

@t-will-gillis

Description

@t-will-gillis

Emergent Requirement - Problem

The 12/1/25 run of the "Schedule Monthly" workflow did not work as expected in two areas:

  • First, on the message posted to the Monday agenda, the bot incorrectly listed four devs and their Skills Issues as "Non-team members with open issues." The bot had just removed those four from the website-write team and closed their Skills Issues.
  • Second, the bot closed the wrong issue: Reopen Issues Without Linked PR #8438 was closed instead of the intended Review Inactive Team Members #8439.

Issue you discovered this emergent requirement in

Date discovered

12/1/25

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@t-will-gillis

What happens if this is not addressed

The same errors could recur.

Resources

https://github.com/hackforla/website/blob/gh-pages/.github/workflows/schedule-monthly.yml
https://github.com/hackforla/website/blob/gh-pages/.github/workflows/wr-schedule-monthly.yml
https://github.com/hackforla/website/blob/gh-pages/github-actions/trigger-schedule/list-inactive-members/trim-inactive-members.js

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

  • Note that although this ER is listed as Complexity: Medium, the actual issue to fix the bugs should be Complexity: Large.
  • For the first error, in trim-inactive-members.js there is a missing await at the closePrework() function near +/- line 98. Without the await, the if-loop is not fully completing before the return which is why the devs are removed before their Skills Issues are closed.
  • For the second error, in the workflow run wr-schedule-monthly.yml, the "Get issue number" step ran before the issue was created by the schedule-monthly.yml workflow. This cause of this error exposes some inefficiencies in the full workflow. The step "Close new issue" is polling for the owner URL and the created issue number, but this data is available already in github-actions/trigger-schedule/list-inactive-members/create-new-issue.js. The new issue is created around line 33. note that the issue data returned here should include the issue url. confirm with console.log(JSON.stringify(issue, null, 2));
  • Finally, in inactive-members.md, add the label 'non-PR contribution' to the "labels"

Metadata

Metadata

Assignees

Labels

BugSomething isn't workingComplexity: MediumEREmergent RequestFeature: Refactor GHARefactoring GitHub actions to fit latest architectural normsReady for Prioritizationnon-PR contributionFor wiki additions/revisions, audit spreadsheet contributions, issue-making ERs and Epics, etc.role: back end/devOpsTasks for back-end developerssize: 3ptCan be done in 13-18 hours

Type

No type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions