Merge pull request #123 from claradaia/fix-in-filter

Fix 'in' filter argument generation

Author: abawchen

graphene_mongo/fields.py

@@ -113,8 +113,18 @@ def filter_args(self):
         if self._type._meta.filter_fields:
             for field, filter_collection in self._type._meta.filter_fields.items():
                 for each in filter_collection:
-                    filter_args[field + "__" + each] = graphene.Argument(
-                        type=getattr(graphene, str(self._type._meta.fields[field].type).replace("!", "")))
+                    filter_type = getattr(
+                        graphene, str(self._type._meta.fields[field].type).replace("!", ""))
+
+                    # handle special cases
+                    advanced_filter_types = {
+                        'in': graphene.List(filter_type),
+                        'nin': graphene.List(filter_type),
+                        'all': graphene.List(filter_type),
+                    }
+
+                    filter_type = advanced_filter_types.get(each, filter_type)
+                    filter_args[field + "__" + each] = graphene.Argument(type=filter_type)
 
         return filter_args
 

graphene_mongo/tests/nodes.py

@@ -43,7 +43,7 @@ class Meta:
         model = models.Player
         interfaces = (Node, )
         filter_fields = {
-            'first_name': ['istartswith']}
+            'first_name': ['istartswith', 'in']}
 
 
 class ReporterNode(MongoengineObjectType):

graphene_mongo/tests/test_relay_query.py

@@ -1108,3 +1108,42 @@ def resolve_multiple_foos(self, *args, **kwargs):
     schema = graphene.Schema(query=Query)
     result = schema.execute(query)
     assert not result.errors
+
+
+def test_should_filter_mongoengine_queryset_with_list(fixtures):
+
+    class Query(graphene.ObjectType):
+        players = MongoengineConnectionField(nodes.PlayerNode)
+
+    query = '''
+        query players {
+            players(firstName_In: ["Michael", "Magic"]) {
+                edges {
+                    node {
+                        firstName
+                    }
+                }
+            }
+        }
+    '''
+    expected = {
+        'players': {
+            'edges': [
+                {
+                    'node': {
+                        'firstName': 'Michael',
+                    }
+                },
+                {
+                    'node': {
+                        'firstName': 'Magic'
+                    }
+                }
+            ]
+        }
+    }
+    schema = graphene.Schema(query=Query)
+    result = schema.execute(query)
+
+    assert not result.errors
+    assert json.dumps(result.data, sort_keys=True) == json.dumps(expected, sort_keys=True)